* [PATCH] bus: ts-nbus: Fix the error handling path of ts_nbus_probe()
@ 2022-12-11 7:08 Christophe JAILLET
0 siblings, 0 replies; only message in thread
From: Christophe JAILLET @ 2022-12-11 7:08 UTC (permalink / raw)
To: Linus Walleij, Sebastien Bourdelin, Arnd Bergmann
Cc: linux-kernel, kernel-janitors, Christophe JAILLET
If an error occurs after a successful pwm_enable() call, it must be undone
by a corresponding pwm_disable(), as already done in the remove function.
Fixes: 5b143d2a6ede ("bus: add driver for the Technologic Systems NBUS")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Not sure if we need the mutex_lock()/mutex_unlock() that is in the remove
function.
---
drivers/bus/ts-nbus.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c
index 38c886dc2ed6..ed568061ba6b 100644
--- a/drivers/bus/ts-nbus.c
+++ b/drivers/bus/ts-nbus.c
@@ -324,11 +324,16 @@ static int ts_nbus_probe(struct platform_device *pdev)
ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
if (ret < 0)
- return ret;
+ goto err_disable_pwm;
dev_info(dev, "initialized\n");
return 0;
+
+err_disable_pwm:
+ pwm_disable(pwm);
+ return ret;
+
}
static int ts_nbus_remove(struct platform_device *pdev)
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-11 7:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-11 7:08 [PATCH] bus: ts-nbus: Fix the error handling path of ts_nbus_probe() Christophe JAILLET
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).