* [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
@ 2023-03-15 22:34 Saeed Mirzamohammadi
2023-03-15 22:38 ` Chaitanya Kulkarni
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Saeed Mirzamohammadi @ 2023-03-15 22:34 UTC (permalink / raw)
To: stable
Cc: saeed.mirzamohammadi, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
This adds a quirk to fix the Samsung PM1733a and PM173X reporting
bogus eui64 so they are not marked as "non globally unique" duplicates.
Cc: <stable@vger.kernel.org>
Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
---
drivers/nvme/host/pci.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 5b95c94ee40f2..c0b1caba1c893 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3359,6 +3359,10 @@ static const struct pci_device_id nvme_id_table[] = {
.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
NVME_QUIRK_DISABLE_WRITE_ZEROES|
NVME_QUIRK_IGNORE_DEV_SUBNQN, },
+ { PCI_DEVICE(0x144d, 0xa824), /* Samsung PM173X */
+ .driver_data = NVME_QUIRK_BOGUS_NID, },
+ { PCI_DEVICE(0x144d, 0xa825), /* Samsung PM1733a */
+ .driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1987, 0x5012), /* Phison E12 */
.driver_data = NVME_QUIRK_BOGUS_NID, },
{ PCI_DEVICE(0x1987, 0x5016), /* Phison E16 */
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-15 22:34 [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X Saeed Mirzamohammadi
@ 2023-03-15 22:38 ` Chaitanya Kulkarni
2023-03-16 5:15 ` Christoph Hellwig
2023-03-21 13:26 ` Christoph Hellwig
2 siblings, 0 replies; 11+ messages in thread
From: Chaitanya Kulkarni @ 2023-03-15 22:38 UTC (permalink / raw)
To: Saeed Mirzamohammadi, stable
Cc: Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg,
linux-nvme, linux-kernel
On 3/15/23 15:34, Saeed Mirzamohammadi wrote:
> This adds a quirk to fix the Samsung PM1733a and PM173X reporting
> bogus eui64 so they are not marked as "non globally unique" duplicates.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com>
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-15 22:34 [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X Saeed Mirzamohammadi
2023-03-15 22:38 ` Chaitanya Kulkarni
@ 2023-03-16 5:15 ` Christoph Hellwig
2023-03-16 21:31 ` Saeed Mirzamohammadi
2023-03-21 13:26 ` Christoph Hellwig
2 siblings, 1 reply; 11+ messages in thread
From: Christoph Hellwig @ 2023-03-16 5:15 UTC (permalink / raw)
To: Saeed Mirzamohammadi
Cc: stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
On Wed, Mar 15, 2023 at 03:34:36PM -0700, Saeed Mirzamohammadi wrote:
> This adds a quirk to fix the Samsung PM1733a and PM173X reporting
> bogus eui64 so they are not marked as "non globally unique" duplicates.
What kinds of euid do they report? Did you report the bug to Samsung?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-16 5:15 ` Christoph Hellwig
@ 2023-03-16 21:31 ` Saeed Mirzamohammadi
2023-03-17 7:33 ` Christoph Hellwig
[not found] ` <CGME20230317111849eucas1p115741dc29cc0a5c57914e60aa5216288@eucas1p1.samsung.com>
0 siblings, 2 replies; 11+ messages in thread
From: Saeed Mirzamohammadi @ 2023-03-16 21:31 UTC (permalink / raw)
To: Christoph Hellwig
Cc: # v4 . 16+,
Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel
Hi,
> On Mar 15, 2023, at 10:15 PM, Christoph Hellwig <hch@lst.de> wrote:
>
> On Wed, Mar 15, 2023 at 03:34:36PM -0700, Saeed Mirzamohammadi wrote:
>> This adds a quirk to fix the Samsung PM1733a and PM173X reporting
>> bogus eui64 so they are not marked as "non globally unique" duplicates.
>
> What kinds of euid do they report? Did you report the bug to Samsung?
eui64 values are not unique. Here is an example:
namespace1
nguid : 36554630529000710025384500000001
eui64 : 002538191100104a
namespace2
nguid : 36554630529000710025384500000002
eui64 : 002538191100104a
namespace3
nguid : 36554630529000710025384500000003
eui64 : 002538191100104a
namespace4
nguid : 36554630529000710025384500000004
eui64 : 002538191100104a
I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
Thanks,
Saeed
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-16 21:31 ` Saeed Mirzamohammadi
@ 2023-03-17 7:33 ` Christoph Hellwig
[not found] ` <CGME20230317111849eucas1p115741dc29cc0a5c57914e60aa5216288@eucas1p1.samsung.com>
1 sibling, 0 replies; 11+ messages in thread
From: Christoph Hellwig @ 2023-03-17 7:33 UTC (permalink / raw)
To: Saeed Mirzamohammadi
Cc: Christoph Hellwig, # v4 . 16+,
Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel
On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
>
> eui64 values are not unique. Here is an example:
> namespace1
> nguid : 36554630529000710025384500000001
> eui64 : 002538191100104a
> namespace2
> nguid : 36554630529000710025384500000002
> eui64 : 002538191100104a
> namespace3
> nguid : 36554630529000710025384500000003
> eui64 : 002538191100104a
> namespace4
> nguid : 36554630529000710025384500000004
> eui64 : 002538191100104a
Eww, that's really a grave bug. Interestingly enough the nguid
works, so I wonder if we should just quirk the EUI so that we have
a least some uniqueue identifier.
> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
We have plenty of Samsung folks here on the list, maybe someone can
reply?
^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <CGME20230317111849eucas1p115741dc29cc0a5c57914e60aa5216288@eucas1p1.samsung.com>]
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
[not found] ` <CGME20230317111849eucas1p115741dc29cc0a5c57914e60aa5216288@eucas1p1.samsung.com>
@ 2023-03-17 11:10 ` Pankaj Raghav
2023-03-17 16:26 ` Saeed Mirzamohammadi
0 siblings, 1 reply; 11+ messages in thread
From: Pankaj Raghav @ 2023-03-17 11:10 UTC (permalink / raw)
To: Saeed Mirzamohammadi
Cc: Christoph Hellwig, # v4 . 16+,
Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel,
javier.gonz, k.jensen, jh.i.park, p.raghav
Hi Saeed,
On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
> eui64 values are not unique. Here is an example:
> namespace1
> nguid : 36554630529000710025384500000001
> eui64 : 002538191100104a
> namespace2
> nguid : 36554630529000710025384500000002
> eui64 : 002538191100104a
> namespace3
> nguid : 36554630529000710025384500000003
> eui64 : 002538191100104a
> namespace4
> nguid : 36554630529000710025384500000004
> eui64 : 002538191100104a
>
> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
I am able to reproduce this error with a PM173X.
nvme id-ns:
root@missingno:~# nvme id-ns -n 1 /dev/nvme1 | grep eui64
eui64 : 00253891010005b3
root@missingno:~# nvme id-ns -n 2 /dev/nvme1 | grep eui64
eui64 : 00253891010005b3
root@missingno:~# nvme id-ns -n 3 /dev/nvme1 | grep eui64
eui64 : 00253891010005b3
dmesg:
[174690.305507] nvme nvme1: identifiers changed for nsid 1
[174878.481002] nvme nvme1: rescanning namespaces.
[174878.535981] nvme nvme1: duplicate IDs in subsystem for nsid 2
[174878.599982] nvme nvme1: duplicate IDs in subsystem for nsid 2
[174883.673001] nvme nvme1: rescanning namespaces.
[174883.740045] nvme nvme1: duplicate IDs in subsystem for nsid 2
[174883.784025] nvme nvme1: duplicate IDs in subsystem for nsid 3
[174883.852034] nvme nvme1: duplicate IDs in subsystem for nsid 2
[174883.892040] nvme nvme1: duplicate IDs in subsystem for nsid 3
I will report this to our firmware team. Meanwhile, Could you paste your
output id-ctrl output here? I am interested in the fw version you are using.
--
Pankaj
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-17 11:10 ` Pankaj Raghav
@ 2023-03-17 16:26 ` Saeed Mirzamohammadi
2023-03-20 13:21 ` Pankaj Raghav
0 siblings, 1 reply; 11+ messages in thread
From: Saeed Mirzamohammadi @ 2023-03-17 16:26 UTC (permalink / raw)
To: Pankaj Raghav
Cc: Christoph Hellwig, # v4 . 16+,
Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel,
javier.gonz, k.jensen, jh.i.park
Hi Pankaj,
See the output below.
> On Mar 17, 2023, at 4:10 AM, Pankaj Raghav <p.raghav@samsung.com> wrote:
>
> Hi Saeed,
> On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
>> eui64 values are not unique. Here is an example:
>> namespace1
>> nguid : 36554630529000710025384500000001
>> eui64 : 002538191100104a
>> namespace2
>> nguid : 36554630529000710025384500000002
>> eui64 : 002538191100104a
>> namespace3
>> nguid : 36554630529000710025384500000003
>> eui64 : 002538191100104a
>> namespace4
>> nguid : 36554630529000710025384500000004
>> eui64 : 002538191100104a
>>
>> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
>
> I am able to reproduce this error with a PM173X.
>
> nvme id-ns:
> root@missingno:~# nvme id-ns -n 1 /dev/nvme1 | grep eui64
> eui64 : 00253891010005b3
> root@missingno:~# nvme id-ns -n 2 /dev/nvme1 | grep eui64
> eui64 : 00253891010005b3
> root@missingno:~# nvme id-ns -n 3 /dev/nvme1 | grep eui64
> eui64 : 00253891010005b3
>
> dmesg:
> [174690.305507] nvme nvme1: identifiers changed for nsid 1
> [174878.481002] nvme nvme1: rescanning namespaces.
> [174878.535981] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174878.599982] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174883.673001] nvme nvme1: rescanning namespaces.
> [174883.740045] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174883.784025] nvme nvme1: duplicate IDs in subsystem for nsid 3
> [174883.852034] nvme nvme1: duplicate IDs in subsystem for nsid 2
> [174883.892040] nvme nvme1: duplicate IDs in subsystem for nsid 3
>
> I will report this to our firmware team. Meanwhile, Could you paste your
> output id-ctrl output here? I am interested in the fw version you are using.
NVME Identify Controller:
vid : 0x144d
ssvid : 0x108e
sn : S64VNE0R602271
mn : SAMSUNG MZWLR3T8HBLS-00AU3
fr : MPK94R5Q
rab : 8
ieee : 002538
cmic : 0x3
mdts : 8
cntlid : 0x41
ver : 0x10300
rtd3r : 0xe4e1c0
rtd3e : 0x989680
oaes : 0x300
ctratt : 0
rrls : 0
cntrltype : 0
fguid :
crdt1 : 0
crdt2 : 0
crdt3 : 0
nvmsr : 1
vwci : 255
mec : 3
oacs : 0x5f
acl : 127
aerl : 15
frmw : 0x17
lpa : 0xe
elpe : 255
npss : 0
avscc : 0x1
apsta : 0
wctemp : 345
cctemp : 358
mtfa : 130
hmpre : 0
hmmin : 0
tnvmcap : 3840755982336
unvmcap : 3989938176
rpmbs : 0
edstt : 2
dsto : 1
fwug : 255
kas : 0
hctma : 0
mntmt : 0
mxtmt : 0
sanicap : 0x3
hmminds : 0
hmmaxd : 0
nsetidmax : 0
endgidmax : 0
anatt : 0
anacap : 0
anagrpmax : 0
nanagrpid : 0
pels : 0
domainid : 0
megcap : 0
sqes : 0x66
cqes : 0x44
maxcmd : 0
nn : 32
oncs : 0x7f
fuses : 0
fna : 0x4
vwc : 0
awun : 65535
awupf : 0
icsvscc : 1
nwpc : 0
acwu : 0
ocfs : 0
sgls : 0xf0002
mnan : 0
maxdna : 0
maxcna : 0
subnqn : nqn.1994-11.com.samsung:nvme:PM1733:2.5-inch:S64VNE0R602271
ioccsz : 0
iorcsz : 0
icdoff : 0
fcatt : 0
msdbd : 0
ofcs : 0
ps 0 : mp:25.00W operational enlat:180 exlat:180 rrt:0 rrl:0
rwt:0 rwl:0 idle_power:7.00W active_power:20.00W
Thanks,
Saeed
>
> --
> Pankaj
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-17 16:26 ` Saeed Mirzamohammadi
@ 2023-03-20 13:21 ` Pankaj Raghav
0 siblings, 0 replies; 11+ messages in thread
From: Pankaj Raghav @ 2023-03-20 13:21 UTC (permalink / raw)
To: Saeed Mirzamohammadi
Cc: Christoph Hellwig, # v4 . 16+,
Keith Busch, Jens Axboe, Sagi Grimberg, linux-nvme, linux-kernel,
javier.gonz, k.jensen, jh.i.park
On 2023-03-17 17:26, Saeed Mirzamohammadi wrote:
>> Hi Saeed,
>> On Thu, Mar 16, 2023 at 09:31:38PM +0000, Saeed Mirzamohammadi wrote:
>>> eui64 values are not unique. Here is an example:
>>> namespace1
>>> nguid : 36554630529000710025384500000001
>>> eui64 : 002538191100104a
>>> namespace2
>>> nguid : 36554630529000710025384500000002
>>> eui64 : 002538191100104a
>>> namespace3
>>> nguid : 36554630529000710025384500000003
>>> eui64 : 002538191100104a
>>> namespace4
>>> nguid : 36554630529000710025384500000004
>>> eui64 : 002538191100104a
>>>
>>> I haven’t yet contacted Samsung. Do you recommend any one to reach out to?
>>
>> I am able to reproduce this error with a PM173X.
>>
>> nvme id-ns:
>> root@missingno:~# nvme id-ns -n 1 /dev/nvme1 | grep eui64
>> eui64 : 00253891010005b3
>> root@missingno:~# nvme id-ns -n 2 /dev/nvme1 | grep eui64
>> eui64 : 00253891010005b3
>> root@missingno:~# nvme id-ns -n 3 /dev/nvme1 | grep eui64
>> eui64 : 00253891010005b3
>>
>> dmesg:
>> [174690.305507] nvme nvme1: identifiers changed for nsid 1
>> [174878.481002] nvme nvme1: rescanning namespaces.
>> [174878.535981] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174878.599982] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174883.673001] nvme nvme1: rescanning namespaces.
>> [174883.740045] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174883.784025] nvme nvme1: duplicate IDs in subsystem for nsid 3
>> [174883.852034] nvme nvme1: duplicate IDs in subsystem for nsid 2
>> [174883.892040] nvme nvme1: duplicate IDs in subsystem for nsid 3
>>
>> I will report this to our firmware team. Meanwhile, Could you paste your
>> output id-ctrl output here? I am interested in the fw version you are using.
>
> NVME Identify Controller:
> vid : 0x144d
> ssvid : 0x108e
> sn : S64VNE0R602271
> mn : SAMSUNG MZWLR3T8HBLS-00AU3
> fr : MPK94R5Q
We have reported this error to our firmware team. I will keep you posted.
--
Pankaj
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-15 22:34 [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X Saeed Mirzamohammadi
2023-03-15 22:38 ` Chaitanya Kulkarni
2023-03-16 5:15 ` Christoph Hellwig
@ 2023-03-21 13:26 ` Christoph Hellwig
2023-04-14 5:12 ` Christoph Hellwig
2 siblings, 1 reply; 11+ messages in thread
From: Christoph Hellwig @ 2023-03-21 13:26 UTC (permalink / raw)
To: Saeed Mirzamohammadi
Cc: stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
Can you send a patch with a new quirk that just disables the EUI64,
but keeps the NGUID?
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X
2023-03-21 13:26 ` Christoph Hellwig
@ 2023-04-14 5:12 ` Christoph Hellwig
[not found] ` <CGME20230427074641eucas1p185bb564521b6c01366293d20970fdfe2@eucas1p1.samsung.com>
0 siblings, 1 reply; 11+ messages in thread
From: Christoph Hellwig @ 2023-04-14 5:12 UTC (permalink / raw)
To: Saeed Mirzamohammadi
Cc: stable, Keith Busch, Jens Axboe, Christoph Hellwig,
Sagi Grimberg, linux-nvme, linux-kernel
On Tue, Mar 21, 2023 at 02:26:04PM +0100, Christoph Hellwig wrote:
> Can you send a patch with a new quirk that just disables the EUI64,
> but keeps the NGUID?
Did this go anywhere?
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-04-27 7:47 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-15 22:34 [PATCH 1/1] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM173X Saeed Mirzamohammadi
2023-03-15 22:38 ` Chaitanya Kulkarni
2023-03-16 5:15 ` Christoph Hellwig
2023-03-16 21:31 ` Saeed Mirzamohammadi
2023-03-17 7:33 ` Christoph Hellwig
[not found] ` <CGME20230317111849eucas1p115741dc29cc0a5c57914e60aa5216288@eucas1p1.samsung.com>
2023-03-17 11:10 ` Pankaj Raghav
2023-03-17 16:26 ` Saeed Mirzamohammadi
2023-03-20 13:21 ` Pankaj Raghav
2023-03-21 13:26 ` Christoph Hellwig
2023-04-14 5:12 ` Christoph Hellwig
[not found] ` <CGME20230427074641eucas1p185bb564521b6c01366293d20970fdfe2@eucas1p1.samsung.com>
2023-04-27 7:37 ` Pankaj Raghav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).