From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
andersson@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
johan+linaro@kernel.org, quic_jprakash@quicinc.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, steev@kali.org
Subject: Re: [PATCH v2 05/12] arm64: dts: qcom: sc8280xp-pmics: Add PMK8280 ADC7 block
Date: Sat, 29 Oct 2022 16:17:19 +0200 [thread overview]
Message-ID: <6e5b1e5e-b10c-2a7f-7b32-c603db423f25@somainline.org> (raw)
In-Reply-To: <2842a802-3f5a-7f28-5e81-b46d7a3abca5@somainline.org>
On 29.10.2022 16:15, Konrad Dybcio wrote:
>
>
> On 29.10.2022 07:14, Manivannan Sadhasivam wrote:
>> Add support for ADC7 block available in PMK8280 for reading the
>> temperature via the AMUX pins.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>> index 4a3464f5e6e9..3c56e4cb5b5b 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
>> @@ -75,6 +75,15 @@ pmk8280_pon_resin: resin {
>> status = "disabled";
>> };
>> };
>> +
>> + pmk8280_vadc: adc@3100 {
>> + compatible = "qcom,spmi-adc7";
>> + reg = <0x3100>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>> + #io-channel-cells = <1>;
> Maybe having interrupts after reg and all the -cells below that would look better.
>
> For the contents though:
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> Konrad
Sorry for double noise, I just noticed you didn't disable this by default. Was that intended?
Konrad
>> + };
>> };
>>
>> pmc8280_1: pmic@1 {
next prev parent reply other threads:[~2022-10-29 14:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 5:14 [PATCH v2 00/12] sc8280xp-pmic updates and X13s thermal zone support Manivannan Sadhasivam
2022-10-29 5:14 ` [PATCH v2 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Manivannan Sadhasivam
2022-10-29 22:07 ` Dmitry Baryshkov
2022-10-31 21:33 ` Rob Herring
2022-11-02 20:06 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 02/12] arm64: dts: qcom: sc8280xp-pmics: Add temp alarm for PM8280_{1/2} PMICs Manivannan Sadhasivam
2022-10-29 14:13 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 03/12] arm64: dts: qcom: sc8280xp-pmics: Add thermal zones " Manivannan Sadhasivam
2022-10-29 14:13 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 04/12] arm64: dts: qcom: sc8280xp-pmics: Add support for PMK8280 RESIN input Manivannan Sadhasivam
2022-10-29 14:15 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 05/12] arm64: dts: qcom: sc8280xp-pmics: Add PMK8280 ADC7 block Manivannan Sadhasivam
2022-10-29 14:15 ` Konrad Dybcio
2022-10-29 14:17 ` Konrad Dybcio [this message]
2022-11-02 20:07 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 06/12] arm64: dts: qcom: sc8280xp-pmics: Add support for TM5 block in PMK8280 Manivannan Sadhasivam
2022-10-29 14:16 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 07/12] arm64: dts: qcom: sc8280xp-x13s: Enable PMK8280 RESIN input Manivannan Sadhasivam
2022-10-29 14:16 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 08/12] arm64: dts: qcom: sc8280xp-x13s: Add PMK8280 VADC channels Manivannan Sadhasivam
2022-10-29 14:18 ` Konrad Dybcio
2022-11-02 20:07 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} " Manivannan Sadhasivam
2022-10-29 14:20 ` Konrad Dybcio
2022-11-02 20:08 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 10/12] arm64: dts: qcom: sc8280xp-x13s: Add PMR735A VADC channel Manivannan Sadhasivam
2022-10-29 14:20 ` Konrad Dybcio
2022-11-02 20:08 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 11/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} ADC_TM5 channels Manivannan Sadhasivam
2022-10-29 14:21 ` Konrad Dybcio
2022-11-02 20:08 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 12/12] arm64: dts: qcom: sc8280xp-x13s: Add thermal zone support Manivannan Sadhasivam
2022-10-29 14:29 ` Konrad Dybcio
2022-10-29 19:07 ` Steev Klimaszewski
2022-11-03 5:50 ` Manivannan Sadhasivam
2022-11-03 10:02 ` Konrad Dybcio
2022-11-03 12:12 ` Manivannan Sadhasivam
2022-10-29 19:26 ` [PATCH v2 00/12] sc8280xp-pmic updates and X13s " Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e5b1e5e-b10c-2a7f-7b32-c603db423f25@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_jprakash@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).