From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
andersson@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
johan+linaro@kernel.org, quic_jprakash@quicinc.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, steev@kali.org
Subject: Re: [PATCH v2 08/12] arm64: dts: qcom: sc8280xp-x13s: Add PMK8280 VADC channels
Date: Sat, 29 Oct 2022 16:18:53 +0200 [thread overview]
Message-ID: <cbcf15b5-8cae-671c-b783-3213d55c575b@somainline.org> (raw)
In-Reply-To: <20221029051449.30678-9-manivannan.sadhasivam@linaro.org>
On 29.10.2022 07:14, Manivannan Sadhasivam wrote:
> Add VADC channels for measuring the on-chip die temperature and external
> crystal osciallator temperature of PMK8280.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index 6aa8cf6d9776..18315743313b 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -7,6 +7,7 @@
> /dts-v1/;
>
> #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/iio/qcom,spmi-adc7-pmk8350.h>
> #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>
> #include "sc8280xp.dtsi"
> @@ -173,6 +174,23 @@ &pmk8280_pon_resin {
> status = "okay";
> };
>
> +&pmk8280_vadc {
> + status = "okay";
As I mentioned in the patch adding this to the PMIC DTSI, it's enabled by default (perhaps by mistake).
> +
> + pmic-die-temp@3 {
> + reg = <PMK8350_ADC7_DIE_TEMP>;
> + label = "pmk8280_die_temp";
> + qcom,pre-scaling = <1 1>;
> + };
> +
> + xo-therm@44 {
> + reg = <PMK8350_ADC7_AMUX_THM1_100K_PU>;
> + label = "pmk8280_xo_therm";
> + qcom,ratiometric;
> + qcom,hw-settle-time = <200>;
having qcom,hw-settle-time above qcom,ratiometric would make this more reverse-Christmas-tree-y, but
maybe I'm just picky..
For the contents though:
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> + };
> +};
> +
> &qup0 {
> status = "okay";
> };
next prev parent reply other threads:[~2022-10-29 14:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 5:14 [PATCH v2 00/12] sc8280xp-pmic updates and X13s thermal zone support Manivannan Sadhasivam
2022-10-29 5:14 ` [PATCH v2 01/12] dt-bindings: iio: qcom: adc7-pm8350: Allow specifying SID for channels Manivannan Sadhasivam
2022-10-29 22:07 ` Dmitry Baryshkov
2022-10-31 21:33 ` Rob Herring
2022-11-02 20:06 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 02/12] arm64: dts: qcom: sc8280xp-pmics: Add temp alarm for PM8280_{1/2} PMICs Manivannan Sadhasivam
2022-10-29 14:13 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 03/12] arm64: dts: qcom: sc8280xp-pmics: Add thermal zones " Manivannan Sadhasivam
2022-10-29 14:13 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 04/12] arm64: dts: qcom: sc8280xp-pmics: Add support for PMK8280 RESIN input Manivannan Sadhasivam
2022-10-29 14:15 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 05/12] arm64: dts: qcom: sc8280xp-pmics: Add PMK8280 ADC7 block Manivannan Sadhasivam
2022-10-29 14:15 ` Konrad Dybcio
2022-10-29 14:17 ` Konrad Dybcio
2022-11-02 20:07 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 06/12] arm64: dts: qcom: sc8280xp-pmics: Add support for TM5 block in PMK8280 Manivannan Sadhasivam
2022-10-29 14:16 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 07/12] arm64: dts: qcom: sc8280xp-x13s: Enable PMK8280 RESIN input Manivannan Sadhasivam
2022-10-29 14:16 ` Konrad Dybcio
2022-10-29 5:14 ` [PATCH v2 08/12] arm64: dts: qcom: sc8280xp-x13s: Add PMK8280 VADC channels Manivannan Sadhasivam
2022-10-29 14:18 ` Konrad Dybcio [this message]
2022-11-02 20:07 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} " Manivannan Sadhasivam
2022-10-29 14:20 ` Konrad Dybcio
2022-11-02 20:08 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 10/12] arm64: dts: qcom: sc8280xp-x13s: Add PMR735A VADC channel Manivannan Sadhasivam
2022-10-29 14:20 ` Konrad Dybcio
2022-11-02 20:08 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 11/12] arm64: dts: qcom: sc8280xp-x13s: Add PM8280_{1/2} ADC_TM5 channels Manivannan Sadhasivam
2022-10-29 14:21 ` Konrad Dybcio
2022-11-02 20:08 ` Krzysztof Kozlowski
2022-10-29 5:14 ` [PATCH v2 12/12] arm64: dts: qcom: sc8280xp-x13s: Add thermal zone support Manivannan Sadhasivam
2022-10-29 14:29 ` Konrad Dybcio
2022-10-29 19:07 ` Steev Klimaszewski
2022-11-03 5:50 ` Manivannan Sadhasivam
2022-11-03 10:02 ` Konrad Dybcio
2022-11-03 12:12 ` Manivannan Sadhasivam
2022-10-29 19:26 ` [PATCH v2 00/12] sc8280xp-pmic updates and X13s " Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbcf15b5-8cae-671c-b783-3213d55c575b@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_jprakash@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).