* [PATCH] hwmon: powerz: add support for ChargerLAB KM002C
@ 2023-09-11 5:44 Thomas Weißschuh
2023-09-18 19:05 ` Guenter Roeck
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Weißschuh @ 2023-09-11 5:44 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck
Cc: linux-hwmon, linux-kernel, Douglas Gilbert, Thomas Weißschuh
The KM002C is similar to the KM003C and seems to use the same
protocol and firmware.
Reported-by: Douglas Gilbert <dgilbert@interlog.com>
Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
This patch is based on hwmon-next,
commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
drivers/hwmon/powerz.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c
index 2b9693aee6f6..cfb635f94d66 100644
--- a/drivers/hwmon/powerz.c
+++ b/drivers/hwmon/powerz.c
@@ -254,6 +254,7 @@ static void powerz_disconnect(struct usb_interface *intf)
}
static const struct usb_device_id powerz_id_table[] = {
+ { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) }, /* ChargerLAB POWER-Z KM002C */
{ USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) }, /* ChargerLAB POWER-Z KM003C */
{ }
};
---
base-commit: 80369d9e1f2f16993ae6d148553c37bf65a209e4
change-id: 20230911-powerz-km002c-94afb4d3d645
Best regards,
--
Thomas Weißschuh <linux@weissschuh.net>
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C
2023-09-11 5:44 [PATCH] hwmon: powerz: add support for ChargerLAB KM002C Thomas Weißschuh
@ 2023-09-18 19:05 ` Guenter Roeck
2023-09-19 17:15 ` Thomas Weißschuh
2023-09-19 18:02 ` Konstantin Ryabitsev
0 siblings, 2 replies; 5+ messages in thread
From: Guenter Roeck @ 2023-09-18 19:05 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Jean Delvare, linux-hwmon, linux-kernel, Douglas Gilbert
On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
> The KM002C is similar to the KM003C and seems to use the same
> protocol and firmware.
>
> Reported-by: Douglas Gilbert <dgilbert@interlog.com>
> Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>
> This patch is based on hwmon-next,
> commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Applied, but please be more careful with your comments and Signed-off-by:
tags. There should only be one '---', and one signature.
Thanks,
Guenter
> ---
> drivers/hwmon/powerz.c | 1 +
> 1 file changed, 1 insertion(+)
>
>
> ---
> base-commit: 80369d9e1f2f16993ae6d148553c37bf65a209e4
> change-id: 20230911-powerz-km002c-94afb4d3d645
>
> Best regards,
>
> diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c
> index 2b9693aee6f6..cfb635f94d66 100644
> --- a/drivers/hwmon/powerz.c
> +++ b/drivers/hwmon/powerz.c
> @@ -254,6 +254,7 @@ static void powerz_disconnect(struct usb_interface *intf)
> }
>
> static const struct usb_device_id powerz_id_table[] = {
> + { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) }, /* ChargerLAB POWER-Z KM002C */
> { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) }, /* ChargerLAB POWER-Z KM003C */
> { }
> };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C
2023-09-18 19:05 ` Guenter Roeck
@ 2023-09-19 17:15 ` Thomas Weißschuh
2023-09-19 17:24 ` Guenter Roeck
2023-09-19 18:02 ` Konstantin Ryabitsev
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Weißschuh @ 2023-09-19 17:15 UTC (permalink / raw)
To: Guenter Roeck; +Cc: Jean Delvare, linux-hwmon, linux-kernel, Douglas Gilbert
On 2023-09-18 12:05:19-0700, Guenter Roeck wrote:
> On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
> > The KM002C is similar to the KM003C and seems to use the same
> > protocol and firmware.
> >
> > Reported-by: Douglas Gilbert <dgilbert@interlog.com>
> > Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> >
> > This patch is based on hwmon-next,
> > commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>
> Applied, but please be more careful with your comments and Signed-off-by:
> tags. There should only be one '---', and one signature.
Thanks,
the duplicate Signed-off-by is indeed an oversight which I'll
try to avoid in the future.
As for the '---':
Two of them are generated by the 'b4' tool and I added one manually with
the hwmon-next information.
For other subsystems this wasn't an issue so far.
Are these duplicate sections a problem for your personal tooling or is
it affecting something more widespread?
I can try to avoid these issues when sending patches to you specifically
or maybe changes in b4 in general are the correct solution.
Thomas
> > ---
> > drivers/hwmon/powerz.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >
> > ---
> > base-commit: 80369d9e1f2f16993ae6d148553c37bf65a209e4
> > change-id: 20230911-powerz-km002c-94afb4d3d645
> >
> > Best regards,
> >
> > diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c
> > index 2b9693aee6f6..cfb635f94d66 100644
> > --- a/drivers/hwmon/powerz.c
> > +++ b/drivers/hwmon/powerz.c
> > @@ -254,6 +254,7 @@ static void powerz_disconnect(struct usb_interface *intf)
> > }
> >
> > static const struct usb_device_id powerz_id_table[] = {
> > + { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) }, /* ChargerLAB POWER-Z KM002C */
> > { USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) }, /* ChargerLAB POWER-Z KM003C */
> > { }
> > };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C
2023-09-19 17:15 ` Thomas Weißschuh
@ 2023-09-19 17:24 ` Guenter Roeck
0 siblings, 0 replies; 5+ messages in thread
From: Guenter Roeck @ 2023-09-19 17:24 UTC (permalink / raw)
To: Thomas Weißschuh
Cc: Jean Delvare, linux-hwmon, linux-kernel, Douglas Gilbert
On 9/19/23 10:15, Thomas Weißschuh wrote:
> On 2023-09-18 12:05:19-0700, Guenter Roeck wrote:
>> On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
>>> The KM002C is similar to the KM003C and seems to use the same
>>> protocol and firmware.
>>>
>>> Reported-by: Douglas Gilbert <dgilbert@interlog.com>
>>> Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
>>> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>>> ---
>>>
>>> This patch is based on hwmon-next,
>>> commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
>>>
>>> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
>>
>> Applied, but please be more careful with your comments and Signed-off-by:
>> tags. There should only be one '---', and one signature.
>
> Thanks,
>
> the duplicate Signed-off-by is indeed an oversight which I'll
> try to avoid in the future.
>
> As for the '---':
>
> Two of them are generated by the 'b4' tool and I added one manually with
> the hwmon-next information.
> For other subsystems this wasn't an issue so far.
>
> Are these duplicate sections a problem for your personal tooling or is
> it affecting something more widespread?
>
I don't know. All I know is that checkpatch complained about the double signature,
which causes my scripts to fail. I don't know what "git am" does if it encounters
a double "---" because my scripts bailed out due to the double signature.
Guenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C
2023-09-18 19:05 ` Guenter Roeck
2023-09-19 17:15 ` Thomas Weißschuh
@ 2023-09-19 18:02 ` Konstantin Ryabitsev
1 sibling, 0 replies; 5+ messages in thread
From: Konstantin Ryabitsev @ 2023-09-19 18:02 UTC (permalink / raw)
To: Thomas Weißschuh, Guenter Roeck
Cc: Jean Delvare, linux-hwmon, linux-kernel, Douglas Gilbert
September 19, 2023 at 1:15 PM, "Thomas Weißschuh" <linux@weissschuh.net> wrote:
> On 2023-09-18 12:05:19-0700, Guenter Roeck wrote:
>
> >
> > On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
> > The KM002C is similar to the KM003C and seems to use the same
> > protocol and firmware.
> >
> > Reported-by: Douglas Gilbert <dgilbert@interlog.com>
> > Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> > ---
> >
> > This patch is based on hwmon-next,
> > commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
> >
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> >
> > Applied, but please be more careful with your comments and Signed-off-by:
> > tags. There should only be one '---', and one signature.
> >
>
> Thanks,
>
> the duplicate Signed-off-by is indeed an oversight which I'll
> try to avoid in the future.
>
> As for the '---':
>
> Two of them are generated by the 'b4' tool and I added one manually with
> the hwmon-next information.
> For other subsystems this wasn't an issue so far.
>
> Are these duplicate sections a problem for your personal tooling or is
> it affecting something more widespread?
There should be no impact on any tooling, to my knowledge. Only the first --- matters for git, any additional ones are ignored.
-K
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-09-19 18:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 5:44 [PATCH] hwmon: powerz: add support for ChargerLAB KM002C Thomas Weißschuh
2023-09-18 19:05 ` Guenter Roeck
2023-09-19 17:15 ` Thomas Weißschuh
2023-09-19 17:24 ` Guenter Roeck
2023-09-19 18:02 ` Konstantin Ryabitsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).