From: Maximilian Luz <luzmaximilian@gmail.com>
To: Baokun Li <libaokun1@huawei.com>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <mgross@linux.intel.com>
Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com,
yangjihong1@huawei.com, yukuai3@huawei.com,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_request_layer.c
Date: Wed, 9 Jun 2021 13:36:43 +0200 [thread overview]
Message-ID: <6eb2ed3a-13fb-54cc-4416-d8e7671e87f3@gmail.com> (raw)
In-Reply-To: <20210609072638.1358174-1-libaokun1@huawei.com>
On 6/9/21 9:26 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in ssh_request_layer.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Looks good to me, thanks!
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Regards,
Max
> ---
> V1->V2:
> CC mailist
>
> .../surface/aggregator/ssh_request_layer.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/surface/aggregator/ssh_request_layer.c b/drivers/platform/surface/aggregator/ssh_request_layer.c
> index 52a83a8fcf82..fec2d7af2646 100644
> --- a/drivers/platform/surface/aggregator/ssh_request_layer.c
> +++ b/drivers/platform/surface/aggregator/ssh_request_layer.c
> @@ -863,9 +863,7 @@ static void ssh_rtl_timeout_reap(struct work_struct *work)
> clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);
>
> atomic_dec(&rtl->pending.count);
> - list_del(&r->node);
> -
> - list_add_tail(&r->node, &claimed);
> + list_move_tail(&r->node, &claimed);
> }
> spin_unlock(&rtl->pending.lock);
>
> @@ -1204,8 +1202,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl)
> smp_mb__before_atomic();
> clear_bit(SSH_REQUEST_SF_QUEUED_BIT, &r->state);
>
> - list_del(&r->node);
> - list_add_tail(&r->node, &claimed);
> + list_move_tail(&r->node, &claimed);
> }
> spin_unlock(&rtl->queue.lock);
>
> @@ -1238,8 +1235,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl)
> smp_mb__before_atomic();
> clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);
>
> - list_del(&r->node);
> - list_add_tail(&r->node, &claimed);
> + list_move_tail(&r->node, &claimed);
> }
> spin_unlock(&rtl->pending.lock);
> }
>
next prev parent reply other threads:[~2021-06-09 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 7:26 [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_request_layer.c Baokun Li
2021-06-09 11:36 ` Maximilian Luz [this message]
2021-06-09 14:24 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eb2ed3a-13fb-54cc-4416-d8e7671e87f3@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).