Re: [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_request_layer.c

From: Hans de Goede <hdegoede@redhat.com>
To: Baokun Li <libaokun1@huawei.com>,
	linux-kernel@vger.kernel.org,
	Maximilian Luz <luzmaximilian@gmail.com>,
	Mark Gross <mgross@linux.intel.com>
Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com,
	yangjihong1@huawei.com, yukuai3@huawei.com,
	platform-driver-x86@vger.kernel.org,
	kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next v2] platform/surface: aggregator: Use list_move_tail instead of list_del/list_add_tail in ssh_request_layer.c
Date: Wed, 9 Jun 2021 16:24:05 +0200	[thread overview]
Message-ID: <ebe9e952-9938-adfd-7f52-658aec2cd466@redhat.com> (raw)
In-Reply-To: <20210609072638.1358174-1-libaokun1@huawei.com>

Hi,

On 6/9/21 9:26 AM, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in ssh_request_layer.c.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
> V1->V2:
> 	CC mailist
> 
>  .../surface/aggregator/ssh_request_layer.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/platform/surface/aggregator/ssh_request_layer.c b/drivers/platform/surface/aggregator/ssh_request_layer.c
> index 52a83a8fcf82..fec2d7af2646 100644
> --- a/drivers/platform/surface/aggregator/ssh_request_layer.c
> +++ b/drivers/platform/surface/aggregator/ssh_request_layer.c
> @@ -863,9 +863,7 @@ static void ssh_rtl_timeout_reap(struct work_struct *work)
>  		clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);
>  
>  		atomic_dec(&rtl->pending.count);
> -		list_del(&r->node);
> -
> -		list_add_tail(&r->node, &claimed);
> +		list_move_tail(&r->node, &claimed);
>  	}
>  	spin_unlock(&rtl->pending.lock);
>  
> @@ -1204,8 +1202,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl)
>  		smp_mb__before_atomic();
>  		clear_bit(SSH_REQUEST_SF_QUEUED_BIT, &r->state);
>  
> -		list_del(&r->node);
> -		list_add_tail(&r->node, &claimed);
> +		list_move_tail(&r->node, &claimed);
>  	}
>  	spin_unlock(&rtl->queue.lock);
>  
> @@ -1238,8 +1235,7 @@ void ssh_rtl_shutdown(struct ssh_rtl *rtl)
>  			smp_mb__before_atomic();
>  			clear_bit(SSH_REQUEST_SF_PENDING_BIT, &r->state);
>  
> -			list_del(&r->node);
> -			list_add_tail(&r->node, &claimed);
> +			list_move_tail(&r->node, &claimed);
>  		}
>  		spin_unlock(&rtl->pending.lock);
>  	}
> 