linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: gengdongjiu <gengdongjiu@huawei.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
	Kim Phillips <kim.phillips@arm.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	Will Deacon <will.deacon@arm.com>
Cc: <robh@kernel.org>, Andi Kleen <ak@linux.intel.com>,
	<mathieu.poirier@linaro.org>, <pawel.moll@arm.com>,
	<suzuki.poulose@arm.com>, <marc.zyngier@arm.com>,
	<linux-kernel@vger.kernel.org>,
	<alexander.shishkin@linux.intel.com>, <peterz@infradead.org>,
	<mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
	<tglx@linutronix.de>, "Wang Nan" <wangnan0@huawei.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4] perf tools: Add ARM Statistical Profiling Extensions (SPE) support
Date: Fri, 12 Jan 2018 15:51:00 +0800	[thread overview]
Message-ID: <6ec89c5b-e978-bd2e-e350-df0c7c41ac33@huawei.com> (raw)
In-Reply-To: <0a07a10c-fc0c-3f97-ac01-59429aab0937@intel.com>

On 2018/1/11 22:17, Adrian Hunter wrote:
>>   (e.g., via 'perf inject --itrace'), are also not supported
>>
>> - technically both cs-etm and spe can be used simultaneously, however
>>   disabled for simplicity in this release
>>
>> Signed-off-by: Kim Phillips <kim.phillips@arm.com>
> For what is there now, it looks fine from the auxtrace point of view.  There
> are a couple of minor points below but nevertheless:
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

This patch is good to me.
Reviewed-by: gengdongjiu@huawei.com

> 
>> ---
>> v4: rebased onto acme's perf/core, whitespace fixes.

  reply	other threads:[~2018-01-12  7:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-21 23:33 [PATCH v4] perf tools: Add ARM Statistical Profiling Extensions (SPE) support Kim Phillips
2017-11-29 17:21 ` Kim Phillips
2018-01-11 14:17 ` Adrian Hunter
2018-01-12  7:51   ` gengdongjiu [this message]
2018-01-12 14:14   ` Arnaldo Carvalho de Melo
2018-01-13  1:27     ` [PATCH v5] " Kim Phillips
2018-01-13 18:42       ` Arnaldo Carvalho de Melo
2018-01-14 19:28         ` [PATCH v6] " Kim Phillips
2018-01-17 16:32           ` [tip:perf/core] " tip-bot for Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ec89c5b-e978-bd2e-e350-df0c7c41ac33@huawei.com \
    --to=gengdongjiu@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=kim.phillips@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=pawel.moll@arm.com \
    --cc=peterz@infradead.org \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=wangnan0@huawei.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).