linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, shuah@kernel.org, sboyd@kernel.org,
	tglx@linutronix.de, john.stultz@linaro.org
Subject: Re: [PATCH] selftests/timers: Turn off timeout setting
Date: Tue, 25 Feb 2020 10:16:10 -0500	[thread overview]
Message-ID: <6ee3dd78-675b-ac0e-87ce-96a7766d597b@redhat.com> (raw)
In-Reply-To: <20200225101809.9986-1-po-hsu.lin@canonical.com>

On 2/25/20 5:18 AM, Po-Hsu Lin wrote:
> Tests in timers especially nsleep-lat, set-timer-lat,
> inconsistency-check and raw_skew these 4 tests can take longer than
> the default 45 seconds that introduced in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
> 
> Disable the timeout setting for timers instead of looking for an proper
> value to make it more general.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>   tools/testing/selftests/timers/settings | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 tools/testing/selftests/timers/settings
> 
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
> 

Hi,

Michael recently posted a patch that adds the various selftest settings 
files to the TEST_FILES list, ensuring that they get copied to the 
install directory along with the tests:

https://lore.kernel.org/linux-kselftest/20200220044241.2878-1-mpe@ellerman.id.au/

I think if you add that to the corresponding Makefile, you should be set.

Regards,

-- Joe


  reply	other threads:[~2020-02-25 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 10:18 [PATCH] selftests/timers: Turn off timeout setting Po-Hsu Lin
2020-02-25 15:16 ` Joe Lawrence [this message]
2020-02-25 15:30 ` shuah
2020-02-25 16:26   ` Po-Hsu Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6ee3dd78-675b-ac0e-87ce-96a7766d597b@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=po-hsu.lin@canonical.com \
    --cc=sboyd@kernel.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).