From: shuah <shuah@kernel.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>, linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, sboyd@kernel.org,
tglx@linutronix.de, john.stultz@linaro.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests/timers: Turn off timeout setting
Date: Tue, 25 Feb 2020 08:30:41 -0700 [thread overview]
Message-ID: <bbc88e24-835b-2b1e-2997-255896b14cc4@kernel.org> (raw)
In-Reply-To: <20200225101809.9986-1-po-hsu.lin@canonical.com>
On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> Tests in timers especially nsleep-lat, set-timer-lat,
> inconsistency-check and raw_skew these 4 tests can take longer than
> the default 45 seconds that introduced in commit 852c8cbf
> (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
>
> Disable the timeout setting for timers instead of looking for an proper
> value to make it more general.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
> tools/testing/selftests/timers/settings | 1 +
> 1 file changed, 1 insertion(+)
> create mode 100644 tools/testing/selftests/timers/settings
>
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
>
What happens when you disable this and set it to 0? How long does the
rest run in this case? Can you add the details to the change log please.
thanks,
-- Shuah
next prev parent reply other threads:[~2020-02-25 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 10:18 [PATCH] selftests/timers: Turn off timeout setting Po-Hsu Lin
2020-02-25 15:16 ` Joe Lawrence
2020-02-25 15:30 ` shuah [this message]
2020-02-25 16:26 ` Po-Hsu Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbc88e24-835b-2b1e-2997-255896b14cc4@kernel.org \
--to=shuah@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=po-hsu.lin@canonical.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).