* [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c
@ 2016-08-01 11:40 Juergen Gross
2016-08-01 14:10 ` Boris Ostrovsky
0 siblings, 1 reply; 5+ messages in thread
From: Juergen Gross @ 2016-08-01 11:40 UTC (permalink / raw)
To: linux-kernel, xen-devel; +Cc: boris.ostrovsky, david.vrabel, Juergen Gross
There are two functions with name xen_pmu_init() in the kernel. Rename
the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
arch/x86/xen/pmu.c
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/xen/sys-hypervisor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
index 6881b3c..17ea846 100644
--- a/drivers/xen/sys-hypervisor.c
+++ b/drivers/xen/sys-hypervisor.c
@@ -455,7 +455,7 @@ static const struct attribute_group xen_pmu_group = {
.attrs = xen_pmu_attrs,
};
-static int __init xen_pmu_init(void)
+static int __init xen_sysfs_pmu_init(void)
{
return sysfs_create_group(hypervisor_kobj, &xen_pmu_group);
}
@@ -485,7 +485,7 @@ static int __init hyper_sysfs_init(void)
goto prop_out;
#ifdef CONFIG_XEN_HAVE_VPMU
if (xen_initial_domain()) {
- ret = xen_pmu_init();
+ ret = xen_sysfs_pmu_init();
if (ret) {
sysfs_remove_group(hypervisor_kobj,
&xen_properties_group);
--
2.6.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c
2016-08-01 11:40 [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Juergen Gross
@ 2016-08-01 14:10 ` Boris Ostrovsky
2016-08-01 15:44 ` Juergen Gross
0 siblings, 1 reply; 5+ messages in thread
From: Boris Ostrovsky @ 2016-08-01 14:10 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel; +Cc: david.vrabel
On 08/01/2016 07:40 AM, Juergen Gross wrote:
> There are two functions with name xen_pmu_init() in the kernel. Rename
> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
> arch/x86/xen/pmu.c
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
While at it, how about changing xen_properties_init to
xen_sysfs_properties_init as well for consistency?
-boris
> ---
> drivers/xen/sys-hypervisor.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c
> index 6881b3c..17ea846 100644
> --- a/drivers/xen/sys-hypervisor.c
> +++ b/drivers/xen/sys-hypervisor.c
> @@ -455,7 +455,7 @@ static const struct attribute_group xen_pmu_group = {
> .attrs = xen_pmu_attrs,
> };
>
> -static int __init xen_pmu_init(void)
> +static int __init xen_sysfs_pmu_init(void)
> {
> return sysfs_create_group(hypervisor_kobj, &xen_pmu_group);
> }
> @@ -485,7 +485,7 @@ static int __init hyper_sysfs_init(void)
> goto prop_out;
> #ifdef CONFIG_XEN_HAVE_VPMU
> if (xen_initial_domain()) {
> - ret = xen_pmu_init();
> + ret = xen_sysfs_pmu_init();
> if (ret) {
> sysfs_remove_group(hypervisor_kobj,
> &xen_properties_group);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c
2016-08-01 14:10 ` Boris Ostrovsky
@ 2016-08-01 15:44 ` Juergen Gross
2016-08-01 15:46 ` Boris Ostrovsky
0 siblings, 1 reply; 5+ messages in thread
From: Juergen Gross @ 2016-08-01 15:44 UTC (permalink / raw)
To: Boris Ostrovsky, linux-kernel, xen-devel; +Cc: david.vrabel
On 01/08/16 16:10, Boris Ostrovsky wrote:
> On 08/01/2016 07:40 AM, Juergen Gross wrote:
>> There are two functions with name xen_pmu_init() in the kernel. Rename
>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
>> arch/x86/xen/pmu.c
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> While at it, how about changing xen_properties_init to
> xen_sysfs_properties_init as well for consistency?
I don't mind changing this name, too. Will send V2.
Juergen
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c
2016-08-01 15:44 ` Juergen Gross
@ 2016-08-01 15:46 ` Boris Ostrovsky
2016-08-01 15:49 ` Juergen Gross
0 siblings, 1 reply; 5+ messages in thread
From: Boris Ostrovsky @ 2016-08-01 15:46 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, xen-devel; +Cc: david.vrabel
On 08/01/2016 11:44 AM, Juergen Gross wrote:
> On 01/08/16 16:10, Boris Ostrovsky wrote:
>> On 08/01/2016 07:40 AM, Juergen Gross wrote:
>>> There are two functions with name xen_pmu_init() in the kernel. Rename
>>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
>>> arch/x86/xen/pmu.c
>>>
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> While at it, how about changing xen_properties_init to
>> xen_sysfs_properties_init as well for consistency?
> I don't mind changing this name, too. Will send V2.
Thanks. Actually, there is one more --- xen_compilation_init().
-boris
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c
2016-08-01 15:46 ` Boris Ostrovsky
@ 2016-08-01 15:49 ` Juergen Gross
0 siblings, 0 replies; 5+ messages in thread
From: Juergen Gross @ 2016-08-01 15:49 UTC (permalink / raw)
To: Boris Ostrovsky, linux-kernel, xen-devel; +Cc: david.vrabel
On 01/08/16 17:46, Boris Ostrovsky wrote:
> On 08/01/2016 11:44 AM, Juergen Gross wrote:
>> On 01/08/16 16:10, Boris Ostrovsky wrote:
>>> On 08/01/2016 07:40 AM, Juergen Gross wrote:
>>>> There are two functions with name xen_pmu_init() in the kernel. Rename
>>>> the one in drivers/xen/sys-hypervisor.c to avoid shadowing the one in
>>>> arch/x86/xen/pmu.c
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>> While at it, how about changing xen_properties_init to
>>> xen_sysfs_properties_init as well for consistency?
>> I don't mind changing this name, too. Will send V2.
>
> Thanks. Actually, there is one more --- xen_compilation_init().
I'll do all of them.
Juergen
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-01 17:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-01 11:40 [PATCH] xen: rename xen_pmu_init() in sys-hypervisor.c Juergen Gross
2016-08-01 14:10 ` Boris Ostrovsky
2016-08-01 15:44 ` Juergen Gross
2016-08-01 15:46 ` Boris Ostrovsky
2016-08-01 15:49 ` Juergen Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).