* Re: [PATCH] Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent()
@ 2020-04-04 7:06 Markus Elfring
2020-04-07 16:03 ` Alex Dewar
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-04-04 7:06 UTC (permalink / raw)
To: Alex Dewar, cocci, kernel-janitors, Gilles Muller, Julia Lawall,
Masahiro Yamada, Michal Marek, Nicolas Palix
Cc: Allison Randal, Christoph Hellwig, Enrico Weigelt,
Greg Kroah-Hartman, Kate Stewart, Luis Chamberlain,
Thomas Gleixner, linux-kernel
> Commit dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()"), in
> removing dma_zalloc_coherent() treewide, inadvertently removed the patch
> rule for dma_alloc_coherent(), leaving Coccinelle unable to auto-generate
> patches for this case. Fix this.
I suggest to reconsider also the distribution of recipients for your patch
according to the fields “Cc” and “To”.
Will the software development attention grow in a way so that further
implementation details can be adjusted also for the mentioned SmPL script?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent()
2020-04-04 7:06 [PATCH] Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent() Markus Elfring
@ 2020-04-07 16:03 ` Alex Dewar
2020-04-07 17:10 ` Markus Elfring
0 siblings, 1 reply; 5+ messages in thread
From: Alex Dewar @ 2020-04-07 16:03 UTC (permalink / raw)
To: Markus Elfring
Cc: cocci, kernel-janitors, Gilles Muller, Julia Lawall,
Masahiro Yamada, Michal Marek, Nicolas Palix, Allison Randal,
Christoph Hellwig, Enrico Weigelt, Greg Kroah-Hartman,
Kate Stewart, Luis Chamberlain, Thomas Gleixner, linux-kernel
On Sat, Apr 04, 2020 at 09:06:46AM +0200, Markus Elfring wrote:
> > Commit dfd32cad146e ("dma-mapping: remove dma_zalloc_coherent()"), in
> > removing dma_zalloc_coherent() treewide, inadvertently removed the patch
> > rule for dma_alloc_coherent(), leaving Coccinelle unable to auto-generate
> > patches for this case. Fix this.
>
> I suggest to reconsider also the distribution of recipients for your patch
> according to the fields “Cc” and “To”.
Good point.
>
> Will the software development attention grow in a way so that further
> implementation details can be adjusted also for the mentioned SmPL script?
I'm not sure I understand what you mean. Would you mind clarifying?
Best,
Alex
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent()
2020-04-07 16:03 ` Alex Dewar
@ 2020-04-07 17:10 ` Markus Elfring
2020-04-09 11:44 ` Alex Dewar
0 siblings, 1 reply; 5+ messages in thread
From: Markus Elfring @ 2020-04-07 17:10 UTC (permalink / raw)
To: Alex Dewar, cocci
Cc: kernel-janitors, Gilles Muller, Julia Lawall, Masahiro Yamada,
Michal Marek, Nicolas Palix, Allison Randal, Christoph Hellwig,
Enrico Weigelt, Greg Kroah-Hartman, Kate Stewart,
Luis Chamberlain, Thomas Gleixner, linux-kernel
>> Will the software development attention grow in a way so that further
>> implementation details can be adjusted also for the mentioned SmPL script?
>
> I'm not sure I understand what you mean. Would you mind clarifying?
You would like to a change a file for which some software development
discussions happened a while ago.
Do you get any further ideas from available information in message archives?
Julia Lawall (and me) pointed special development concerns out.
Example:
Code duplications in SmPL disjunctions
https://lore.kernel.org/cocci/alpine.DEB.2.21.2004062115000.10239@hadrien/
https://systeme.lip6.fr/pipermail/cocci/2020-April/007099.html
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent()
2020-04-07 17:10 ` Markus Elfring
@ 2020-04-09 11:44 ` Alex Dewar
2020-04-09 15:25 ` Markus Elfring
0 siblings, 1 reply; 5+ messages in thread
From: Alex Dewar @ 2020-04-09 11:44 UTC (permalink / raw)
To: Markus Elfring
Cc: cocci, kernel-janitors, Gilles Muller, Julia Lawall,
Masahiro Yamada, Michal Marek, Nicolas Palix, Allison Randal,
Christoph Hellwig, Enrico Weigelt, Greg Kroah-Hartman,
Kate Stewart, Luis Chamberlain, Thomas Gleixner, linux-kernel
On Tue, Apr 07, 2020 at 07:10:46PM +0200, Markus Elfring wrote:
> >> Will the software development attention grow in a way so that further
> >> implementation details can be adjusted also for the mentioned SmPL script?
> >
> > I'm not sure I understand what you mean. Would you mind clarifying?
>
> You would like to a change a file for which some software development
> discussions happened a while ago.
> Do you get any further ideas from available information in message archives?
Hi Markus,
What should I be looking for in the archives? I've referenced what I
think is the relevant commit here.
>
> Julia Lawall (and me) pointed special development concerns out.
>
> Example:
> Code duplications in SmPL disjunctions
> https://lore.kernel.org/cocci/alpine.DEB.2.21.2004062115000.10239@hadrien/
> https://systeme.lip6.fr/pipermail/cocci/2020-April/007099.html
I have replied to these messages now.
Best,
Alex
>
> Regards,
> Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent()
2020-04-09 11:44 ` Alex Dewar
@ 2020-04-09 15:25 ` Markus Elfring
0 siblings, 0 replies; 5+ messages in thread
From: Markus Elfring @ 2020-04-09 15:25 UTC (permalink / raw)
To: Alex Dewar, cocci, kernel-janitors
Cc: Gilles Muller, Julia Lawall, Masahiro Yamada, Michal Marek,
Nicolas Palix, Allison Randal, Christoph Hellwig, Enrico Weigelt,
Greg Kroah-Hartman, Kate Stewart, Luis Chamberlain,
Thomas Gleixner, linux-kernel
> What should I be looking for in the archives?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/coccinelle/api/alloc/zalloc-simple.cocci?id=dfd32cad146e3624970eee9329e99d2c6ef751b3
Several software development discussions might be interesting
also before the change “dma-mapping: remove dma_zalloc_coherent()”.
> I've referenced what I think is the relevant commit here.
How do you think about the extend the software development background
another bit?
> I have replied to these messages now.
Do you refer to your response from 2020-04-07?
https://systeme.lip6.fr/pipermail/cocci/2020-April/007102.html
https://lore.kernel.org/cocci/20200407155005.rdyiu7xqss57rzhq@lenovo-laptop/
* You proposed a change for this SmPL script which contains programming mistakes.
* Would you like to achieve the restore of a SmPL code variant
from a published patch hunk instead?
* Will the software development attention grow also around the recurring topic
“Code duplications in SmPL disjunctions”?
Regards,
Markus
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-09 15:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-04 7:06 [PATCH] Coccinelle: zalloc-simple: Fix patch mode for dma_alloc_coherent() Markus Elfring
2020-04-07 16:03 ` Alex Dewar
2020-04-07 17:10 ` Markus Elfring
2020-04-09 11:44 ` Alex Dewar
2020-04-09 15:25 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).