From: "Jan Kundrát" <jan.kundrat@cesnet.cz>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Václav Kubernát" <kubernat@cesnet.cz>,
"Jean Delvare" <jdelvare@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/5] hwmon: (max31790) Fix and split pwm*_enable
Date: Wed, 19 May 2021 11:10:10 +0200 [thread overview]
Message-ID: <6f256c72-df4d-4f9a-ba5f-eabfd9f2365f@cesnet.cz> (raw)
In-Reply-To: <20210518211609.GA3532746@roeck-us.net>
> As it turns out, even the current code doesn't really work for fans 7..12.
> sr = get_tach_period(data->fan_dynamics[channel]);
> However, the data->fan_dynamics array has only 6 entries, not 12, so
> reading fan[7-12]_input will result in bad/random values.
Hi Guenter, I'm Vaclav's colleague. The chip can indeed reconfigure each
PWMOUT pin either as a PWM output or as a TACH input, but that's not
something that's correctly implemented in the current code, and we have no
use for that either (and we cannot test that on our PCBs easily, we do not
have the manufacturer's eval kit).
It looks to me that the original bug is that the current docs mention 12
fan inputs. Would you be OK with a patch series which fixes the docs so
that the chip always exports 6 TACH inputs and 6 PWMOUT channels?
Cheers,
Jan
next prev parent reply other threads:[~2021-05-19 9:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 21:16 [PATCH v5 2/5] hwmon: (max31790) Fix and split pwm*_enable Guenter Roeck
2021-05-19 9:10 ` Jan Kundrát [this message]
2021-05-19 13:55 ` Guenter Roeck
2021-05-20 11:29 ` Jan Kundrát
2021-05-20 11:50 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2021-05-12 1:30 [PATCH v5 1/5] hwmon: (max31790) Rework to use regmap Václav Kubernát
2021-05-12 1:30 ` [PATCH v5 2/5] hwmon: (max31790) Fix and split pwm*_enable Václav Kubernát
2021-05-12 1:32 ` Václav Kubernát
2021-05-18 14:59 ` Guenter Roeck
2021-05-19 23:11 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f256c72-df4d-4f9a-ba5f-eabfd9f2365f@cesnet.cz \
--to=jan.kundrat@cesnet.cz \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=kubernat@cesnet.cz \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).