* [PATCH] drm/amdgpu: add function declaration in amdgpu.h
@ 2016-09-18 14:29 Baoyou Xie
2016-09-19 10:03 ` Christian König
2016-09-19 13:53 ` Deucher, Alexander
0 siblings, 2 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-09-18 14:29 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, David1.Zhou,
Monk.Liu, Rex.Zhu, JinHuiEric.Huang, Flora.Cui
Cc: dri-devel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 2 warnings when building kernel with W=1:
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous prototype for 'init_cond_exec' [-Wmissing-prototypes]
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous prototype for 'patch_cond_exec' [-Wmissing-prototypes]
In fact, both functions are not declared in any files.
So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index 8e3d9b2..7b71cbe 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
@@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct fence **fence);
void amdgpu_fence_process(struct amdgpu_ring *ring);
int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
+unsigned int init_cond_exec(struct amdgpu_ring *ring);
+void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
/*
* BO.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: add function declaration in amdgpu.h
2016-09-18 14:29 [PATCH] drm/amdgpu: add function declaration in amdgpu.h Baoyou Xie
@ 2016-09-19 10:03 ` Christian König
2016-09-19 13:53 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2016-09-19 10:03 UTC (permalink / raw)
To: Baoyou Xie, Deucher, Alexander, airlied, Zhou, David(ChunMing),
Liu, Monk, Zhu, Rex, Huang, JinHuiEric, Cui, Flora
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
Am 18.09.2016 um 16:29 schrieb Baoyou Xie:
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous prototype for 'init_cond_exec' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous prototype for 'patch_cond_exec' [-Wmissing-prototypes]
>
> In fact, both functions are not declared in any files.
>
> So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
NAK, IIRC Alex posted a patch last week to remove those two.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 8e3d9b2..7b71cbe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring, struct fence **fence);
> void amdgpu_fence_process(struct amdgpu_ring *ring);
> int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
> unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
> +unsigned int init_cond_exec(struct amdgpu_ring *ring);
> +void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
>
> /*
> * BO.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: add function declaration in amdgpu.h
2016-09-18 14:29 [PATCH] drm/amdgpu: add function declaration in amdgpu.h Baoyou Xie
2016-09-19 10:03 ` Christian König
@ 2016-09-19 13:53 ` Deucher, Alexander
1 sibling, 0 replies; 3+ messages in thread
From: Deucher, Alexander @ 2016-09-19 13:53 UTC (permalink / raw)
To: 'Baoyou Xie',
Koenig, Christian, airlied, Zhou, David(ChunMing),
Liu, Monk, Zhu, Rex, Huang, JinHuiEric, Cui, Flora
Cc: dri-devel, linux-kernel, arnd, xie.baoyou
> -----Original Message-----
> From: Baoyou Xie [mailto:baoyou.xie@linaro.org]
> Sent: Sunday, September 18, 2016 10:29 AM
> To: Deucher, Alexander; Koenig, Christian; airlied@linux.ie; Zhou,
> David(ChunMing); Liu, Monk; Zhu, Rex; Huang, JinHuiEric; Cui, Flora
> Cc: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> arnd@arndb.de; baoyou.xie@linaro.org; xie.baoyou@zte.com.cn
> Subject: [PATCH] drm/amdgpu: add function declaration in amdgpu.h
>
> We get 2 warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:502:10: warning: no previous
> prototype for 'init_cond_exec' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c:514:6: warning: no previous
> prototype for 'patch_cond_exec' [-Wmissing-prototypes]
>
> In fact, both functions are not declared in any files.
>
> So this patch declares them in drivers/gpu/drm/amd/amdgpu/amdgpu.h.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
These functions were unused so they were already dropped.
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index 8e3d9b2..7b71cbe 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -396,6 +396,8 @@ int amdgpu_fence_emit(struct amdgpu_ring *ring,
> struct fence **fence);
> void amdgpu_fence_process(struct amdgpu_ring *ring);
> int amdgpu_fence_wait_empty(struct amdgpu_ring *ring);
> unsigned amdgpu_fence_count_emitted(struct amdgpu_ring *ring);
> +unsigned int init_cond_exec(struct amdgpu_ring *ring);
> +void patch_cond_exec(struct amdgpu_ring *ring, unsigned int offset);
>
> /*
> * BO.
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-19 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 14:29 [PATCH] drm/amdgpu: add function declaration in amdgpu.h Baoyou Xie
2016-09-19 10:03 ` Christian König
2016-09-19 13:53 ` Deucher, Alexander
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).