* [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description
@ 2022-11-17 7:15 Kamalesh Babulal
2022-11-17 13:15 ` Waiman Long
2022-11-17 15:03 ` Joel Savitz
0 siblings, 2 replies; 3+ messages in thread
From: Kamalesh Babulal @ 2022-11-17 7:15 UTC (permalink / raw)
To: Tejun Heo, Zefan Li, Waiman Long, Johannes Weiner
Cc: cgroups, linux-kernel, Tom Hromatka
Change the function argument in the description of cpuset_css_alloc()
from 'struct cgroup' -> 'struct cgroup_subsys_state'. The change to the
argument type was introduced by commit eb95419b023a ("cgroup: pass
around cgroup_subsys_state instead of cgroup in subsystem methods").
Also, add more information to its description.
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
---
v2: Reworded the description to be more accurate, as suggested
by Waiman Long
kernel/cgroup/cpuset.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index b474289c15b8..ce789e1b2a2f 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -3046,11 +3046,15 @@ static struct cftype dfl_files[] = {
};
-/*
- * cpuset_css_alloc - allocate a cpuset css
- * cgrp: control group that the new cpuset will be part of
+/**
+ * cpuset_css_alloc - Allocate a cpuset css
+ * @parent_css: Parent css of the control group that the new cpuset will be
+ * part of
+ * Return: cpuset css on success, -ENOMEM on failure.
+ *
+ * Allocate and initialize a new cpuset css, for non-NULL @parent_css, return
+ * top cpuset css otherwise.
*/
-
static struct cgroup_subsys_state *
cpuset_css_alloc(struct cgroup_subsys_state *parent_css)
{
--
2.34.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description
2022-11-17 7:15 [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description Kamalesh Babulal
@ 2022-11-17 13:15 ` Waiman Long
2022-11-17 15:03 ` Joel Savitz
1 sibling, 0 replies; 3+ messages in thread
From: Waiman Long @ 2022-11-17 13:15 UTC (permalink / raw)
To: Kamalesh Babulal, Tejun Heo, Zefan Li, Johannes Weiner
Cc: cgroups, linux-kernel, Tom Hromatka
On 11/17/22 02:15, Kamalesh Babulal wrote:
> Change the function argument in the description of cpuset_css_alloc()
> from 'struct cgroup' -> 'struct cgroup_subsys_state'. The change to the
> argument type was introduced by commit eb95419b023a ("cgroup: pass
> around cgroup_subsys_state instead of cgroup in subsystem methods").
> Also, add more information to its description.
>
> Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
> ---
> v2: Reworded the description to be more accurate, as suggested
> by Waiman Long
>
> kernel/cgroup/cpuset.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index b474289c15b8..ce789e1b2a2f 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3046,11 +3046,15 @@ static struct cftype dfl_files[] = {
> };
>
>
> -/*
> - * cpuset_css_alloc - allocate a cpuset css
> - * cgrp: control group that the new cpuset will be part of
> +/**
> + * cpuset_css_alloc - Allocate a cpuset css
> + * @parent_css: Parent css of the control group that the new cpuset will be
> + * part of
> + * Return: cpuset css on success, -ENOMEM on failure.
> + *
> + * Allocate and initialize a new cpuset css, for non-NULL @parent_css, return
> + * top cpuset css otherwise.
> */
> -
> static struct cgroup_subsys_state *
> cpuset_css_alloc(struct cgroup_subsys_state *parent_css)
> {
Acked-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description
2022-11-17 7:15 [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description Kamalesh Babulal
2022-11-17 13:15 ` Waiman Long
@ 2022-11-17 15:03 ` Joel Savitz
1 sibling, 0 replies; 3+ messages in thread
From: Joel Savitz @ 2022-11-17 15:03 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: Tejun Heo, Zefan Li, Waiman Long, Johannes Weiner, cgroups,
linux-kernel, Tom Hromatka
On Thu, Nov 17, 2022 at 3:18 AM Kamalesh Babulal
<kamalesh.babulal@oracle.com> wrote:
>
> Change the function argument in the description of cpuset_css_alloc()
> from 'struct cgroup' -> 'struct cgroup_subsys_state'. The change to the
> argument type was introduced by commit eb95419b023a ("cgroup: pass
> around cgroup_subsys_state instead of cgroup in subsystem methods").
> Also, add more information to its description.
>
> Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
> ---
> v2: Reworded the description to be more accurate, as suggested
> by Waiman Long
>
> kernel/cgroup/cpuset.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index b474289c15b8..ce789e1b2a2f 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -3046,11 +3046,15 @@ static struct cftype dfl_files[] = {
> };
>
>
> -/*
> - * cpuset_css_alloc - allocate a cpuset css
> - * cgrp: control group that the new cpuset will be part of
> +/**
> + * cpuset_css_alloc - Allocate a cpuset css
> + * @parent_css: Parent css of the control group that the new cpuset will be
> + * part of
> + * Return: cpuset css on success, -ENOMEM on failure.
> + *
> + * Allocate and initialize a new cpuset css, for non-NULL @parent_css, return
> + * top cpuset css otherwise.
> */
> -
> static struct cgroup_subsys_state *
> cpuset_css_alloc(struct cgroup_subsys_state *parent_css)
> {
> --
> 2.34.3
>
Acked-by: Joel Savitz <jsavitz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-17 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 7:15 [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description Kamalesh Babulal
2022-11-17 13:15 ` Waiman Long
2022-11-17 15:03 ` Joel Savitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).