From: Bart Van Assche <bvanassche@acm.org>
To: Eric Biggers <ebiggers@kernel.org>, linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs
Date: Thu, 9 Dec 2021 14:51:59 -0800 [thread overview]
Message-ID: <6ff4d074-7508-4f4c-de06-f36899668168@acm.org> (raw)
In-Reply-To: <20211208013534.136590-4-ebiggers@kernel.org>
On 12/7/21 5:35 PM, Eric Biggers wrote:
> +What: /sys/block/<disk>/queue/crypto/modes/<mode>
> +Date: December 2021
> +Contact: linux-block@vger.kernel.org
> +Description:
> + [RO] For each crypto mode (i.e., encryption/decryption
> + algorithm) the device supports with inline encryption, a file
> + will exist at this location. It will contain a hexadecimal
> + number that is a bitmask of the supported data unit sizes, in
> + bytes, for that crypto mode.
> +
> + Currently, the crypto modes that may be supported are:
> +
> + * AES-256-XTS
> + * AES-128-CBC-ESSIV
> + * Adiantum
> +
> + For example, if a device supports AES-256-XTS inline encryption
> + with data unit sizes of 512 and 4096 bytes, the file
> + /sys/block/<disk>/queue/crypto/modes/AES-256-XTS will exist and
> + will contain "0x1200".
So a bitmask is used to combine multiple values into a single number? Has it been
considered to report each value separately, e.g. 512\n4096\n instead of 0x1200\n?
I think the former approach is more friendly for shell scripts.
> +struct blk_crypto_attr {
> + struct attribute attr;
> + ssize_t (*show)(struct blk_crypto_profile *profile,
> + struct blk_crypto_attr *attr, char *page);
> +};
It is not clear to me why this structure has been introduced instead of using the
existing kobj_attribute structure?
> +static int __init blk_crypto_sysfs_init(void)
> +{
> + int i;
> +
> + BUILD_BUG_ON(BLK_ENCRYPTION_MODE_INVALID != 0);
> + for (i = 1; i < BLK_ENCRYPTION_MODE_MAX; i++) {
> + struct blk_crypto_attr *attr = &__blk_crypto_mode_attrs[i];
> +
> + attr->attr.name = blk_crypto_modes[i].name;
> + attr->attr.mode = 0444;
> + attr->show = blk_crypto_mode_show;
> + blk_crypto_mode_attrs[i - 1] = &attr->attr;
> + }
> + return 0;
> +}
> +subsys_initcall(blk_crypto_sysfs_init);
Would it be possible to remove the use of subsys_initcall() if the crypto attributes and
blk_crypto_modes[] would be defined in the same file?
Thanks,
Bart.
next prev parent reply other threads:[~2021-12-09 22:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 1:35 [PATCH v3 0/3] block: show crypto capabilities in sysfs Eric Biggers
2021-12-08 1:35 ` [PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-12-09 19:00 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-12-09 22:38 ` Bart Van Assche
2021-12-09 23:17 ` Eric Biggers
2021-12-09 23:26 ` Bart Van Assche
2021-12-08 1:35 ` [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-12-09 22:51 ` Bart Van Assche [this message]
2021-12-09 23:40 ` Eric Biggers
2021-12-10 0:02 ` Bart Van Assche
2021-12-10 0:12 ` Eric Biggers
2021-12-10 6:42 ` Greg Kroah-Hartman
2021-12-10 17:29 ` Bart Van Assche
2021-12-10 17:45 ` Eric Biggers
2021-12-11 10:50 ` Greg Kroah-Hartman
2021-12-14 5:04 ` Bart Van Assche
2021-12-14 7:23 ` Chaitanya Kulkarni
2021-12-14 7:29 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ff4d074-7508-4f4c-de06-f36899668168@acm.org \
--to=bvanassche@acm.org \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).