linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-mmc@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs
Date: Fri, 10 Dec 2021 09:29:41 -0800	[thread overview]
Message-ID: <cb29756b-8b21-5b4d-f107-b5573945d7ab@acm.org> (raw)
In-Reply-To: <YbL2uUqV0GWFOitE@kroah.com>

On 12/9/21 10:42 PM, Greg Kroah-Hartman wrote:
> A single hex value makes sense to me.

Hi Greg,

I'm not enthusiast about this approach because:
(a) A single hex value can be confused with a number. Reporting a bitfield in
     hex format is not sufficient to prevent confusion with a number.
(b) No other block layer sysfs attribute follows this encoding scheme.
(c) This encoding enforces the restriction that data unit sizes are a power of
     two. Is there anything fundamental in encryption that restricts data unit
     sizes to a power of two? I don't know the answer myself.

Thanks,

Bart.

  reply	other threads:[~2021-12-10 17:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08  1:35 [PATCH v3 0/3] block: show crypto capabilities in sysfs Eric Biggers
2021-12-08  1:35 ` [PATCH v3 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-12-09 19:00   ` Bart Van Assche
2021-12-08  1:35 ` [PATCH v3 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-12-09 22:38   ` Bart Van Assche
2021-12-09 23:17     ` Eric Biggers
2021-12-09 23:26       ` Bart Van Assche
2021-12-08  1:35 ` [PATCH v3 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-12-09 22:51   ` Bart Van Assche
2021-12-09 23:40     ` Eric Biggers
2021-12-10  0:02       ` Bart Van Assche
2021-12-10  0:12         ` Eric Biggers
2021-12-10  6:42       ` Greg Kroah-Hartman
2021-12-10 17:29         ` Bart Van Assche [this message]
2021-12-10 17:45           ` Eric Biggers
2021-12-11 10:50           ` Greg Kroah-Hartman
2021-12-14  5:04             ` Bart Van Assche
2021-12-14  7:23               ` Chaitanya Kulkarni
2021-12-14  7:29               ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb29756b-8b21-5b4d-f107-b5573945d7ab@acm.org \
    --to=bvanassche@acm.org \
    --cc=ebiggers@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).