From: Edward Cree <ecree@solarflare.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Shuah Khan <shuah@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Thomas Meyer <thomas@m3y3r.de>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>,
Networking <netdev@vger.kernel.org>
Subject: Re: selftests/bpf doesn't compile
Date: Fri, 15 Sep 2017 17:58:40 +0100 [thread overview]
Message-ID: <701006c0-f80a-6bd7-fb5e-5bca1dc33a31@solarflare.com> (raw)
In-Reply-To: <20170915160253.q3x5j7hfkxxh2g6w@ast-mbp>
On 15/09/17 17:02, Alexei Starovoitov wrote:
> On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote:
>> Is bpf test intended to be run in kselftest run? The clang dependency might
>> not be met on majority of the systems. Is this a hard dependency??
> It is a hard dependency and clang should be present on majority of the systems.
I think this is the wrong approach. Making kselftest hard-require clang doesn't
mean that the bpf tests will be run more often, it means that the rest of the
kselftests will be run less often. clang is quite big (when I tried to install
it on one of my test servers, I didn't have enough disk space & had to go on a
clear-out of unused packages), and most people aren't interested in the bpf
subsystem specifically; they would rather be able to skip those tests.
I feel that as long as they know they are skipping some tests (so e.g. they
won't consider it a sufficient test of a kselftest refactor), that's fine.
It's not even as though all of the bpf tests require clang; the (smaller) tests
written directly in raw eBPF instructions could still be run on such a system.
So I think we should attempt to run as much as possible but accept that clang
may not be available and have an option to skip some tests in that case.
-Ed
next prev parent reply other threads:[~2017-09-15 16:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 11:19 [PATCH] selftests/bpf: Make bpf_util work on uniprocessor systems Thomas Meyer
2017-09-08 23:01 ` Alexei Starovoitov
2017-09-08 23:05 ` Daniel Borkmann
2017-09-14 15:01 ` Shuah Khan
2017-09-14 15:33 ` selftests/bpf doesn't compile Shuah Khan
2017-09-15 16:02 ` Alexei Starovoitov
2017-09-15 16:58 ` Edward Cree [this message]
2017-09-15 18:07 ` Alexei Starovoitov
2017-09-15 18:23 ` Daniel Borkmann
2017-09-15 18:48 ` Daniel Borkmann
2017-09-15 22:41 ` Shuah Khan
2017-09-18 13:31 ` Daniel Borkmann
2017-09-15 17:00 ` Shuah Khan
2017-09-15 17:44 ` Shuah Khan
2017-09-15 18:14 ` Alexei Starovoitov
2017-09-15 22:32 ` Shuah Khan
2019-01-04 17:16 ` Geert Uytterhoeven
2019-01-04 19:07 ` shuah
2017-09-19 14:45 ` [PATCH] selftests/bpf: Make bpf_util work on uniprocessor systems Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=701006c0-f80a-6bd7-fb5e-5bca1dc33a31@solarflare.com \
--to=ecree@solarflare.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=thomas@m3y3r.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).