* [PATCH] omapfb: rename omap2 module to omap2fb.ko
@ 2018-07-06 12:35 Arnd Bergmann
2018-07-09 7:02 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-07-06 12:35 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: Mauro Carvalho Chehab, Arnd Bergmann, linux-omap, linux-fbdev,
dri-devel, linux-kernel
In a kernel configuration with both CONFIG_FB_OMAP=m and CONFIG_FB_OMAP2=m,
Kbuild fails to point out that we have two modules with the same name (omapfb.ko),
but instead fails with a cryptic error message like:
ERROR: "omapfb_register_panel" [drivers/video/fbdev/omap/lcd_osk.ko] undefined!
This can now happen when building a randconfig kernel with CONFIG_ARCH_OMAP1,
as the omap1 fbdev driver depends on that, whiel the omap2 fbdev driver can
now be built anywhere with CONFIG_COMPILE_TEST.
The solution is to rename one of the two modules, so for consistency with
the directory naming I decided to rename the omap2 version to omap2fb.ko.
Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/video/fbdev/omap2/omapfb/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/Makefile b/drivers/video/fbdev/omap2/omapfb/Makefile
index 602edfed09df..f54c3f56b641 100644
--- a/drivers/video/fbdev/omap2/omapfb/Makefile
+++ b/drivers/video/fbdev/omap2/omapfb/Makefile
@@ -2,5 +2,5 @@
obj-$(CONFIG_OMAP2_VRFB) += vrfb.o
obj-y += dss/
obj-y += displays/
-obj-$(CONFIG_FB_OMAP2) += omapfb.o
-omapfb-y := omapfb-main.o omapfb-sysfs.o omapfb-ioctl.o
+obj-$(CONFIG_FB_OMAP2) += omap2fb.o
+omap2fb-y := omapfb-main.o omapfb-sysfs.o omapfb-ioctl.o
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] omapfb: rename omap2 module to omap2fb.ko
2018-07-06 12:35 [PATCH] omapfb: rename omap2 module to omap2fb.ko Arnd Bergmann
@ 2018-07-09 7:02 ` Tony Lindgren
2018-07-24 15:44 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2018-07-09 7:02 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Bartlomiej Zolnierkiewicz, Mauro Carvalho Chehab, linux-omap,
linux-fbdev, dri-devel, linux-kernel
* Arnd Bergmann <arnd@arndb.de> [180706 12:39]:
> In a kernel configuration with both CONFIG_FB_OMAP=m and CONFIG_FB_OMAP2=m,
> Kbuild fails to point out that we have two modules with the same name (omapfb.ko),
> but instead fails with a cryptic error message like:
>
> ERROR: "omapfb_register_panel" [drivers/video/fbdev/omap/lcd_osk.ko] undefined!
>
> This can now happen when building a randconfig kernel with CONFIG_ARCH_OMAP1,
> as the omap1 fbdev driver depends on that, whiel the omap2 fbdev driver can
> now be built anywhere with CONFIG_COMPILE_TEST.
>
> The solution is to rename one of the two modules, so for consistency with
> the directory naming I decided to rename the omap2 version to omap2fb.ko.
Sounds good to me:
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] omapfb: rename omap2 module to omap2fb.ko
2018-07-09 7:02 ` Tony Lindgren
@ 2018-07-24 15:44 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-07-24 15:44 UTC (permalink / raw)
To: Tony Lindgren, Arnd Bergmann
Cc: Mauro Carvalho Chehab, linux-omap, linux-fbdev, dri-devel, linux-kernel
On Monday, July 09, 2018 12:02:16 AM Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [180706 12:39]:
> > In a kernel configuration with both CONFIG_FB_OMAP=m and CONFIG_FB_OMAP2=m,
> > Kbuild fails to point out that we have two modules with the same name (omapfb.ko),
> > but instead fails with a cryptic error message like:
> >
> > ERROR: "omapfb_register_panel" [drivers/video/fbdev/omap/lcd_osk.ko] undefined!
> >
> > This can now happen when building a randconfig kernel with CONFIG_ARCH_OMAP1,
> > as the omap1 fbdev driver depends on that, whiel the omap2 fbdev driver can
> > now be built anywhere with CONFIG_COMPILE_TEST.
> >
> > The solution is to rename one of the two modules, so for consistency with
> > the directory naming I decided to rename the omap2 version to omap2fb.ko.
>
> Sounds good to me:
>
> Acked-by: Tony Lindgren <tony@atomide.com>
Patch queued for 4.19, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-24 15:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 12:35 [PATCH] omapfb: rename omap2 module to omap2fb.ko Arnd Bergmann
2018-07-09 7:02 ` Tony Lindgren
2018-07-24 15:44 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).