From: David Rientjes <rientjes@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@kernel.org>, Alex Shi <alexs@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Alexander Duyck <alexanderduyck@fb.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch] mm, debug: allow suppressing panic on CONFIG_DEBUG_VM checks
Date: Tue, 23 May 2023 17:54:43 -0700 (PDT) [thread overview]
Message-ID: <703a3995-75cf-b575-deff-fe2b78bd1354@google.com> (raw)
In-Reply-To: <ZGw2eJxxQl4DrfWi@casper.infradead.org>
On Tue, 23 May 2023, Matthew Wilcox wrote:
> On Mon, May 22, 2023 at 11:39:27AM -0700, David Rientjes wrote:
> > I think VM_BUG_ON*() and friends are used to crash the kernel for
> > debugging so that we get a crash dump and because some variants don't
> > exist for VM_WARN_ON(). There's no VM_WARN_ON_PAGE(), for example, unless
> > implicitly converted with this patch.
>
> It could be added, but there's already a VM_WARN_ON_FOLIO() and
> VM_WARN_ON_ONCE_PAGE(), so hopefully we just keep converting code
> to folios until nobody notices that we might need such a thing.
>
Yeah, the lack of VM_WARN variants for VM_BUG_ON_MM or VM_BUG_ON_VMA are
probably better examples. But it looks like we're converging toward
eliminating VM_BUG_ON* variants entirely and relying on
kernel.panic_on_warn to do the BUG_ON() behavior if we want to opt into
that. So this will be a useful cleanup.
prev parent reply other threads:[~2023-05-24 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 23:07 [patch] mm, debug: allow suppressing panic on CONFIG_DEBUG_VM checks David Rientjes
2023-05-22 9:42 ` David Hildenbrand
2023-05-22 18:39 ` David Rientjes
2023-05-22 18:48 ` Linus Torvalds
2023-05-23 0:51 ` David Rientjes
2023-05-23 1:47 ` Linus Torvalds
2023-05-24 0:53 ` David Rientjes
2023-05-24 8:42 ` David Hildenbrand
2023-05-24 11:44 ` Justin Forbes
2023-05-23 7:46 ` Michal Hocko
2023-05-23 3:43 ` Matthew Wilcox
2023-05-24 0:54 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=703a3995-75cf-b575-deff-fe2b78bd1354@google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=alexanderduyck@fb.com \
--cc=alexs@kernel.org \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).