* [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
@ 2024-01-30 7:35 Stefan Eichenberger
2024-01-30 8:50 ` Francesco Dolcini
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Stefan Eichenberger @ 2024-01-30 7:35 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, piyush.mehta,
michal.simek
Cc: francesco.dolcini, linux-usb, devicetree, linux-kernel,
Stefan Eichenberger
From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
The peer-hub is used to model the relationship between the USB 2 and USB
3 hub. However, it is possible to only connect USB 2 without having
USB 3. Therefore, the peer-hub property should not be marked as required.
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
---
Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 --
1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
index 6d4cfd943f58..14dbb70b08fa 100644
--- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
+++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
@@ -71,8 +71,6 @@ allOf:
i2c-bus: false
else:
$ref: /schemas/usb/usb-device.yaml
- required:
- - peer-hub
additionalProperties: false
--
2.40.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
2024-01-30 7:35 [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement Stefan Eichenberger
@ 2024-01-30 8:50 ` Francesco Dolcini
2024-01-30 11:01 ` Michal Simek
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Francesco Dolcini @ 2024-01-30 8:50 UTC (permalink / raw)
To: Stefan Eichenberger
Cc: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, piyush.mehta,
michal.simek, francesco.dolcini, linux-usb, devicetree,
linux-kernel, Stefan Eichenberger
On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.
This was noticed while adding this HUB in the DTS on a board in which
USB3 is not supported. To some extent this is fix.
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Francesco
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
2024-01-30 7:35 [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement Stefan Eichenberger
2024-01-30 8:50 ` Francesco Dolcini
@ 2024-01-30 11:01 ` Michal Simek
2024-01-30 17:58 ` Conor Dooley
2024-02-09 8:17 ` Stefan Eichenberger
3 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2024-01-30 11:01 UTC (permalink / raw)
To: Stefan Eichenberger, gregkh, robh+dt, krzysztof.kozlowski+dt,
conor+dt, piyush.mehta
Cc: francesco.dolcini, linux-usb, devicetree, linux-kernel,
Stefan Eichenberger
On 1/30/24 08:35, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.
>
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> ---
> Documentation/devicetree/bindings/usb/microchip,usb5744.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> index 6d4cfd943f58..14dbb70b08fa 100644
> --- a/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> +++ b/Documentation/devicetree/bindings/usb/microchip,usb5744.yaml
> @@ -71,8 +71,6 @@ allOf:
> i2c-bus: false
> else:
> $ref: /schemas/usb/usb-device.yaml
> - required:
> - - peer-hub
>
> additionalProperties: false
>
Looks good.
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
2024-01-30 7:35 [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement Stefan Eichenberger
2024-01-30 8:50 ` Francesco Dolcini
2024-01-30 11:01 ` Michal Simek
@ 2024-01-30 17:58 ` Conor Dooley
2024-02-09 8:17 ` Stefan Eichenberger
3 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2024-01-30 17:58 UTC (permalink / raw)
To: Stefan Eichenberger
Cc: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, piyush.mehta,
michal.simek, francesco.dolcini, linux-usb, devicetree,
linux-kernel, Stefan Eichenberger
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.
>
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
2024-01-30 7:35 [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement Stefan Eichenberger
` (2 preceding siblings ...)
2024-01-30 17:58 ` Conor Dooley
@ 2024-02-09 8:17 ` Stefan Eichenberger
2024-02-09 9:40 ` Greg KH
3 siblings, 1 reply; 6+ messages in thread
From: Stefan Eichenberger @ 2024-02-09 8:17 UTC (permalink / raw)
To: gregkh, robh+dt, krzysztof.kozlowski+dt, conor+dt, piyush.mehta,
michal.simek
Cc: francesco.dolcini, linux-usb, devicetree, linux-kernel,
Stefan Eichenberger
Hi Greg,
On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> The peer-hub is used to model the relationship between the USB 2 and USB
> 3 hub. However, it is possible to only connect USB 2 without having
> USB 3. Therefore, the peer-hub property should not be marked as required.
I just wanted to ask if everything is okay with the patch and if its
fine to apply it or if it needs some updates?
Regards,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement
2024-02-09 8:17 ` Stefan Eichenberger
@ 2024-02-09 9:40 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2024-02-09 9:40 UTC (permalink / raw)
To: Stefan Eichenberger
Cc: robh+dt, krzysztof.kozlowski+dt, conor+dt, piyush.mehta,
michal.simek, francesco.dolcini, linux-usb, devicetree,
linux-kernel, Stefan Eichenberger
On Fri, Feb 09, 2024 at 09:17:02AM +0100, Stefan Eichenberger wrote:
> Hi Greg,
>
> On Tue, Jan 30, 2024 at 08:35:05AM +0100, Stefan Eichenberger wrote:
> > From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> >
> > The peer-hub is used to model the relationship between the USB 2 and USB
> > 3 hub. However, it is possible to only connect USB 2 without having
> > USB 3. Therefore, the peer-hub property should not be marked as required.
>
> I just wanted to ask if everything is okay with the patch and if its
> fine to apply it or if it needs some updates?
That was only 10 days ago, please give us a chance to catch up on
reviews.
In the meantime, while waiting, please review other changes on the
lists, that way yours moves higher up in the queue. Any reason why you
can't do that now?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-09 9:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-30 7:35 [PATCH] dt-bindings: usb: microchip,usb5744: Remove peer-hub as requirement Stefan Eichenberger
2024-01-30 8:50 ` Francesco Dolcini
2024-01-30 11:01 ` Michal Simek
2024-01-30 17:58 ` Conor Dooley
2024-02-09 8:17 ` Stefan Eichenberger
2024-02-09 9:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).