[PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

This series converts QCOM watchdog timer bindings to YAML. Also
it adds the missing SoC-specific compatible for QCS404, SC7180,
SDM845 and SM8150 SoCs.

v1: https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
v2: https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/

Changes since v2:
 * Add missing compatibles to enum.

Changes since v1:
 As per Rob's suggestion:
  * Replaced oneOf+const with enum.
  * Removed timeout-sec and included watchdog.yaml.
  * Removed repeated use of const:qcom,kpss-wdt and made use of enum.

Sai Prakash Ranjan (2):
  dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
  dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
    SM8150

 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
 .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

[PATCHv3 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

Convert QCOM watchdog timer bindings to DT schema format using
json-schema.

Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
 .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ------------
 .../bindings/watchdog/qcom-wdt.yaml           | 44 +++++++++++++++++++
 2 files changed, 44 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
deleted file mode 100644
index 41aeaa2ff0f8..000000000000
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Qualcomm Krait Processor Sub-system (KPSS) Watchdog
----------------------------------------------------
-
-Required properties :
-- compatible : shall contain only one of the following:
-
-			"qcom,kpss-wdt-msm8960"
-			"qcom,kpss-wdt-apq8064"
-			"qcom,kpss-wdt-ipq8064"
-			"qcom,kpss-wdt-ipq4019"
-			"qcom,kpss-timer"
-			"qcom,scss-timer"
-			"qcom,kpss-wdt"
-
-- reg : shall contain base register location and length
-- clocks : shall contain the input clock
-
-Optional properties :
-- timeout-sec : shall contain the default watchdog timeout in seconds,
-                if unset, the default timeout is 30 seconds
-
-Example:
-	watchdog@208a038 {
-		compatible = "qcom,kpss-wdt-ipq8064";
-		reg = <0x0208a038 0x40>;
-		clocks = <&sleep_clk>;
-		timeout-sec = <10>;
-	};
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
new file mode 100644
index 000000000000..5448cc537a03
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -0,0 +1,44 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
+
+maintainers:
+  - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
+
+allOf:
+  - $ref: watchdog.yaml#
+
+properties:
+  compatible:
+    enum:
+      - qcom,kpss-timer
+      - qcom,kpss-wdt
+      - qcom,kpss-wdt-apq8064
+      - qcom,kpss-wdt-ipq4019
+      - qcom,kpss-wdt-ipq8064
+      - qcom,kpss-wdt-msm8960
+      - qcom,scss-timer
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+examples:
+  - |
+    watchdog@208a038 {
+      compatible = "qcom,kpss-wdt-ipq8064";
+      reg = <0x0208a038 0x40>;
+      clocks = <&sleep_clk>;
+      timeout-sec = <10>;
+    };
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

[PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150

[Sai Prakash Ranjan]

Add missing compatible for watchdog timer on QCS404,
SC7180, SDM845 and SM8150 SoCs.

Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
---
 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 5448cc537a03..0709ddf0b6a5 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -15,6 +15,10 @@ allOf:
 properties:
   compatible:
     enum:
+      - qcom,apss-wdt-qcs404
+      - qcom,apss-wdt-sc7180
+      - qcom,apss-wdt-sdm845
+      - qcom,apss-wdt-sm8150
       - qcom,kpss-timer
       - qcom,kpss-wdt
       - qcom,kpss-wdt-apq8064
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCHv3 2/2] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150

[Rob Herring]

On Wed, 12 Feb 2020 03:54:30 +0530, Sai Prakash Ranjan wrote:
> Add missing compatible for watchdog timer on QCS404,
> SC7180, SDM845 and SM8150 SoCs.
> 
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

Hi Bjorn,

On 2020-02-12 03:54, Sai Prakash Ranjan wrote:
> This series converts QCOM watchdog timer bindings to YAML. Also
> it adds the missing SoC-specific compatible for QCS404, SC7180,
> SDM845 and SM8150 SoCs.
> 
> v1:
> https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
> v2:
> https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/
> 
> Changes since v2:
>  * Add missing compatibles to enum.
> 
> Changes since v1:
>  As per Rob's suggestion:
>   * Replaced oneOf+const with enum.
>   * Removed timeout-sec and included watchdog.yaml.
>   * Removed repeated use of const:qcom,kpss-wdt and made use of enum.
> 
> Sai Prakash Ranjan (2):
>   dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
>   dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
>     SM8150
> 
>  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
>  .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
>  2 files changed, 48 insertions(+), 28 deletions(-)
>  delete mode 100644 
> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>  create mode 100644 
> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml


Gentle ping!

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Bjorn Andersson]

On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote:

> Hi Bjorn,
> 

Hi Sai,

> On 2020-02-12 03:54, Sai Prakash Ranjan wrote:
> > This series converts QCOM watchdog timer bindings to YAML. Also
> > it adds the missing SoC-specific compatible for QCS404, SC7180,
> > SDM845 and SM8150 SoCs.
> > 
> > v1:
> > https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
> > v2:
> > https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/
> > 
> > Changes since v2:
> >  * Add missing compatibles to enum.
> > 
> > Changes since v1:
> >  As per Rob's suggestion:
> >   * Replaced oneOf+const with enum.
> >   * Removed timeout-sec and included watchdog.yaml.
> >   * Removed repeated use of const:qcom,kpss-wdt and made use of enum.
> > 
> > Sai Prakash Ranjan (2):
> >   dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
> >   dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
> >     SM8150
> > 
> >  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
> >  .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
> >  2 files changed, 48 insertions(+), 28 deletions(-)
> >  delete mode 100644
> > Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> >  create mode 100644
> > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> 
> 
> Gentle ping!
> 

This should better go through the watchdog tree, so I believe Guenter
would be the one to pick this up.

Regards,
Bjorn

> Thanks,
> Sai
> 
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

On 2020-06-21 13:03, Bjorn Andersson wrote:
> On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote:
> 
>> Hi Bjorn,
>> 
> 
> Hi Sai,
> 
>> On 2020-02-12 03:54, Sai Prakash Ranjan wrote:
>> > This series converts QCOM watchdog timer bindings to YAML. Also
>> > it adds the missing SoC-specific compatible for QCS404, SC7180,
>> > SDM845 and SM8150 SoCs.
>> >
>> > v1:
>> > https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
>> > v2:
>> > https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/
>> >
>> > Changes since v2:
>> >  * Add missing compatibles to enum.
>> >
>> > Changes since v1:
>> >  As per Rob's suggestion:
>> >   * Replaced oneOf+const with enum.
>> >   * Removed timeout-sec and included watchdog.yaml.
>> >   * Removed repeated use of const:qcom,kpss-wdt and made use of enum.
>> >
>> > Sai Prakash Ranjan (2):
>> >   dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
>> >   dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
>> >     SM8150
>> >
>> >  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
>> >  .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
>> >  2 files changed, 48 insertions(+), 28 deletions(-)
>> >  delete mode 100644
>> > Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> >  create mode 100644
>> > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> 
>> 
>> Gentle ping!
>> 
> 
> This should better go through the watchdog tree, so I believe Guenter
> would be the one to pick this up.
> 

Ah right, then a gentle ping for Guenter.

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Guenter Roeck]

On Mon, Jun 22, 2020 at 11:50:52AM +0530, Sai Prakash Ranjan wrote:
> On 2020-06-21 13:03, Bjorn Andersson wrote:
> > On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote:
> > 
> > > Hi Bjorn,
> > > 
> > 
> > Hi Sai,
> > 
> > > On 2020-02-12 03:54, Sai Prakash Ranjan wrote:
> > > > This series converts QCOM watchdog timer bindings to YAML. Also
> > > > it adds the missing SoC-specific compatible for QCS404, SC7180,
> > > > SDM845 and SM8150 SoCs.
> > > >
> > > > v1:
> > > > https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
> > > > v2:
> > > > https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/
> > > >
> > > > Changes since v2:
> > > >  * Add missing compatibles to enum.
> > > >
> > > > Changes since v1:
> > > >  As per Rob's suggestion:
> > > >   * Replaced oneOf+const with enum.
> > > >   * Removed timeout-sec and included watchdog.yaml.
> > > >   * Removed repeated use of const:qcom,kpss-wdt and made use of enum.
> > > >
> > > > Sai Prakash Ranjan (2):
> > > >   dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
> > > >   dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
> > > >     SM8150
> > > >
> > > >  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
> > > >  .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
> > > >  2 files changed, 48 insertions(+), 28 deletions(-)
> > > >  delete mode 100644
> > > > Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> > > >  create mode 100644
> > > > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> > > 
> > > 
> > > Gentle ping!
> > > 
> > 
> > This should better go through the watchdog tree, so I believe Guenter
> > would be the one to pick this up.
> > 
> 
> Ah right, then a gentle ping for Guenter.
> 
I don't think the watchdog mailing list has been copied on this series,
meaning I don't have a copy that I could apply if I wanted to. I also see
no evidence for a Reviewed-by: tag from Rob or any other DT maintainer.

Guenter

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

On 2020-06-25 21:30, Guenter Roeck wrote:
> On Mon, Jun 22, 2020 at 11:50:52AM +0530, Sai Prakash Ranjan wrote:
>> On 2020-06-21 13:03, Bjorn Andersson wrote:
>> > On Tue 16 Jun 23:56 PDT 2020, Sai Prakash Ranjan wrote:
>> >
>> > > Hi Bjorn,
>> > >
>> >
>> > Hi Sai,
>> >
>> > > On 2020-02-12 03:54, Sai Prakash Ranjan wrote:
>> > > > This series converts QCOM watchdog timer bindings to YAML. Also
>> > > > it adds the missing SoC-specific compatible for QCS404, SC7180,
>> > > > SDM845 and SM8150 SoCs.
>> > > >
>> > > > v1:
>> > > > https://lore.kernel.org/lkml/cover.1576211720.git.saiprakash.ranjan@codeaurora.org/
>> > > > v2:
>> > > > https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/
>> > > >
>> > > > Changes since v2:
>> > > >  * Add missing compatibles to enum.
>> > > >
>> > > > Changes since v1:
>> > > >  As per Rob's suggestion:
>> > > >   * Replaced oneOf+const with enum.
>> > > >   * Removed timeout-sec and included watchdog.yaml.
>> > > >   * Removed repeated use of const:qcom,kpss-wdt and made use of enum.
>> > > >
>> > > > Sai Prakash Ranjan (2):
>> > > >   dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
>> > > >   dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
>> > > >     SM8150
>> > > >
>> > > >  .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
>> > > >  .../bindings/watchdog/qcom-wdt.yaml           | 48 +++++++++++++++++++
>> > > >  2 files changed, 48 insertions(+), 28 deletions(-)
>> > > >  delete mode 100644
>> > > > Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> > > >  create mode 100644
>> > > > Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> > >
>> > >
>> > > Gentle ping!
>> > >
>> >
>> > This should better go through the watchdog tree, so I believe Guenter
>> > would be the one to pick this up.
>> >
>> 
>> Ah right, then a gentle ping for Guenter.
>> 
> I don't think the watchdog mailing list has been copied on this series,
> meaning I don't have a copy that I could apply if I wanted to.

I kept you in CC for all the revisions but missed adding watchdog list.
Will resend with the appropriate lists added.

> I also see
> no evidence for a Reviewed-by: tag from Rob or any other DT maintainer.
> 

Not sure why you think I would add reviewed-by tag from Rob without him 
giving one.
But here's the evidence - 
https://lore.kernel.org/lkml/cover.1580570160.git.saiprakash.ranjan@codeaurora.org/
This link is also given v3 cover letter.

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Guenter Roeck]

On Fri, Jun 26, 2020 at 12:52:31AM +0530, Sai Prakash Ranjan wrote:
> > > 
> > I don't think the watchdog mailing list has been copied on this series,
> > meaning I don't have a copy that I could apply if I wanted to.
> 
> I kept you in CC for all the revisions but missed adding watchdog list.
> Will resend with the appropriate lists added.
> 

I use patchwork to track patches, tags, and my responses. No patchwork,
no patch, no tags, and no tracking.

> > I also see
> > no evidence for a Reviewed-by: tag from Rob or any other DT maintainer.
> > 
> 
> Not sure why you think I would add reviewed-by tag from Rob without him
> giving one.

Same response as above.

Guenter

Re: [PATCHv3 0/2] Convert QCOM watchdog timer bindings to YAML

[Sai Prakash Ranjan]

On 2020-06-26 02:48, Guenter Roeck wrote:
> On Fri, Jun 26, 2020 at 12:52:31AM +0530, Sai Prakash Ranjan wrote:
>> > >
>> > I don't think the watchdog mailing list has been copied on this series,
>> > meaning I don't have a copy that I could apply if I wanted to.
>> 
>> I kept you in CC for all the revisions but missed adding watchdog 
>> list.
>> Will resend with the appropriate lists added.
>> 
> 
> I use patchwork to track patches, tags, and my responses. No patchwork,
> no patch, no tags, and no tracking.
> 

Now resent with watchdog list added - 
https://lore.kernel.org/patchwork/cover/1263944/

Thanks,
Sai

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member
of Code Aurora Forum, hosted by The Linux Foundation