From: Neil Armstrong <narmstrong@baylibre.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: a.hajda@samsung.com, paul@crapouillou.net,
robert.foss@linaro.org, devicetree@vger.kernel.org,
jonas@kwiboo.se, jernej.skrabec@siol.net,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Phong LE <ple@baylibre.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings
Date: Wed, 14 Apr 2021 10:14:36 +0200 [thread overview]
Message-ID: <7111ccdf-ff64-f959-a652-623fa89ffe87@baylibre.com> (raw)
In-Reply-To: <YHXA0KFylvC7FDbK@pendragon.ideasonboard.com>
On 13/04/2021 18:03, Laurent Pinchart wrote:
> Hi Neil,
>
> Thank you for the patch.
>
> On Mon, Apr 12, 2021 at 05:46:46PM +0200, Neil Armstrong wrote:
>> From: Phong LE <ple@baylibre.com>
>>
>> Add the ITE bridge HDMI it66121 bindings.
>>
>> Signed-off-by: Phong LE <ple@baylibre.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> .../bindings/display/bridge/ite,it66121.yaml | 123 ++++++++++++++++++
>> 1 file changed, 123 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml
>> new file mode 100644
>> index 000000000000..61ed6dc7740b
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml
>> @@ -0,0 +1,123 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/ite,it66121.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ITE it66121 HDMI bridge Device Tree Bindings
>> +
>> +maintainers:
>> + - Phong LE <ple@baylibre.com>
>> + - Neil Armstrong <narmstrong@baylibre.com>
>> +
>> +description: |
>> + The IT66121 is a high-performance and low-power single channel HDMI
>> + transmitter, fully compliant with HDMI 1.3a, HDCP 1.2 and backward compatible
>> + to DVI 1.0 specifications.
>> +
>> +properties:
>> + compatible:
>> + const: ite,it66121
>> +
>> + reg:
>> + maxItems: 1
>> + description: base I2C address of the device
>
> You can drop the description.
Done
>
>> +
>> + reset-gpios:
>> + maxItems: 1
>> + description: GPIO connected to active low reset
>> +
>> + vrf12-supply:
>> + description: Regulator for 1.2V analog core power.
>> +
>> + vcn33-supply:
>> + description: Regulator for 3.3V digital core power.
>> +
>> + vcn18-supply:
>> + description: Regulator for 1.8V IO core power.
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + ports:
>> + $ref: /schemas/graph.yaml#/properties/ports
>> +
>> + properties:
>> + port@0:
>> + $ref: /schemas/graph.yaml#/$defs/port-base
>> + unevaluatedProperties: false
>> + description: DPI input port.
>> +
>> + properties:
>> + endpoint:
>> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
>> + unevaluatedProperties: false
>> +
>> + properties:
>> + bus-width:
>> + description:
>> + Endpoint bus width.
>> + enum:
>> + - 12 # 12 data lines connected and dual-edge mode
>> + - 24 # 24 data lines connected and single-edge mode
>> + default: 24
>> +
>> + port@1:
>> + $ref: /schemas/graph.yaml#/properties/port
>> + description: HDMI Connector port.
>> +
>> + required:
>> + - port@0
>> + - port@1
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reset-gpios
>> + - vrf12-supply
>> + - vcn33-supply
>> + - vcn18-supply
>> + - interrupts
>> + - ports
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + i2c {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>
> It's customary to indent DT examples with 4 spaces.
Done
>
>> +
>> + it66121hdmitx: it66121hdmitx@4c {
>> + compatible = "ite,it66121";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&ite_pins_default>;
>> + vcn33-supply = <&mt6358_vcn33_wifi_reg>;
>> + vcn18-supply = <&mt6358_vcn18_reg>;
>> + vrf12-supply = <&mt6358_vrf12_reg>;
>> + reset-gpios = <&pio 160 1 /* GPIO_ACTIVE_LOW */>;
>
> You can #include the necessary headers at the top of the example, and
> use GPIO_ACTIVE_LOW and IRQ_TYPE_LEVEL_LOW to replace the numerical
> values.
Done
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks,
Neil
>
>> + interrupt-parent = <&pio>;
>> + interrupts = <4 8 /* IRQ_TYPE_LEVEL_LOW */>;
>> + reg = <0x4c>;
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + it66121_in: endpoint {
>> + bus-width = <12>;
>> + remote-endpoint = <&display_out>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + hdmi_conn_out: endpoint {
>> + remote-endpoint = <&hdmi_conn_in>;
>> + };
>> + };
>> + };
>> + };
>> + };
>
next prev parent reply other threads:[~2021-04-14 8:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 15:46 [PATCH v3 0/3] drm/bridge: Add it66121 driver Neil Armstrong
2021-04-12 15:46 ` [PATCH v3 1/3] dt-bindings: display: bridge: add it66121 bindings Neil Armstrong
2021-04-13 15:11 ` Rob Herring
2021-04-13 16:03 ` Laurent Pinchart
2021-04-14 8:14 ` Neil Armstrong [this message]
2021-04-13 18:09 ` Paul Cercueil
2021-04-13 20:17 ` Laurent Pinchart
2021-04-12 15:46 ` [PATCH v3 2/3] drm: bridge: add it66121 driver Neil Armstrong
2021-04-13 20:21 ` Robert Foss
2021-04-14 6:13 ` Neil Armstrong
2021-04-14 8:06 ` Robert Foss
2021-04-14 8:08 ` Neil Armstrong
2021-04-14 8:16 ` Laurent Pinchart
2021-04-14 15:37 ` Neil Armstrong
2021-04-13 20:56 ` Paul Cercueil
2021-04-14 6:17 ` Neil Armstrong
2021-04-14 8:15 ` Paul Cercueil
2021-04-14 17:35 ` Paul Cercueil
2021-04-15 8:54 ` Neil Armstrong
2021-04-12 15:46 ` [PATCH v3 3/3] MAINTAINERS: add it66121 HDMI bridge driver entry Neil Armstrong
2021-04-12 15:47 ` Neil Armstrong
2021-04-13 17:53 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7111ccdf-ff64-f959-a652-623fa89ffe87@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=ple@baylibre.com \
--cc=robert.foss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).