Re: [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller

From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Sean Paul <sean@poorly.run>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Mark Yacoub <markyacoub@chromium.org>,
	quic_khsieh@quicinc.com, linux-arm-msm@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, robdclark@gmail.com,
	quic_abhinavk@quicinc.com, airlied@gmail.com, daniel@ffwll.ch,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	agross@kernel.org, andersson@kernel.org,
	konrad.dybcio@somainline.org, jani.nikula@linux.intel.com,
	joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com,
	tvrtko.ursulin@linux.intel.com, tzimmermann@suse.de,
	ville.syrjala@linux.intel.com, stanislav.lisovskiy@intel.com,
	matthew.d.roper@intel.com, imre.deak@intel.com,
	lucas.demarchi@intel.com, manasi.d.navare@intel.com,
	swati2.sharma@intel.com, bhanuprakash.modem@intel.com,
	javierm@redhat.com, jose.souza@intel.com, lyude@redhat.com,
	hbh25y@gmail.com, arun.r.murthy@intel.com,
	ashutosh.dixit@intel.com, ankit.k.nautiyal@intel.com,
	maxime@cerno.tech, swboyd@chromium.org,
	christophe.jaillet@wanadoo.fr, quic_sbillaka@quicinc.com,
	johan+linaro@kernel.org, dianders@chromium.org, marex@denx.de,
	quic_jesszhan@quicinc.com, bjorn.andersson@linaro.org,
	abhinavk@codeaurora.org, seanpaul@chromium.org
Subject: Re: [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller
Date: Sat, 21 Jan 2023 12:16:21 +0200	[thread overview]
Message-ID: <7116584e-f5a1-f404-8cfc-d1d159a4d647@linaro.org> (raw)
In-Reply-To: <Y8q5UfpIg0+qnAuG@art_vandelay>

On 20/01/2023 17:54, Sean Paul wrote:
> On Thu, Jan 19, 2023 at 11:35:32AM +0100, Krzysztof Kozlowski wrote:
>> On 18/01/2023 20:30, Mark Yacoub wrote:
>>> From: Sean Paul <seanpaul@chromium.org>
>>>
>>> This patch adds the register ranges required for HDCP key injection and
>>
>> Do not use "This commit/patch".
>> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>>
>> This applies to all your patches. Fix it everywhere.
> 
> My goodness, this is peak bikeshedding. Surely we have better things to do with
> our time?

While I would not enforce this rule if there were no other issues with 
the commits, Mark will have to cleanup/rework commits anyway, see other 
review comments. Thus removing/slightly rephrasing a commit message 
sounds like a minor issue to me.

>>>
>>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>>> Signed-off-by: Mark Yacoub <markyacoub@chromium.org>
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-15-sean@poorly.run #v1
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-14-sean@poorly.run #v2
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-14-sean@poorly.run #v3
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-14-sean@poorly.run #v4
>>> Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-10-sean@poorly.run #v5
>>
>> Drop the links.
> 
> Why? I've always done this, it seems helpful to me?
> 

I'd say, if you wish to include them, they belong to the cover letter, 
not to the per-commit message. Once landed, they will serve no purpose.

-- 
With best wishes
Dmitry