From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Mark Yacoub <markyacoub@chromium.org>
Cc: quic_khsieh@quicinc.com, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-gfx@lists.freedesktop.org, robdclark@gmail.com,
quic_abhinavk@quicinc.com, sean@poorly.run, airlied@gmail.com,
daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, agross@kernel.org,
andersson@kernel.org, konrad.dybcio@somainline.org,
jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
tzimmermann@suse.de, ville.syrjala@linux.intel.com,
stanislav.lisovskiy@intel.com, matthew.d.roper@intel.com,
imre.deak@intel.com, lucas.demarchi@intel.com,
manasi.d.navare@intel.com, swati2.sharma@intel.com,
bhanuprakash.modem@intel.com, javierm@redhat.com,
jose.souza@intel.com, lyude@redhat.com, hbh25y@gmail.com,
arun.r.murthy@intel.com, ashutosh.dixit@intel.com,
ankit.k.nautiyal@intel.com, maxime@cerno.tech,
swboyd@chromium.org, christophe.jaillet@wanadoo.fr,
quic_sbillaka@quicinc.com, johan+linaro@kernel.org,
dianders@chromium.org, marex@denx.de, quic_jesszhan@quicinc.com,
bjorn.andersson@linaro.org, abhinavk@codeaurora.org,
seanpaul@chromium.org, Rob Herring <robh@kernel.org>,
Mark Yacoub <markyacoub@chromiu.org>
Subject: Re: [PATCH v6 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers
Date: Thu, 19 Jan 2023 10:36:59 +0200 [thread overview]
Message-ID: <CAA8EJpq689pt0VXEjo_F48W8JQ+MGnEX3TH1z2ACdD_49YG-mg@mail.gmail.com> (raw)
In-Reply-To: <20230118193015.911074-9-markyacoub@google.com>
On Wed, 18 Jan 2023 at 21:30, Mark Yacoub <markyacoub@chromium.org> wrote:
>
> From: Sean Paul <seanpaul@chromium.org>
>
> This patch adds the bindings for the MSM DisplayPort HDCP registers
> which are required to write the HDCP key into the display controller as
> well as the registers to enable HDCP authentication/key
> exchange/encryption.
>
> We'll use a new compatible string for this since the fields are optional.
This doesn't correspond to patch contents.
>
> Cc: Rob Herring <robh@kernel.org>
This should be a
> Cc: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Mark Yacoub <markyacoub@chromiu.org>
> Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1
> Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2
> Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3
> Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-13-sean@poorly.run #v4
> Link: https://patchwork.freedesktop.org/patch/msgid/20211115202153.117244-1-sean@poorly.run #v4.5
> Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-9-sean@poorly.run #v5
Please, clean this up. I suspect that the long list of previous
iterations might belong to the cover letter, but not to the series
themselves.
>
> Changes in v2:
> -Drop register range names (Stephen)
> -Fix yaml errors (Rob)
> Changes in v3:
> -Add new compatible string for dp-hdcp
> -Add descriptions to reg
> -Add minItems/maxItems to reg
> -Make reg depend on the new hdcp compatible string
> Changes in v4:
> -Rebase on Bjorn's multi-dp patchset
> Changes in v4.5:
> -Remove maxItems from reg (Rob)
> -Remove leading zeros in example (Rob)
> Changes in v5:
> -None
> Changes in v6:
> -Rebased: modify minItems instead of adding it as new line.
>
> ---
> .../devicetree/bindings/display/msm/dp-controller.yaml | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index f2515af8256f..17d741f9af86 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -24,13 +24,15 @@ properties:
> - qcom,sm8350-dp
>
> reg:
> - minItems: 4
> + minItems: 5
No. eDP uses 4 register blocks.
> items:
> - description: ahb register block
> - description: aux register block
> - description: link register block
> - description: p0 register block
> - description: p1 register block
> + - description: (Optional) Registers for HDCP device key injection
> + - description: (Optional) Registers for HDCP TrustZone interaction
>
> interrupts:
> maxItems: 1
> @@ -154,7 +156,9 @@ examples:
> <0xae90200 0x200>,
> <0xae90400 0xc00>,
> <0xae91000 0x400>,
> - <0xae91400 0x400>;
> + <0xae91400 0x400>,
> + <0xaed1000 0x174>,
> + <0xaee1000 0x2c>;
> interrupt-parent = <&mdss>;
> interrupts = <12>;
> clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,
> --
> 2.39.0.246.g2a6d74b583-goog
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-01-19 8:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 19:30 [PATCH v6 00/10] drm/hdcp: Pull HDCP auth/exchange/check into helpers Mark Yacoub
2023-01-18 19:30 ` [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check() Mark Yacoub
2023-01-19 10:37 ` Krzysztof Kozlowski
2023-01-20 15:32 ` Sean Paul
2023-01-20 20:33 ` Dmitry Baryshkov
2023-01-19 11:41 ` Dmitry Baryshkov
2023-03-10 5:30 ` [Intel-gfx] " Kandpal, Suraj
2023-01-18 19:30 ` [PATCH v6 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check Mark Yacoub
2023-01-19 11:45 ` Dmitry Baryshkov
2023-03-10 6:00 ` [Intel-gfx] " Kandpal, Suraj
2023-01-18 19:30 ` [PATCH v6 03/10] drm/hdcp: Update property value on content type and user changes Mark Yacoub
2023-01-18 19:30 ` [PATCH v6 04/10] drm/hdcp: Expand HDCP helper library for enable/disable/check Mark Yacoub
2023-01-19 12:54 ` Dmitry Baryshkov
2023-01-18 19:30 ` [PATCH v6 05/10] drm/i915/hdcp: Consolidate HDCP setup/state cache Mark Yacoub
2023-01-18 19:30 ` [PATCH v6 06/10] drm/i915/hdcp: Retain hdcp_capable return codes Mark Yacoub
2023-03-10 8:25 ` Kandpal, Suraj
2023-03-23 7:17 ` Kandpal, Suraj
2023-03-24 19:27 ` Mark Yacoub
2023-03-28 5:52 ` Kandpal, Suraj
2023-01-18 19:30 ` [PATCH v6 07/10] drm/i915/hdcp: Use HDCP helpers for i915 Mark Yacoub
2023-01-31 17:16 ` [Intel-gfx] " Rodrigo Vivi
2023-01-31 17:23 ` Rodrigo Vivi
2023-03-14 5:54 ` Kandpal, Suraj
2023-03-24 19:34 ` Mark Yacoub
2023-03-28 6:12 ` Kandpal, Suraj
2023-01-18 19:30 ` [PATCH v6 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers Mark Yacoub
2023-01-19 1:16 ` Rob Herring
2023-01-19 7:48 ` Johan Hovold
2023-01-19 8:36 ` Dmitry Baryshkov [this message]
2023-01-18 19:30 ` [PATCH v6 09/10] arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller Mark Yacoub
2023-01-19 1:32 ` Abhinav Kumar
2023-01-19 8:40 ` Dmitry Baryshkov
2023-01-19 10:35 ` Krzysztof Kozlowski
2023-01-20 15:54 ` Sean Paul
2023-01-21 10:16 ` Dmitry Baryshkov
2023-01-21 19:06 ` Krzysztof Kozlowski
2023-01-18 19:30 ` [PATCH v6 10/10] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers Mark Yacoub
2023-01-19 11:35 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpq689pt0VXEjo_F48W8JQ+MGnEX3TH1z2ACdD_49YG-mg@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=agross@kernel.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=ankit.k.nautiyal@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hbh25y@gmail.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=javierm@redhat.com \
--cc=johan+linaro@kernel.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=jose.souza@intel.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=lyude@redhat.com \
--cc=manasi.d.navare@intel.com \
--cc=marex@denx.de \
--cc=markyacoub@chromiu.org \
--cc=markyacoub@chromium.org \
--cc=matthew.d.roper@intel.com \
--cc=maxime@cerno.tech \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=stanislav.lisovskiy@intel.com \
--cc=swati2.sharma@intel.com \
--cc=swboyd@chromium.org \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).