[PATCH] drivers: vxlan: fix returnvar.cocci warning

* [PATCH] drivers: vxlan: fix returnvar.cocci warning
@ 2022-03-08 10:00 Guo Zhengkui
  2022-03-08 10:49 ` Paolo Abeni
  0 siblings, 1 reply; 5+ messages in thread
From: Guo Zhengkui @ 2022-03-08 10:00 UTC (permalink / raw)
  To: David S. Miller, Jakub Kicinski, Roopa Prabhu, Eric Dumazet,
	Sebastian Andrzej Siewior, open list:NETWORKING DRIVERS,
	open list
  Cc: zhengkui_guo, Guo Zhengkui

Fix the following coccicheck warning:

drivers/net/vxlan/vxlan_core.c:2995:5-8:
Unneeded variable: "ret". Return "0" on line 3004.

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/net/vxlan/vxlan_core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
index b3cbd37c4b93..e06158a42823 100644
--- a/drivers/net/vxlan/vxlan_core.c
+++ b/drivers/net/vxlan/vxlan_core.c
@@ -2986,28 +2986,27 @@ static void vxlan_flush(struct vxlan_dev *vxlan, bool do_all)
 		}
 		spin_unlock_bh(&vxlan->hash_lock[h]);
 	}
 }
 
 /* Cleanup timer and forwarding table on shutdown */
 static int vxlan_stop(struct net_device *dev)
 {
 	struct vxlan_dev *vxlan = netdev_priv(dev);
-	int ret = 0;
 
 	vxlan_multicast_leave(vxlan);
 
 	del_timer_sync(&vxlan->age_timer);
 
 	vxlan_flush(vxlan, false);
 	vxlan_sock_release(vxlan);
 
-	return ret;
+	return 0;
 }
 
 /* Stub, nothing needs to be done. */
 static void vxlan_set_multicast_list(struct net_device *dev)
 {
 }
 
 static int vxlan_change_mtu(struct net_device *dev, int new_mtu)
 {
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread