From: Govinda Tatti <govinda.tatti@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: roger.pau@citrix.com, xen-devel@lists.xenproject.org,
boris.ostrovsky@oracle.com, Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute
Date: Thu, 30 Nov 2017 08:15:25 -0600 [thread overview]
Message-ID: <71644190-6e18-94a4-4da5-e65c041fb45a@oracle.com> (raw)
In-Reply-To: <5A1FCF150200007800193632@prv-mh.provo.novell.com>
On 11/30/2017 2:27 AM, Jan Beulich wrote:
>>>> On 29.11.17 at 18:38, <govinda.tatti@oracle.com> wrote:
>>>> In the case of bus or slot reset, our goal is to reset connected PCIe
>>>> fabric/card/endpoint.
>>>> The connected card/endpoint can be multi-function device. So, same
>>>> walk-through and checking
>>>> is needed irrespective of type of reset being used.
>>> I don't follow: The scope of other devices/functions possibly
>>> affected by a reset depends on the type of reset, doesn't it?
>> For PCIe platforms, both slot and bus reset endup resetting all connected
>> device/functions on thesecondary bus (behind the root-port or
>> downstream-port).
> According to my understanding this contradicts the comment
> ahead of pci_reset_slot(), which talks of multiple slots per bus.
> In such a setup, I can't see why resetting on slot would affect
> other slots on the same bus. At the same time the comment
> says that the slot reset may resolve to a bus one when there's
> just a single slot on the bus.
For legacy PCI/PCI-X, we can have multiple slots per bus but not with
PCI-Express
(each link will be on a separate bus). In anycase, we need to
walk-through other
device/functions on the same bus/slot and check their status before
using slot/bus
reset.
Cheers
GOVINDA
next prev parent reply other threads:[~2017-11-30 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 23:06 [PATCH V2] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute Govinda Tatti
2017-11-09 8:49 ` Jan Beulich
2017-11-29 15:37 ` [Xen-devel] " Govinda Tatti
2017-11-29 15:50 ` Jan Beulich
2017-11-29 17:38 ` Govinda Tatti
2017-11-30 8:27 ` Jan Beulich
2017-11-30 14:15 ` Govinda Tatti [this message]
2017-11-30 14:46 ` Jan Beulich
2017-12-01 16:16 ` Govinda Tatti
2017-12-04 16:16 ` Govinda Tatti
2017-12-04 16:49 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71644190-6e18-94a4-4da5-e65c041fb45a@oracle.com \
--to=govinda.tatti@oracle.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).