* [PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap_resource()
@ 2021-09-01 5:51 Cai Huoqing
2021-09-01 6:46 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Cai Huoqing @ 2021-09-01 5:51 UTC (permalink / raw)
To: caihuoqing
Cc: Philipp Zabel, Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-media, linux-arm-kernel, linux-kernel
Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
drivers/media/platform/imx-pxp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c
index 4321edc0c23d..723b096fedd1 100644
--- a/drivers/media/platform/imx-pxp.c
+++ b/drivers/media/platform/imx-pxp.c
@@ -1636,7 +1636,6 @@ static int pxp_soft_reset(struct pxp_dev *dev)
static int pxp_probe(struct platform_device *pdev)
{
struct pxp_dev *dev;
- struct resource *res;
struct video_device *vfd;
int irq;
int ret;
@@ -1652,8 +1651,7 @@ static int pxp_probe(struct platform_device *pdev)
return ret;
}
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- dev->mmio = devm_ioremap_resource(&pdev->dev, res);
+ dev->mmio = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(dev->mmio))
return PTR_ERR(dev->mmio);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap_resource()
2021-09-01 5:51 [PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
@ 2021-09-01 6:46 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2021-09-01 6:46 UTC (permalink / raw)
To: Cai Huoqing
Cc: Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
linux-media, linux-arm-kernel, linux-kernel
On Wed, 2021-09-01 at 13:51 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> drivers/media/platform/imx-pxp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c
> index 4321edc0c23d..723b096fedd1 100644
> --- a/drivers/media/platform/imx-pxp.c
> +++ b/drivers/media/platform/imx-pxp.c
> @@ -1636,7 +1636,6 @@ static int pxp_soft_reset(struct pxp_dev *dev)
> static int pxp_probe(struct platform_device *pdev)
> {
> struct pxp_dev *dev;
> - struct resource *res;
> struct video_device *vfd;
> int irq;
> int ret;
> @@ -1652,8 +1651,7 @@ static int pxp_probe(struct platform_device *pdev)
> return ret;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> + dev->mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dev->mmio))
> return PTR_ERR(dev->mmio);
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-01 6:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 5:51 [PATCH] media: imx-pxp: Make use of the helper function devm_platform_ioremap_resource() Cai Huoqing
2021-09-01 6:46 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).