From: James Clark <james.clark@arm.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
peterz@infradead.org, acme@kernel.org
Cc: Robin Murphy <robin.murphy@arm.com>,
Suzuki Poulose <suzuki.poulose@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4 04/10] perf: Capture branch privilege information
Date: Wed, 16 Mar 2022 17:26:07 +0000 [thread overview]
Message-ID: <73353bec-6949-dd0b-ff1c-a8143e169602@arm.com> (raw)
In-Reply-To: <20220315053516.431515-5-anshuman.khandual@arm.com>
On 15/03/2022 05:35, Anshuman Khandual wrote:
> Platforms like arm64 could capture privilege level information for all the
> branch records. Hence this adds a new element in the struct branch_entry to
> record the privilege level information, which could be requested through a
> new event.attr.branch_sample_type based flag PERF_SAMPLE_BRANCH_PRIV_SAVE.
> This flag helps user choose whether privilege information is captured.
>
Reviewed-by: James Clark <james.clark@arm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Will Deacon <will@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-perf-users@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
> include/uapi/linux/perf_event.h | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index d29280adc3c4..193dba2ecdc1 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -204,6 +204,8 @@ enum perf_branch_sample_type_shift {
>
> PERF_SAMPLE_BRANCH_HW_INDEX_SHIFT = 17, /* save low level index of raw branch records */
>
> + PERF_SAMPLE_BRANCH_PRIV_SAVE_SHIFT = 18, /* save privilege mode */
> +
> PERF_SAMPLE_BRANCH_MAX_SHIFT /* non-ABI */
> };
>
> @@ -233,6 +235,8 @@ enum perf_branch_sample_type {
>
> PERF_SAMPLE_BRANCH_HW_INDEX = 1U << PERF_SAMPLE_BRANCH_HW_INDEX_SHIFT,
>
> + PERF_SAMPLE_BRANCH_PRIV_SAVE = 1U << PERF_SAMPLE_BRANCH_PRIV_SAVE_SHIFT,
> +
> PERF_SAMPLE_BRANCH_MAX = 1U << PERF_SAMPLE_BRANCH_MAX_SHIFT,
> };
>
> @@ -271,6 +275,13 @@ enum {
> PERF_BR_NEW_MAX,
> };
>
> +enum {
> + PERF_BR_PRIV_UNKNOWN = 0,
> + PERF_BR_PRIV_USER = 1,
> + PERF_BR_PRIV_KERNEL = 2,
> + PERF_BR_PRIV_HV = 3,
> +};
> +
> #define PERF_SAMPLE_BRANCH_PLM_ALL \
> (PERF_SAMPLE_BRANCH_USER|\
> PERF_SAMPLE_BRANCH_KERNEL|\
> @@ -1386,7 +1397,8 @@ struct perf_branch_entry {
> cycles:16, /* cycle count to last branch */
> type:4, /* branch type */
> new_type:4, /* additional branch type */
> - reserved:36;
> + priv:3, /* privilege level */
> + reserved:33;
> };
>
> union perf_sample_weight {
next prev parent reply other threads:[~2022-03-16 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 5:35 [PATCH V4 00/10] perf: Expand perf_branch_entry Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 01/10] perf: Add irq and exception return branch types Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 02/10] perf: Add system error and not in transaction " Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 03/10] perf: Extend branch type classification Anshuman Khandual
2022-03-15 11:22 ` Peter Zijlstra
2022-03-15 13:06 ` Robin Murphy
2022-03-16 12:20 ` Peter Zijlstra
2022-03-17 5:41 ` Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 04/10] perf: Capture branch privilege information Anshuman Khandual
2022-03-16 17:26 ` James Clark [this message]
2022-03-15 5:35 ` [PATCH V4 05/10] perf: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 06/10] perf/tools: Add irq and exception return branch types Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 07/10] perf/tools: Add system error and not in transaction " Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 08/10] perf/tools: Extend branch type classification Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 09/10] perf/tools: Add branch privilege information request flag Anshuman Khandual
2022-03-15 5:35 ` [PATCH V4 10/10] perf/tools: Add PERF_BR_NEW_ARCH_[N] map for BRBE on arm64 platform Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73353bec-6949-dd0b-ff1c-a8143e169602@arm.com \
--to=james.clark@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).