linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Bart Van Assche <bvanassche@acm.org>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Joel Becker <jlbec@evilplan.org>,
	linux-kernel@vger.kernel.org,
	Brendan Higgins <brendanhiggins@google.com>,
	David Gow <davidgow@google.com>,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	Bodo Stroesser <bostroesser@gmail.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Yanko Kaneti <yaneti@declera.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup
Date: Thu, 29 Jul 2021 10:55:31 -0600	[thread overview]
Message-ID: <733cb812-8696-45f4-356d-cfe5bd85eb9b@linuxfoundation.org> (raw)
In-Reply-To: <8ab0ea44-760a-61df-0b9a-8b314ca9a0fe@acm.org>

On 7/29/21 10:52 AM, Bart Van Assche wrote:
> On 7/28/21 10:55 PM, Greg KH wrote:
>> On Wed, Jul 28, 2021 at 09:41:24PM -0700, Bart Van Assche wrote:
>>> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>>> Cc: David Gow <davidgow@google.com>
>>> Cc: Shuah Khan <skhan@linuxfoundation.org>
>>> Cc: kunit-dev@googlegroups.com
>>> Cc: linux-kselftest@vger.kernel.org
>>> Cc: Bodo Stroesser <bostroesser@gmail.com>
>>> Cc: Martin K. Petersen <martin.petersen@oracle.com>
>>> Cc: Yanko Kaneti <yaneti@declera.com>
>>> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
>>> ---
>>
>> I know I do not take patches without any changelog text.  Maybe other
>> maintainers are more lax :(
> 
> Almost every patch from me has an elaborate changelog. For this patch I chose not to add a changelog since I think that the subject is self-explanatory?
> 

I don't take patches without change logs either. I can't say the subject
tells me what you are doing.

Please add a change log.

thanks,
-- Shuah


  reply	other threads:[~2021-07-29 16:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  4:41 [PATCH v2 0/3] Restore the kernel v5.13 text attribute write behavior Bart Van Assche
2021-07-29  4:41 ` [PATCH v2 1/3] configfs: " Bart Van Assche
2021-07-29  4:41 ` [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup Bart Van Assche
2021-07-29  5:55   ` Greg KH
2021-07-29 16:52     ` Bart Van Assche
2021-07-29 16:55       ` Shuah Khan [this message]
2021-07-29 17:16         ` Bart Van Assche
2021-07-29 18:42           ` Shuah Khan
2021-07-29 19:22             ` Bart Van Assche
2021-07-29 20:42               ` Shuah Khan
2021-07-29  4:41 ` [PATCH v2 3/3] configfs: Add unit tests Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=733cb812-8696-45f4-356d-cfe5bd85eb9b@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=bostroesser@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=bvanassche@acm.org \
    --cc=davidgow@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=jlbec@evilplan.org \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=yaneti@declera.com \
    --subject='Re: [PATCH v2 2/3] kunit: Add support for suite initialization and cleanup' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).