From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Jaechul Lee <jcsing.lee@samsung.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Andi Shyti <andi.shyti@samsung.com>,
beomho.seo@samsung.com, galaxyra@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25
Date: Fri, 06 Jan 2017 18:06:43 +0900 [thread overview]
Message-ID: <73639ec8-028a-56a2-0b47-3465974ec3f3@samsung.com> (raw)
In-Reply-To: <20170106085026.5pfwyxt2qipzbjpy@kozik-lap>
On 2017년 01월 06일 17:50, Krzysztof Kozlowski wrote:
> On Fri, Jan 06, 2017 at 04:20:52PM +0900, Chanwoo Choi wrote:
>> On 2017년 01월 06일 16:05, Krzysztof Kozlowski wrote:
>>> On Fri, Jan 06, 2017 at 12:59:05PM +0900, Jaechul Lee wrote:
>>>> From: Chanwoo Choi <cw00.choi@samsung.com>
>>>>
>>>> This patch fixes the wrong information of ldo23 and ldo25 on both TM2 and TM2E.
>>>
>>> Please describe what is exactly wrong and how it affects the
>>> system/user. This is going to the fixes so it needs a good explanation.
>>
>> When I posted the patch[1], I refer to the old schematic document of both TM2 and TM2E.
>> [1] 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based TM2 board")
>>
>> After checking the highest version of schematic document of both TM2 and TM2E,
>> there is no difference of ldo23/ldo25 on both TM2 and TM2E.
>> - ldo23 is used on TM2/TM2E, but the name/max-microvolt are wrong.
>> - ldo25 isn't used on TM2/TM2E. (not connected)
>>
>> Because ldo23 and lod25 are not used on other device in Exynos5433 and TM2 board.
>> this patch does not affect the operation to system/user.
>
> If it does not affect anyone (including TM2/TM2E) then this do not have
> to be a fix. Am I right?
This patch does not affect the TM2/TM2E's operation
because ldo23/25 are not used on TM2/TM2E. Just fix the wrong information.
--
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics
next prev parent reply other threads:[~2017-01-06 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170106035913epcas5p2b7d66596e467c6169786eea56beb8ffc@epcas5p2.samsung.com>
2017-01-06 3:59 ` [PATCH v3 0/5] Add touch key driver support for TM2 Jaechul Lee
[not found] ` <CGME20170106035913epcas5p20336406863f1029ccf614520f366ddcf@epcas5p2.samsung.com>
2017-01-06 3:59 ` [PATCH v3 1/5] arm64: dts: exynos5433: TM2/E: Fix wrong information of ldo23 and ldo25 Jaechul Lee
2017-01-06 7:05 ` Krzysztof Kozlowski
2017-01-06 7:20 ` Chanwoo Choi
2017-01-06 8:50 ` Krzysztof Kozlowski
2017-01-06 9:06 ` Chanwoo Choi [this message]
2017-01-06 9:12 ` Krzysztof Kozlowski
[not found] ` <CGME20170106035914epcas5p209490dfca8e8ae83c6a9b5aa1408a1ed@epcas5p2.samsung.com>
2017-01-06 3:59 ` [PATCH v3 2/5] arm64: dts: exynos: make tm2 and tm2e independent from each other Jaechul Lee
2017-01-06 7:09 ` Krzysztof Kozlowski
2017-01-06 7:59 ` Andi Shyti
2017-01-06 8:37 ` Krzysztof Kozlowski
2017-01-06 9:25 ` Andi Shyti
[not found] ` <CGME20170106035914epcas5p2954865ce8060c6aaee61a7526e417b7d@epcas5p2.samsung.com>
2017-01-06 3:59 ` [PATCH v3 3/5] input: Add support for the tm2 touchkey device driver Jaechul Lee
[not found] ` <CGME20170106035914epcas5p20aa47294b5667e8842587c63cd2b4f3e@epcas5p2.samsung.com>
2017-01-06 3:59 ` [PATCH v3 4/5] input: tm2-touchkey: Add touchkey driver support for TM2 Jaechul Lee
[not found] ` <CGME20170106035914epcas5p2bd9b2358c41d32f7a677d75afba95144@epcas5p2.samsung.com>
2017-01-06 3:59 ` [PATCH v3 5/5] arm64: dts: exynos: Add tm2 touchkey node Jaechul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73639ec8-028a-56a2-0b47-3465974ec3f3@samsung.com \
--to=cw00.choi@samsung.com \
--cc=andi.shyti@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galaxyra@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).