Re: mmotm 2010-02-14-00-49 uploaded - synaptics breakage

Re: mmotm 2010-02-14-00-49 uploaded - synaptics breakage

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 602 bytes --]

On Sat, 14 Feb 2009 00:51:41 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2009-02-14-00-49 has been uploaded to

The two patches:

psmouse-synaptics-ensure-we-reset-the-device-on-resume.patch
psmouse-synaptics-ensure-we-reset-the-device-on-resume-fix.patch

make my laptop (Dell Latitude D820) throw this message at every boot:

WARNING: synaptics was reset on resume. Try using the synaptics_resume_reset module parameter if you have trouble on resume

I have no idea what it does at resume, I don't *use* suspend/resume.

Is this supposed to be resume-only, or at every boot?

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm 2009-02-14-00-49 uploaded -epoll busted.

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Sat, 14 Feb 2009 00:51:41 PST, akpm@linux-foundation.org said:
> The mm-of-the-moment snapshot 2009-02-14-00-49 has been uploaded to

The epoll patch series breaks nscd in some odd way.  After it's started
in the /etc/rc* scripts, the rest of boot proceeds very slowly, smells like
nscd calls are hitting timeouts.  Boot time went from ~1 minute to ~10 mins.

nscd is Fedora Rawhide nscd-2.9.90-3.x86_64, in case that matters...

Also, the series isn't bisectable right where it matters most, complaining
about implicit definitions of wake_up_nested...

epoll-keyed-wakeups-v2-add-__wake_up_locked_key-and-__wake_up_sync_key.patch
epoll-keyed-wakeups-v2-introduce-new-_poll-wakeup-macros.patch  GOOD
epoll-keyed-wakeups-v3-introduce-new-_poll-wakeup-macros.patch  BISECT BUSTED
epoll-keyed-wakeups-v2-make-sockets-use-keyed-wakeups.patch
epoll-keyed-wakeups-v2-teach-epoll-about-hints-coming-with-the-wakeup-key.patch
epoll-keyed-wakeups-v2-teach-epoll-about-hints-coming-with-the-wakeup-key-update.patch  BAD



[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]

Re: mmotm 2009-02-14-00-49 uploaded -epoll busted.

[Davide Libenzi]

On Tue, 17 Feb 2009, Valdis.Kletnieks@vt.edu wrote:

> On Sat, 14 Feb 2009 00:51:41 PST, akpm@linux-foundation.org said:
> > The mm-of-the-moment snapshot 2009-02-14-00-49 has been uploaded to
> 
> The epoll patch series breaks nscd in some odd way.  After it's started
> in the /etc/rc* scripts, the rest of boot proceeds very slowly, smells like
> nscd calls are hitting timeouts.  Boot time went from ~1 minute to ~10 mins.
> 
> nscd is Fedora Rawhide nscd-2.9.90-3.x86_64, in case that matters...
> 
> Also, the series isn't bisectable right where it matters most, complaining
> about implicit definitions of wake_up_nested...
> 
> epoll-keyed-wakeups-v2-add-__wake_up_locked_key-and-__wake_up_sync_key.patch
> epoll-keyed-wakeups-v2-introduce-new-_poll-wakeup-macros.patch  GOOD
> epoll-keyed-wakeups-v3-introduce-new-_poll-wakeup-macros.patch  BISECT BUSTED
> epoll-keyed-wakeups-v2-make-sockets-use-keyed-wakeups.patch
> epoll-keyed-wakeups-v2-teach-epoll-about-hints-coming-with-the-wakeup-key.patch
> epoll-keyed-wakeups-v2-teach-epoll-about-hints-coming-with-the-wakeup-key-update.patch  BAD

Alright, I took a peek at nscd and noticed it waits only for RDNORM.
Inside the socket code, the full flags computation is performed inside the 
poll function, and ATM socket code has simple signaling of IN/OUT/ERR. We 
could changethe socket code to allow more fine grained event signaling, 
but IMO is not worth it. Epoll ends up calling the device poll anyway, and 
since this is an optimization patch, a simple change to post a full IN/OUT 
mask is enough.
Andrew, the patch below replaced the one you have under the name:

epoll-keyed-wakeups-v2-make-sockets-use-keyed-wakeups.patch



Signed-off-by: Davide Libenzi <davidel@xmailserver.org>


- Davide


---
 net/core/sock.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Index: linux-2.6.mod/net/core/sock.c
===================================================================
--- linux-2.6.mod.orig/net/core/sock.c	2009-02-17 10:14:56.000000000 -0800
+++ linux-2.6.mod/net/core/sock.c	2009-02-17 10:21:43.000000000 -0800
@@ -1630,7 +1630,7 @@ static void sock_def_error_report(struct
 {
 	read_lock(&sk->sk_callback_lock);
 	if (sk->sk_sleep && waitqueue_active(sk->sk_sleep))
-		wake_up_interruptible(sk->sk_sleep);
+		wake_up_interruptible_poll(sk->sk_sleep, POLLERR);
 	sk_wake_async(sk, SOCK_WAKE_IO, POLL_ERR);
 	read_unlock(&sk->sk_callback_lock);
 }
@@ -1639,7 +1639,8 @@ static void sock_def_readable(struct soc
 {
 	read_lock(&sk->sk_callback_lock);
 	if (sk->sk_sleep && waitqueue_active(sk->sk_sleep))
-		wake_up_interruptible_sync(sk->sk_sleep);
+		wake_up_interruptible_sync_poll(sk->sk_sleep, POLLIN |
+						POLLRDNORM | POLLRDBAND);
 	sk_wake_async(sk, SOCK_WAKE_WAITD, POLL_IN);
 	read_unlock(&sk->sk_callback_lock);
 }
@@ -1653,7 +1654,8 @@ static void sock_def_write_space(struct 
 	 */
 	if ((atomic_read(&sk->sk_wmem_alloc) << 1) <= sk->sk_sndbuf) {
 		if (sk->sk_sleep && waitqueue_active(sk->sk_sleep))
-			wake_up_interruptible_sync(sk->sk_sleep);
+			wake_up_interruptible_sync_poll(sk->sk_sleep, POLLOUT |
+							POLLWRNORM | POLLWRBAND);
 
 		/* Should agree with poll, otherwise some programs break */
 		if (sock_writeable(sk))

Re: mmotm 2009-02-14-00-49 uploaded -epoll busted.

[Valdis.Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 343 bytes --]

On Tue, 17 Feb 2009 10:31:07 PST, Davide Libenzi said:

> Andrew, the patch below replaced the one you have under the name:
> 
> epoll-keyed-wakeups-v2-make-sockets-use-keyed-wakeups.patch

I built a new -rc5-mmotm0214 with that patch replaced, and things are
working as designed again.  Glad you were able to figure out what the
problem was.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]