[PATCH] video/macfb: Always initialize DAFB colour table pointer register

[PATCH] video/macfb: Always initialize DAFB colour table pointer register

[Finn Thain]

Don't skip the framebuffer CLUT pointer register initialization when
the first dafb_setpalette() invocation has regno equal to zero.

Cc: linux-m68k@lists.linux-m68k.org
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
 drivers/video/fbdev/macfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/macfb.c b/drivers/video/fbdev/macfb.c
index 37c56c45ee39..8820a556014c 100644
--- a/drivers/video/fbdev/macfb.c
+++ b/drivers/video/fbdev/macfb.c
@@ -148,7 +148,7 @@ static int dafb_setpalette(unsigned int regno, unsigned int red,
 			   unsigned int green, unsigned int blue,
 			   struct fb_info *info)
 {
-	static int lastreg = -1;
+	static int lastreg = -2;
 	unsigned long flags;
 
 	local_irq_save(flags);
-- 
2.19.2

Re: [PATCH] video/macfb: Always initialize DAFB colour table pointer register

[Bartlomiej Zolnierkiewicz]

On 02/18/2019 11:44 PM, Finn Thain wrote:
> Don't skip the framebuffer CLUT pointer register initialization when
> the first dafb_setpalette() invocation has regno equal to zero.
> 
> Cc: linux-m68k@lists.linux-m68k.org
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Finn Thain <fthain@telegraphics.com.au>

Patch queued for v5.2, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics