Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Tue, Jun 15, 2021 at 09:57:48AM -0700, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> ---

I only received 2 patches, here 1/3 and 2/3.  What happened to 3/3?

And please use 'git send-email' to properly thread your patches so our
tools can correctly pick up the whole series when wanting to do things
with them.

Can you fix that up and resend?

thanks,

greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Tue, Jun 15, 2021 at 09:57:48AM -0700, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> ---
> 
> Notes:
>     Change log
>      drivers/tty/serial/serial_cortina-access.c
>       v4:
>        - Removed modification to core serial.h which added unique
>          ID for this driver. Instead used internal assigned ID
>          similar to the method used by the liteuart driver to
>          avoid adding additional IDs to the core serial.h file.

Note, this is really v5, you added the MAINTAINERS entry.  Please be
more careful.

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

> On Jun 15, 2021, at 10:15 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 15, 2021 at 09:57:48AM -0700, Alex Nemirovsky wrote:
>> From: Jason Li <jason.li@cortina-access.com>
>> 
>> This driver supports Cortina Access UART IP integrated
>> in most all CAXXXX line of SoCs. Earlycom is also supported
>> 
>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>> ---
>> 
>> Notes:
>>    Change log
>>     drivers/tty/serial/serial_cortina-access.c
>>      v4:
>>       - Removed modification to core serial.h which added unique
>>         ID for this driver. Instead used internal assigned ID
>>         similar to the method used by the liteuart driver to
>>         avoid adding additional IDs to the core serial.h file.
> 
> Note, this is really v5, you added the MAINTAINERS entry.  Please be
> more careful.
still v4.  no changes made.  Making sure that Rob gets this into his DT queue.

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

> On Jun 15, 2021, at 10:15 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 15, 2021 at 09:57:48AM -0700, Alex Nemirovsky wrote:
>> From: Jason Li <jason.li@cortina-access.com>
>> 
>> This driver supports Cortina Access UART IP integrated
>> in most all CAXXXX line of SoCs. Earlycom is also supported
>> 
>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>> ---
> 
> I only received 2 patches, here 1/3 and 2/3.  What happened to 3/3?
> 
> And please use 'git send-email' to properly thread your patches so our
> tools can correctly pick up the whole series when wanting to do things
> with them.

yup..I used git send-email.   Apparently the tool didn’t find you on the 
list for DT and ARM based changes.   I’ll send you a copy of 3/3.
> 
> Can you fix that up and resend?
> 
> thanks,
> 
> greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

> On Jun 15, 2021, at 8:40 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> A: No.
> Q: Should I include quotations after my reply?
> 
> http://daringfireball.net/2007/07/on_top
> 
> On Tue, Jun 15, 2021 at 02:33:57PM +0000, Alex Nemirovsky wrote:
>> Does the serial driver portion in the first patch, require any more changes from your point of view
>> as the serial driver maintainer?  If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not 
>> ACK or provided any feedback on the DT portion.   Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?
> 
> I was waiting for the DT review before I looked at the serial driver
> again.
> 
> thanks,
> 
> greg k-h

Seems like we might be in a catch-22 situation here.  This patch series has been in review around 6 months no and I have yet to see any feedback from the DT team.
Do you ever reach out to them to try to get closer?  If you have had luck, perhaps you can send a quick email to them to get this driver off your plate. I’m sure you
would rather have this resolved on off your queue so you can have more time for other more important matters.

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jun 15, 2021 at 02:33:57PM +0000, Alex Nemirovsky wrote:
> Does the serial driver portion in the first patch, require any more changes from your point of view
> as the serial driver maintainer?  If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not 
> ACK or provided any feedback on the DT portion.   Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?

I was waiting for the DT review before I looked at the serial driver
again.

thanks,

greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

Does the serial driver portion in the first patch, require any more changes from your point of view
as the serial driver maintainer?  If there are no issues with the driver itself, we can engage with the DT team to figure out why they have not 
ACK or provided any feedback on the DT portion.   Are you good with the content of the serial driver itself minus the lack of ACK from the DT team?

> On Jun 15, 2021, at 7:13 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Tue, Jun 15, 2021 at 01:32:51PM +0000, Alex Nemirovsky wrote:
>> The DT maintainers were CC’ed for the DT related files.  However, I suspect they won’t 
>> ACK it until you ACK the actual serial port driver.
> 
> It goes the other way around :)

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Tue, Jun 15, 2021 at 01:32:51PM +0000, Alex Nemirovsky wrote:
> The DT maintainers were CC’ed for the DT related files.  However, I suspect they won’t 
> ACK it until you ACK the actual serial port driver.

It goes the other way around :)

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Alex Nemirovsky]

The DT maintainers were CC’ed for the DT related files.  However, I suspect they won’t 
ACK it until you ACK the actual serial port driver.

> On Jun 15, 2021, at 4:52 AM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Sun, May 09, 2021 at 11:45:16AM -0700, Alex Nemirovsky wrote:
>> From: Jason Li <jason.li@cortina-access.com>
>> 
>> This driver supports Cortina Access UART IP integrated
>> in most all CAXXXX line of SoCs. Earlycom is also supported
>> 
>> Signed-off-by: Jason Li <jason.li@cortina-access.com>
>> ---
> 
> I can't take this without the DT maintainers acking the DT changes.
> 
> So can you resend this so that they can notice that it requires their
> review?
> 
> thanks,
> 
> greg k-h

Re: [PATCH v4 1/3] tty: serial: Add UART driver for Cortina-Access platform

[Greg Kroah-Hartman]

On Sun, May 09, 2021 at 11:45:16AM -0700, Alex Nemirovsky wrote:
> From: Jason Li <jason.li@cortina-access.com>
> 
> This driver supports Cortina Access UART IP integrated
> in most all CAXXXX line of SoCs. Earlycom is also supported
> 
> Signed-off-by: Jason Li <jason.li@cortina-access.com>
> ---

I can't take this without the DT maintainers acking the DT changes.

So can you resend this so that they can notice that it requires their
review?

thanks,

greg k-h