From: Craig <ctatlor97@gmail.com>
To: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
Vijay Viswanath <vviswana@codeaurora.org>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
shawn.lin@rock-chips.com, linux-arm-msm@vger.kernel.org,
georgi.djakov@linaro.org, devicetree@vger.kernel.org,
asutoshd@codeaurora.org, stummala@codeaurora.org,
venkatg@codeaurora.org, jeremymc@redhat.com,
bjorn.andersson@linaro.org, riteshh@codeaurora.org,
dianders@google.com, sayalil@codeaurora.org
Subject: Re: [PATCH V3 0/4] Changes for SDCC5 version
Date: Sun, 07 Oct 2018 09:07:52 +0100 [thread overview]
Message-ID: <74ABB71C-6B0C-44AE-BC30-1F385ADC3E42@gmail.com> (raw)
In-Reply-To: <C01C1C07-13FA-4693-9493-2FAEE9153577@gmail.com>
Any updates on this?
On 25 September 2018 16:39:33 BST, Craig <ctatlor97@gmail.com> wrote:
>
>
>On 25 September 2018 12:17:26 BST, Veerabhadrarao Badiganti
><vbadigan@codeaurora.org> wrote:
>>
>>On 9/25/2018 1:18 AM, Craig Tatlor wrote:
>>> What socs have you tested this on?
>>> On sdm660 it seems to crash device
>>> when writing pwr ctl.
>>
>>Hi
>>We have tested this on SDM845.
>>SDM660 also has SDCC5 controller, so you would need to define
>>"qcom,sdhci-msm-v5" in your platform dt.
>>Can you confirm if you have defined this?
>>
>Hi,
>Yes my DT entry is as follows
>
>sdhc_1: sdhci@f9824900 {
>
>compatible = "qcom,sdhci-msm-v5";
>
>reg = <0xc0c4000 0x1000>, <0xc0c5000 0x1000>;
>
>interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>
>interrupt-names = "pwr_irq";
>
>
>bus-width = <8>;
>
>non-removable;
>
>
>vmmc-supply = <&pm660l_l4>;
>
>vqmmc-supply = <&pm660_l8>;
>
>
>pinctrl-names = "default";
>
>pinctrl-0 = <&sdc1_clk &sdc1_cmd &sdc1_data &sdc1_rclk>;
>
>
>clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>;
>
>clock-names = "core", "iface";
>
> };
>
>>BTW, can you please share few details of the platform that you are
>>checking?
>>We are not aware of any dev platform based on SDM660. This is just for
>
>>my info
>
>I'm checking on the sony xperia xa2 (pioneer) smartphone.
>>
>>> On Tue, Jun 19, 2018 at 11:09:17AM +0530, Vijay Viswanath wrote:
>>>> With SDCC5, the MCI register space got removed and the offset/order
>>of
>>>> several registers have changed. Based on SDCC version used and the
>>register,
>>>> we need to pick the base address and offset.
>>>>
>>>> Depends on patch series: "[PATCH V5 0/2] mmc: sdhci-msm:
>Configuring
>>IO_PAD support for sdhci-msm"
>>>>
>>>> Changes since RFC:
>>>> Dropped voltage regulator changes in sdhci-msm
>>>> Split the "Register changes for sdcc V5" patch
>>>> Instead of checking mci removal for deciding which base addr to
>>use,
>>>> new function pointers are defined for the 2 variants of sdcc:
>>>> 1) MCI present
>>>> 2) V5 (mci removed)
>>>> Instead of string comparing with the compatible string from DT
>>file,
>>>> the sdhci_msm_probe will now pick the data associated with the
>>>> compatible entry and use it to load variant specific address
>>offsets
>>>> and msm variant specific read/write ops.
>>>>
>>>> Changes since V1:
>>>> Removed unused msm_reab & msm_writeb APIs
>>>> Changed certain register addresses from uppercase to lowercase hex
>>>> letters
>>>> Removed extra lines and spaces
>>>> Split "[PATCH V1 0/3] Changes for SDCC5 version" patch into two,
>>>> one for Documentation and other for the driver changes.
>>>>
>>>> Changes since V2:
>>>> Used lower case for macro function defenitions
>>>> Removed unused function pointers for msm_readb & msm_writeb
>>>>
>>>>
>>>> Sayali Lokhande (3):
>>>> mmc: sdhci-msm: Define new Register address map
>>>> Documentation: sdhci-msm: Add new compatible string for SDCC v5
>>>> mmc: host: Register changes for sdcc V5
>>>>
>>>> Vijay Viswanath (1):
>>>> mmc: sdhci-msm: Add msm version specific ops and data structures
>>>>
>>>> .../devicetree/bindings/mmc/sdhci-msm.txt | 7 +-
>>>> drivers/mmc/host/sdhci-msm.c | 511
>>++++++++++++++++-----
>>>> 2 files changed, 391 insertions(+), 127 deletions(-)
>>>>
>>>> --
>>>> Qualcomm India Private Limited, on behalf of Qualcomm Innovation
>>Center, Inc.
>>>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>a
>>Linux Foundation Collaborative Project.
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe
>>linux-arm-msm" in
>>>> the body of a message to majordomo@vger.kernel.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>Thanks,
>>Veera
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2018-10-07 8:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 5:39 [PATCH V3 0/4] Changes for SDCC5 version Vijay Viswanath
2018-06-19 5:39 ` [PATCH V3 1/4] mmc: sdhci-msm: Define new Register address map Vijay Viswanath
2018-06-19 5:39 ` [PATCH V3 2/4] mmc: sdhci-msm: Add msm version specific ops and data structures Vijay Viswanath
2018-06-19 5:39 ` [PATCH V3 3/4] Documentation: sdhci-msm: Add new compatible string for SDCC v5 Vijay Viswanath
2018-06-19 5:39 ` [PATCH V3 4/4] mmc: host: Register changes for sdcc V5 Vijay Viswanath
2018-07-02 13:17 ` [PATCH V3 0/4] Changes for SDCC5 version Ulf Hansson
2018-09-24 19:48 ` Craig Tatlor
2018-09-25 11:17 ` Veerabhadrarao Badiganti
2018-09-25 15:39 ` Craig
2018-10-07 8:07 ` Craig [this message]
2018-10-08 6:56 ` Bjorn Andersson
2018-10-09 6:01 ` Veerabhadrarao Badiganti
2018-10-09 6:15 ` Craig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74ABB71C-6B0C-44AE-BC30-1F385ADC3E42@gmail.com \
--to=ctatlor97@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=georgi.djakov@linaro.org \
--cc=jeremymc@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=riteshh@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sayalil@codeaurora.org \
--cc=shawn.lin@rock-chips.com \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
--cc=venkatg@codeaurora.org \
--cc=vviswana@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).