Re: [PATCH V3 0/4] Changes for SDCC5 version

From: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
To: Craig Tatlor <ctatlor97@gmail.com>,
	Vijay Viswanath <vviswana@codeaurora.org>
Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org,
	robh+dt@kernel.org, mark.rutland@arm.com,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	shawn.lin@rock-chips.com, linux-arm-msm@vger.kernel.org,
	georgi.djakov@linaro.org, devicetree@vger.kernel.org,
	asutoshd@codeaurora.org, stummala@codeaurora.org,
	venkatg@codeaurora.org, jeremymc@redhat.com,
	bjorn.andersson@linaro.org, riteshh@codeaurora.org,
	dianders@google.com, sayalil@codeaurora.org
Subject: Re: [PATCH V3 0/4] Changes for SDCC5 version
Date: Tue, 25 Sep 2018 16:47:26 +0530	[thread overview]
Message-ID: <bcdeaf0c-fb04-67f5-8580-a3f5110bcba5@codeaurora.org> (raw)
In-Reply-To: <20180924194412.GA27477@arch>

On 9/25/2018 1:18 AM, Craig Tatlor wrote:
> What socs have you tested this on?
> On sdm660 it seems to crash device
> when writing pwr ctl.

Hi
We have tested this on SDM845.
SDM660 also has SDCC5 controller, so you would need to define
"qcom,sdhci-msm-v5" in your platform dt.
Can you confirm if you have defined this?

BTW, can you please share few details of the platform that you are checking?
We are not aware of any dev platform based on SDM660. This is just for 
my info.

> On Tue, Jun 19, 2018 at 11:09:17AM +0530, Vijay Viswanath wrote:
>> With SDCC5, the MCI register space got removed and the offset/order of
>> several registers have changed. Based on SDCC version used and the register,
>> we need to pick the base address and offset.
>>
>> Depends on patch series: "[PATCH V5 0/2] mmc: sdhci-msm: Configuring IO_PAD support for sdhci-msm"
>>
>> Changes since RFC:
>> 	Dropped voltage regulator changes in sdhci-msm
>> 	Split the "Register changes for sdcc V5" patch
>> 	Instead of checking mci removal for deciding which base addr to use,
>> 	new function pointers are defined for the 2 variants of sdcc:
>> 		1) MCI present
>> 		2) V5 (mci removed)
>> 	Instead of string comparing with the compatible string from DT file,
>> 	the sdhci_msm_probe will now pick the data associated with the
>> 	compatible entry and use it to load variant specific address offsets
>> 	and msm variant specific read/write ops.
>>
>> Changes since V1:
>> 	Removed unused msm_reab & msm_writeb APIs
>> 	Changed certain register addresses from uppercase to lowercase hex
>> 	letters
>> 	Removed extra lines and spaces
>> 	Split "[PATCH V1 0/3] Changes for SDCC5 version" patch into two,
>> 	one for Documentation and other for the driver changes.
>>
>> Changes since V2:
>> 	Used lower case for macro function defenitions
>> 	Removed unused function pointers for msm_readb & msm_writeb
>>
>>
>> Sayali Lokhande (3):
>>    mmc: sdhci-msm: Define new Register address map
>>    Documentation: sdhci-msm: Add new compatible string for SDCC v5
>>    mmc: host: Register changes for sdcc V5
>>
>> Vijay Viswanath (1):
>>    mmc: sdhci-msm: Add msm version specific ops and data structures
>>
>>   .../devicetree/bindings/mmc/sdhci-msm.txt          |   7 +-
>>   drivers/mmc/host/sdhci-msm.c                       | 511 ++++++++++++++++-----
>>   2 files changed, 391 insertions(+), 127 deletions(-)
>>
>> -- 
>>   Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks,
Veera