From: Eric Auger <eauger@redhat.com>
To: Gavin Shan <gshan@redhat.com>, kvmarm@lists.cs.columbia.edu
Cc: maz@kernel.org, linux-kernel@vger.kernel.org,
Jonathan.Cameron@huawei.com, pbonzini@redhat.com,
will@kernel.org
Subject: Re: [PATCH v4 13/21] KVM: arm64: Impment SDEI event delivery
Date: Wed, 10 Nov 2021 11:58:57 +0100 [thread overview]
Message-ID: <74c5f170-fb08-56a7-ff87-9a51ecfda989@redhat.com> (raw)
In-Reply-To: <20210815001352.81927-14-gshan@redhat.com>
s/Impment/Implement in the commit title
On 8/15/21 2:13 AM, Gavin Shan wrote:
> This implement kvm_sdei_deliver() to support SDEI event delivery.
> The function is called when the request (KVM_REQ_SDEI) is raised.
> The following rules are taken according to the SDEI specification:
>
> * x0 - x17 are saved. All of them are cleared except the following
> registered:
s/registered/registers
> x0: number SDEI event to be delivered
s/number SDEI event/SDEI event number
> x1: parameter associated with the SDEI event
user arg?
> x2: PC of the interrupted context
> x3: PState of the interrupted context
>
> * PC is set to the handler of the SDEI event, which was provided
> during its registration. PState is modified accordingly.
>
> * SDEI event with critical priority can preempt those with normal
> priority.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> arch/arm64/include/asm/kvm_host.h | 1 +
> arch/arm64/include/asm/kvm_sdei.h | 1 +
> arch/arm64/kvm/arm.c | 3 ++
> arch/arm64/kvm/sdei.c | 84 +++++++++++++++++++++++++++++++
> 4 files changed, 89 insertions(+)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index aedf901e1ec7..46f363aa6524 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -47,6 +47,7 @@
> #define KVM_REQ_RECORD_STEAL KVM_ARCH_REQ(3)
> #define KVM_REQ_RELOAD_GICv4 KVM_ARCH_REQ(4)
> #define KVM_REQ_RELOAD_PMU KVM_ARCH_REQ(5)
> +#define KVM_REQ_SDEI KVM_ARCH_REQ(6)
>
> #define KVM_DIRTY_LOG_MANUAL_CAPS (KVM_DIRTY_LOG_MANUAL_PROTECT_ENABLE | \
> KVM_DIRTY_LOG_INITIALLY_SET)
> diff --git a/arch/arm64/include/asm/kvm_sdei.h b/arch/arm64/include/asm/kvm_sdei.h
> index b0abc13a0256..7f5f5ad689e6 100644
> --- a/arch/arm64/include/asm/kvm_sdei.h
> +++ b/arch/arm64/include/asm/kvm_sdei.h
> @@ -112,6 +112,7 @@ KVM_SDEI_FLAG_FUNC(enabled)
> void kvm_sdei_init_vm(struct kvm *kvm);
> void kvm_sdei_create_vcpu(struct kvm_vcpu *vcpu);
> int kvm_sdei_hypercall(struct kvm_vcpu *vcpu);
> +void kvm_sdei_deliver(struct kvm_vcpu *vcpu);
> void kvm_sdei_destroy_vcpu(struct kvm_vcpu *vcpu);
> void kvm_sdei_destroy_vm(struct kvm *kvm);
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index 2f021aa41632..0c3db1ef1ba9 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -689,6 +689,9 @@ static void check_vcpu_requests(struct kvm_vcpu *vcpu)
> if (kvm_check_request(KVM_REQ_VCPU_RESET, vcpu))
> kvm_reset_vcpu(vcpu);
>
> + if (kvm_check_request(KVM_REQ_SDEI, vcpu))
> + kvm_sdei_deliver(vcpu);
> +
> /*
> * Clear IRQ_PENDING requests that were made to guarantee
> * that a VCPU sees new virtual interrupts.
> diff --git a/arch/arm64/kvm/sdei.c b/arch/arm64/kvm/sdei.c
> index 62efee2b67b8..b5d6d1ed3858 100644
> --- a/arch/arm64/kvm/sdei.c
> +++ b/arch/arm64/kvm/sdei.c
> @@ -671,6 +671,90 @@ int kvm_sdei_hypercall(struct kvm_vcpu *vcpu)
> return 1;
> }
>
> +void kvm_sdei_deliver(struct kvm_vcpu *vcpu)
> +{
> + struct kvm *kvm = vcpu->kvm;
> + struct kvm_sdei_kvm *ksdei = kvm->arch.sdei;
> + struct kvm_sdei_vcpu *vsdei = vcpu->arch.sdei;
> + struct kvm_sdei_event *kse = NULL;
> + struct kvm_sdei_kvm_event *kske = NULL;
> + struct kvm_sdei_vcpu_event *ksve = NULL;
> + struct kvm_sdei_vcpu_regs *regs = NULL;
> + unsigned long pstate;
> + int index = 0;
> +
> + /* Sanity check */
> + if (!(ksdei && vsdei))
> + return;
> +
> + /* The critical event can't be preempted */
move the comment after the spin_lock
> + spin_lock(&vsdei->lock);
> + if (vsdei->critical_event)
> + goto unlock;
> +
> + /*
> + * The normal event can be preempted by the critical event.
> + * However, the normal event can't be preempted by another
> + * normal event.
> + */
> + ksve = list_first_entry_or_null(&vsdei->critical_events,
> + struct kvm_sdei_vcpu_event, link);
> + if (!ksve && !vsdei->normal_event) {
> + ksve = list_first_entry_or_null(&vsdei->normal_events,
> + struct kvm_sdei_vcpu_event, link);
> + }
At this stage of the review the struct kvm_sdei_vcpu_event lifecycle is
not known.
From the dispatcher pseudocode I understand you check
((IsCriticalEvent(E) and !CriticalEventRunning(P, C)) ||
(!IsCriticalEvent(E) and !EventRunning(P, C)))
but I can't check you take care of
IsEnabled(E) and
IsEventTarget(E, P)
IsUnmasked(P)
Either you should shash with 18/21 or at least you should add comments.
> +
> + if (!ksve)
> + goto unlock;
> +
> + kske = ksve->kske;
> + kse = kske->kse;
> + if (kse->state.priority == SDEI_EVENT_PRIORITY_CRITICAL) {
> + vsdei->critical_event = ksve;
> + vsdei->state.critical_num = ksve->state.num;
> + regs = &vsdei->state.critical_regs;
> + } else {
> + vsdei->normal_event = ksve;
> + vsdei->state.normal_num = ksve->state.num;
> + regs = &vsdei->state.normal_regs;
> + }
> +
> + /* Save registers: x0 -> x17, PC, PState */
> + for (index = 0; index < ARRAY_SIZE(regs->regs); index++)
> + regs->regs[index] = vcpu_get_reg(vcpu, index);
> +
> + regs->pc = *vcpu_pc(vcpu);
> + regs->pstate = *vcpu_cpsr(vcpu);
> +
> + /*
> + * Inject SDEI event: x0 -> x3, PC, PState. We needn't take lock
> + * for the KVM event as it can't be destroyed because of its
> + * reference count.
> + */
> + for (index = 0; index < ARRAY_SIZE(regs->regs); index++)
> + vcpu_set_reg(vcpu, index, 0);
> +
> + index = (kse->state.type == SDEI_EVENT_TYPE_PRIVATE) ?
> + vcpu->vcpu_idx : 0;
> + vcpu_set_reg(vcpu, 0, kske->state.num);
> + vcpu_set_reg(vcpu, 1, kske->state.params[index]);
> + vcpu_set_reg(vcpu, 2, regs->pc);
> + vcpu_set_reg(vcpu, 3, regs->pstate);
> +
> + pstate = regs->pstate;
> + pstate |= (PSR_D_BIT | PSR_A_BIT | PSR_I_BIT | PSR_F_BIT);
> + pstate &= ~PSR_MODE_MASK;
> + pstate |= PSR_MODE_EL1h;
> + pstate &= ~PSR_MODE32_BIT;
> +
> + vcpu_write_sys_reg(vcpu, regs->pstate, SPSR_EL1);
> + *vcpu_cpsr(vcpu) = pstate;
> + *vcpu_pc(vcpu) = kske->state.entries[index];
> +
> +unlock:
> + spin_unlock(&vsdei->lock);
> +}
> +
> void kvm_sdei_init_vm(struct kvm *kvm)
> {
> struct kvm_sdei_kvm *ksdei;
>
Eric
next prev parent reply other threads:[~2021-11-10 10:59 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 0:13 [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan
2021-08-15 0:13 ` [PATCH v4 01/21] KVM: arm64: Introduce template for inline functions Gavin Shan
2021-11-09 15:26 ` Eric Auger
2022-01-11 7:52 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure Gavin Shan
2021-11-09 15:45 ` Eric Auger
2022-01-11 9:20 ` Gavin Shan
2022-01-27 13:17 ` Eric Auger
2022-01-11 9:40 ` Shannon Zhao
2022-01-13 7:09 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 03/21] KVM: arm64: Support SDEI_VERSION hypercall Gavin Shan
2021-11-09 15:26 ` Eric Auger
2022-01-11 9:25 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 04/21] KVM: arm64: Support SDEI_EVENT_REGISTER hypercall Gavin Shan
2021-11-09 15:50 ` Eric Auger
2022-01-12 2:19 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 05/21] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} hypercall Gavin Shan
2021-11-09 16:02 ` Eric Auger
2022-01-12 2:29 ` Gavin Shan
2022-01-25 18:23 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Gavin Shan
2021-11-10 11:16 ` Eric Auger
2022-01-12 2:33 ` Gavin Shan
2022-01-25 18:29 ` Eric Auger
2022-01-11 9:43 ` Shannon Zhao
2022-01-13 7:02 ` Gavin Shan
2022-01-13 7:13 ` Gavin Shan
2022-01-25 18:32 ` Eric Auger
2022-01-25 18:31 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 07/21] KVM: arm64: Support SDEI_EVENT_UNREGISTER hypercall Gavin Shan
2021-11-09 17:05 ` Eric Auger
2022-01-12 2:38 ` Gavin Shan
2022-01-25 18:42 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 08/21] KVM: arm64: Support SDEI_EVENT_STATUS hypercall Gavin Shan
2021-11-09 17:12 ` Eric Auger
2022-01-12 2:40 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 09/21] KVM: arm64: Support SDEI_EVENT_GET_INFO hypercall Gavin Shan
2021-11-09 17:19 ` Eric Auger
2022-01-12 2:46 ` Gavin Shan
2022-01-27 14:19 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 10/21] KVM: arm64: Support SDEI_EVENT_ROUTING_SET hypercall Gavin Shan
2021-11-09 18:47 ` Eric Auger
2022-01-12 2:54 ` Gavin Shan
2022-01-27 14:13 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 11/21] KVM: arm64: Support SDEI_PE_{MASK, UNMASK} hypercall Gavin Shan
2021-11-09 20:31 ` Eric Auger
2022-01-12 2:58 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 12/21] KVM: arm64: Support SDEI_{PRIVATE, SHARED}_RESET hypercall Gavin Shan
2021-11-09 20:37 ` Eric Auger
2022-01-12 3:01 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 13/21] KVM: arm64: Impment SDEI event delivery Gavin Shan
2021-11-10 10:58 ` Eric Auger [this message]
2022-01-12 6:34 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 14/21] KVM: arm64: Support SDEI_EVENT_{COMPLETE, COMPLETE_AND_RESUME} hypercall Gavin Shan
2021-11-10 10:58 ` Eric Auger
2022-01-12 6:43 ` Gavin Shan
2022-01-27 14:47 ` Eric Auger
2022-01-27 15:20 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 15/21] KVM: arm64: Support SDEI event notifier Gavin Shan
2021-11-10 11:35 ` Eric Auger
2022-01-12 6:48 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 16/21] KVM: arm64: Support SDEI ioctl commands on VM Gavin Shan
2021-11-10 13:48 ` Eric Auger
2022-01-12 7:03 ` Gavin Shan
2022-01-27 13:48 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 17/21] KVM: arm64: Support SDEI ioctl commands on vCPU Gavin Shan
2021-08-15 0:13 ` [PATCH v4 18/21] KVM: arm64: Support SDEI event injection Gavin Shan
2021-11-10 14:05 ` Eric Auger
2022-01-12 7:12 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 19/21] KVM: arm64: Support SDEI event cancellation Gavin Shan
2021-11-10 14:09 ` Eric Auger
2022-01-12 7:19 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 20/21] KVM: arm64: Export SDEI capability Gavin Shan
2021-11-10 13:55 ` Eric Auger
2022-01-12 7:20 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 21/21] KVM: selftests: Add SDEI test case Gavin Shan
2021-08-15 0:19 ` [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan
2021-11-10 14:29 ` Eric Auger
2022-01-12 7:24 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74c5f170-fb08-56a7-ff87-9a51ecfda989@redhat.com \
--to=eauger@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).