From: Gavin Shan <gshan@redhat.com>
To: Eric Auger <eauger@redhat.com>, kvmarm@lists.cs.columbia.edu
Cc: maz@kernel.org, linux-kernel@vger.kernel.org,
Jonathan.Cameron@huawei.com, pbonzini@redhat.com,
will@kernel.org
Subject: Re: [PATCH v4 01/21] KVM: arm64: Introduce template for inline functions
Date: Tue, 11 Jan 2022 15:52:44 +0800 [thread overview]
Message-ID: <8b7d3a75-dbf8-c8b9-bbb6-bd89d9429802@redhat.com> (raw)
In-Reply-To: <5112b3ba-d038-f622-c67f-e53695cbef37@redhat.com>
Hi Eric,
On 11/9/21 11:26 PM, Eric Auger wrote:
> On 8/15/21 2:13 AM, Gavin Shan wrote:
>> The inline functions used to get the SMCCC parameters have same
>> layout. It means these functions can be presented by a template,
>> to make the code simplified. Besides, this adds more similar inline
>> functions like smccc_get_arg{4,5,6,7,8}() to visit more SMCCC arguments,
>> which are needed by SDEI virtualization support.
>>
>> Signed-off-by: Gavin Shan <gshan@redhat.com>
>> ---
>> include/kvm/arm_hypercalls.h | 34 +++++++++++++++-------------------
>> 1 file changed, 15 insertions(+), 19 deletions(-)
>>
>> diff --git a/include/kvm/arm_hypercalls.h b/include/kvm/arm_hypercalls.h
>> index 0e2509d27910..ebecb6c68254 100644
>> --- a/include/kvm/arm_hypercalls.h
>> +++ b/include/kvm/arm_hypercalls.h
>> @@ -6,27 +6,21 @@
>>
>> #include <asm/kvm_emulate.h>
>>
>> -int kvm_hvc_call_handler(struct kvm_vcpu *vcpu);
>> -
>> -static inline u32 smccc_get_function(struct kvm_vcpu *vcpu)
>> -{
>> - return vcpu_get_reg(vcpu, 0);
>> +#define SMCCC_DECLARE_GET_FUNC(type, name, reg) \
>> +static inline type smccc_get_##name(struct kvm_vcpu *vcpu) \
>> +{ \
>> + return vcpu_get_reg(vcpu, reg); \
>> }
>>
>> -static inline unsigned long smccc_get_arg1(struct kvm_vcpu *vcpu)
>> -{
>> - return vcpu_get_reg(vcpu, 1);
>> -}
>> -
>> -static inline unsigned long smccc_get_arg2(struct kvm_vcpu *vcpu)
>> -{
>> - return vcpu_get_reg(vcpu, 2);
>> -}
>> -
>> -static inline unsigned long smccc_get_arg3(struct kvm_vcpu *vcpu)
>> -{
>> - return vcpu_get_reg(vcpu, 3);
>> -}
>> +SMCCC_DECLARE_GET_FUNC(u32, function, 0)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg1, 1)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg2, 2)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg3, 3)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg4, 4)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg5, 5)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg6, 6)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg7, 7)
>> +SMCCC_DECLARE_GET_FUNC(unsigned long, arg8, 8)
> I think I would keep smccc_get_function() and add macros to get the
> 64-bit args. SMCCC_DECLARE_GET_FUNC is an odd macro name for a function
> fetching an arg. I would suggest:
>
I agree. The code will be changed accordingly in next respin.
>> +#define SMCCC_DECLARE_GET_ARG(reg) \
>> +static inline unsigned long smccc_get_arg##reg(struct kvm_vcpu *vcpu) \
>> +{ \
>> + return vcpu_get_reg(vcpu, reg); \
>> }
>>
>> static inline void smccc_set_retval(struct kvm_vcpu *vcpu,
>> unsigned long a0,
>> @@ -40,4 +34,6 @@ static inline void smccc_set_retval(struct kvm_vcpu *vcpu,
>> vcpu_set_reg(vcpu, 3, a3);
>> }
>>
>> +int kvm_hvc_call_handler(struct kvm_vcpu *vcpu);
>> +
> spurious change?
I thought the inline function would come before the exposed ones. However,
I don't think it's necessary. I will drop the changes in next respin.
>> #endif
>>
Thanks,
Gavin
next prev parent reply other threads:[~2022-01-11 7:53 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 0:13 [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan
2021-08-15 0:13 ` [PATCH v4 01/21] KVM: arm64: Introduce template for inline functions Gavin Shan
2021-11-09 15:26 ` Eric Auger
2022-01-11 7:52 ` Gavin Shan [this message]
2021-08-15 0:13 ` [PATCH v4 02/21] KVM: arm64: Add SDEI virtualization infrastructure Gavin Shan
2021-11-09 15:45 ` Eric Auger
2022-01-11 9:20 ` Gavin Shan
2022-01-27 13:17 ` Eric Auger
2022-01-11 9:40 ` Shannon Zhao
2022-01-13 7:09 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 03/21] KVM: arm64: Support SDEI_VERSION hypercall Gavin Shan
2021-11-09 15:26 ` Eric Auger
2022-01-11 9:25 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 04/21] KVM: arm64: Support SDEI_EVENT_REGISTER hypercall Gavin Shan
2021-11-09 15:50 ` Eric Auger
2022-01-12 2:19 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 05/21] KVM: arm64: Support SDEI_EVENT_{ENABLE, DISABLE} hypercall Gavin Shan
2021-11-09 16:02 ` Eric Auger
2022-01-12 2:29 ` Gavin Shan
2022-01-25 18:23 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 06/21] KVM: arm64: Support SDEI_EVENT_CONTEXT hypercall Gavin Shan
2021-11-10 11:16 ` Eric Auger
2022-01-12 2:33 ` Gavin Shan
2022-01-25 18:29 ` Eric Auger
2022-01-11 9:43 ` Shannon Zhao
2022-01-13 7:02 ` Gavin Shan
2022-01-13 7:13 ` Gavin Shan
2022-01-25 18:32 ` Eric Auger
2022-01-25 18:31 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 07/21] KVM: arm64: Support SDEI_EVENT_UNREGISTER hypercall Gavin Shan
2021-11-09 17:05 ` Eric Auger
2022-01-12 2:38 ` Gavin Shan
2022-01-25 18:42 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 08/21] KVM: arm64: Support SDEI_EVENT_STATUS hypercall Gavin Shan
2021-11-09 17:12 ` Eric Auger
2022-01-12 2:40 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 09/21] KVM: arm64: Support SDEI_EVENT_GET_INFO hypercall Gavin Shan
2021-11-09 17:19 ` Eric Auger
2022-01-12 2:46 ` Gavin Shan
2022-01-27 14:19 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 10/21] KVM: arm64: Support SDEI_EVENT_ROUTING_SET hypercall Gavin Shan
2021-11-09 18:47 ` Eric Auger
2022-01-12 2:54 ` Gavin Shan
2022-01-27 14:13 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 11/21] KVM: arm64: Support SDEI_PE_{MASK, UNMASK} hypercall Gavin Shan
2021-11-09 20:31 ` Eric Auger
2022-01-12 2:58 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 12/21] KVM: arm64: Support SDEI_{PRIVATE, SHARED}_RESET hypercall Gavin Shan
2021-11-09 20:37 ` Eric Auger
2022-01-12 3:01 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 13/21] KVM: arm64: Impment SDEI event delivery Gavin Shan
2021-11-10 10:58 ` Eric Auger
2022-01-12 6:34 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 14/21] KVM: arm64: Support SDEI_EVENT_{COMPLETE, COMPLETE_AND_RESUME} hypercall Gavin Shan
2021-11-10 10:58 ` Eric Auger
2022-01-12 6:43 ` Gavin Shan
2022-01-27 14:47 ` Eric Auger
2022-01-27 15:20 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 15/21] KVM: arm64: Support SDEI event notifier Gavin Shan
2021-11-10 11:35 ` Eric Auger
2022-01-12 6:48 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 16/21] KVM: arm64: Support SDEI ioctl commands on VM Gavin Shan
2021-11-10 13:48 ` Eric Auger
2022-01-12 7:03 ` Gavin Shan
2022-01-27 13:48 ` Eric Auger
2021-08-15 0:13 ` [PATCH v4 17/21] KVM: arm64: Support SDEI ioctl commands on vCPU Gavin Shan
2021-08-15 0:13 ` [PATCH v4 18/21] KVM: arm64: Support SDEI event injection Gavin Shan
2021-11-10 14:05 ` Eric Auger
2022-01-12 7:12 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 19/21] KVM: arm64: Support SDEI event cancellation Gavin Shan
2021-11-10 14:09 ` Eric Auger
2022-01-12 7:19 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 20/21] KVM: arm64: Export SDEI capability Gavin Shan
2021-11-10 13:55 ` Eric Auger
2022-01-12 7:20 ` Gavin Shan
2021-08-15 0:13 ` [PATCH v4 21/21] KVM: selftests: Add SDEI test case Gavin Shan
2021-08-15 0:19 ` [PATCH v4 00/21] Support SDEI Virtualization Gavin Shan
2021-11-10 14:29 ` Eric Auger
2022-01-12 7:24 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b7d3a75-dbf8-c8b9-bbb6-bd89d9429802@redhat.com \
--to=gshan@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=eauger@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pbonzini@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).