From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Adam Ford <aford173@gmail.com>, Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Adam Ford-BE <aford@beaconembedded.com>,
Haibo Chen <haibo.chen@nxp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/5] arm64: dts: imx8mp: Enable HS400-ES
Date: Mon, 28 Mar 2022 13:09:25 +0200 [thread overview]
Message-ID: <74e74ea8-1554-bf08-b0ea-36e77259cb18@pengutronix.de> (raw)
In-Reply-To: <CAHCN7xL05pBK0uK7zuE7Uq4P9Rzo6bHbJdbOt5XnQRB7Sh3msw@mail.gmail.com>
Hello Adam,
On 28.03.22 12:47, Adam Ford wrote:
> On Mon, Mar 28, 2022 at 2:20 AM Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
>>
>> Hello Adam,
>>
>> On 27.03.22 14:38, Adam Ford wrote:
>>> The SDHC controller in the imx8mp has the same controller
>>> as the imx8mm which supports HS400-ES. Change the compatible
>>> fallback to imx8mm to enable it.
>>
>> I believe that's a shortcoming of the Linux driver, which should explicitly list
>> fsl,imx8mp-usdhc in its compatibles and enable HS400-ES for it.
>>
>> I find dropping compatibles problematic, because like Linux matching
>> fsl,imx8mm-usdhc, but not fsl,imx8mp-usdhc, other software may match
>> fsl,imx7d-usdhc, but not fsl,imx8[mp]-usdhc.
>>
>> I'd prefer that either the kernel driver gains extra compatibles or that
>> the DTS lists extra compatibles and we refrain from dropping existing
>> (correct) ones.
>>
>
> I would argue that imx7d is not correct since the IP blocks between
> imx7d and imx8mm have different flags/quirks. One of which includes
> HS400-ES, but there are other differences as well.
The DTS currently says that an fsl,imx7d-usdhc is a subset of an
fsl,imx8mm-usdhc. So a driver could treat both HW the exact same
by focusing on the i.MX7D parts. Linux apparently did exactly
that so far. Is this not accurate?
>> What do you think?
>
> From my understanding of the fallback compatibility strings is to
> avoid having to add more and more compatible strings to the drivers
> when they do not serve a functional purpose. Based On a conversation
> with Krzysztof [1], he suggested we update the YAML file based on the
> fallback, but he wanted NXP to give their feedback as to what the
> right fallback strings should be. Haibo from NXP sent me a hierarchy
> [1] which is what I used to update the YAML file. Based on the YAML
> file, the fallback in each DTSI file was updated to ensure the use of
> the proper IP block.
Myself I am in favor of moving to three compatibles instead of dropping one.
For some theoretical fsl,imx8mf-usdhc that's supposed to be exactly the same
as a fsl,imx8mm-usdhc, I don't mind omitting the fsl,imx7d-usdhc compatible,
but for existing device trees, this may introduce needless potential breakage
for other software that also uses Linux device trees.
Cheers,
Ahmad
>
> adam
>
> [1] - https://lore.kernel.org/linux-arm-kernel/CAHCN7xLWoUGi-jfxR2a0gvEFkPT3USUEb+8U3CCqCb5wWEJ8xw@mail.gmail.com/T/
>
>>
>> Cheers,
>> Ahmad
>>
>>> Signed-off-by: Adam Ford <aford173@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> index 794d75173cf5..d5ee1520f1fe 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
>>> @@ -769,7 +769,7 @@ i2c6: i2c@30ae0000 {
>>> };
>>>
>>> usdhc1: mmc@30b40000 {
>>> - compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
>>> + compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc";
>>> reg = <0x30b40000 0x10000>;
>>> interrupts = <GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>;
>>> clocks = <&clk IMX8MP_CLK_DUMMY>,
>>> @@ -783,7 +783,7 @@ usdhc1: mmc@30b40000 {
>>> };
>>>
>>> usdhc2: mmc@30b50000 {
>>> - compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
>>> + compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc";
>>> reg = <0x30b50000 0x10000>;
>>> interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>>> clocks = <&clk IMX8MP_CLK_DUMMY>,
>>> @@ -797,7 +797,7 @@ usdhc2: mmc@30b50000 {
>>> };
>>>
>>> usdhc3: mmc@30b60000 {
>>> - compatible = "fsl,imx8mp-usdhc", "fsl,imx7d-usdhc";
>>> + compatible = "fsl,imx8mp-usdhc", "fsl,imx8mm-usdhc";
>>> reg = <0x30b60000 0x10000>;
>>> interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>;
>>> clocks = <&clk IMX8MP_CLK_DUMMY>,
>>
>>
>> --
>> Pengutronix e.K. | |
>> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
>> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
>> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2022-03-28 11:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 12:38 [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
2022-03-27 12:38 ` [PATCH 2/5] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
2022-03-27 12:38 ` [PATCH 3/5] arm64: dts: imx8mp: " Adam Ford
2022-03-28 7:20 ` Ahmad Fatoum
2022-03-28 10:47 ` Adam Ford
2022-03-28 11:09 ` Ahmad Fatoum [this message]
2022-03-28 11:49 ` Krzysztof Kozlowski
2022-03-28 12:45 ` Adam Ford
2022-03-28 12:56 ` Krzysztof Kozlowski
2022-03-28 13:06 ` Adam Ford
2022-03-28 13:12 ` Ahmad Fatoum
2022-03-28 13:15 ` Krzysztof Kozlowski
2022-03-28 13:17 ` Krzysztof Kozlowski
2022-03-28 13:07 ` Ahmad Fatoum
2022-03-28 13:14 ` Krzysztof Kozlowski
2022-03-28 13:42 ` Ahmad Fatoum
2022-03-28 17:35 ` Krzysztof Kozlowski
2022-03-27 12:38 ` [PATCH 4/5] arm64: dts: imx8qxp: Remove imx7d-usdhc compatible fallback Adam Ford
2022-03-27 12:38 ` [PATCH 5/5] arm64: dts: imx8qm: Remove fsl,imx7d-usdhc " Adam Ford
2022-03-27 19:26 ` [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Krzysztof Kozlowski
2022-03-31 13:04 ` Ulf Hansson
2022-03-31 16:00 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74e74ea8-1554-bf08-b0ea-36e77259cb18@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).