From: Krzysztof Kozlowski <krzk@kernel.org>
To: Adam Ford <aford173@gmail.com>, linux-mmc@vger.kernel.org
Cc: haibo.chen@nxp.com, aford@beaconembedded.com,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks
Date: Sun, 27 Mar 2022 21:26:20 +0200 [thread overview]
Message-ID: <aaed94ae-047d-b16c-3d9b-7e431a212b82@kernel.org> (raw)
In-Reply-To: <20220327123835.28329-1-aford173@gmail.com>
On 27/03/2022 14:38, Adam Ford wrote:
> The SDHC controller in the imx8mn and imx8mp have the same controller
> as the imx8mm which is slightly different than that of the imx7d.
> Using the fallback of the imx8mm enables the controllers to support
> HS400-ES which is not available on the imx7d. After discussion with NXP,
> it turns out that the imx8qm should fall back to the imx8qxp, because
> those have some additional flags not present in the imx8mm.
>
> Suggested-by: haibo.chen@nxp.com
> Signed-off-by: Adam Ford <aford173@gmail.com>
> ---
> V2: Added suggested-by note and imx8qxp updates.
> ---
> .../devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
YAML and logic looks good, although I did not check the actual hardware
properties.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-27 19:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 12:38 [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Adam Ford
2022-03-27 12:38 ` [PATCH 2/5] arm64: dts: imx8mn: Enable HS400-ES Adam Ford
2022-03-27 12:38 ` [PATCH 3/5] arm64: dts: imx8mp: " Adam Ford
2022-03-28 7:20 ` Ahmad Fatoum
2022-03-28 10:47 ` Adam Ford
2022-03-28 11:09 ` Ahmad Fatoum
2022-03-28 11:49 ` Krzysztof Kozlowski
2022-03-28 12:45 ` Adam Ford
2022-03-28 12:56 ` Krzysztof Kozlowski
2022-03-28 13:06 ` Adam Ford
2022-03-28 13:12 ` Ahmad Fatoum
2022-03-28 13:15 ` Krzysztof Kozlowski
2022-03-28 13:17 ` Krzysztof Kozlowski
2022-03-28 13:07 ` Ahmad Fatoum
2022-03-28 13:14 ` Krzysztof Kozlowski
2022-03-28 13:42 ` Ahmad Fatoum
2022-03-28 17:35 ` Krzysztof Kozlowski
2022-03-27 12:38 ` [PATCH 4/5] arm64: dts: imx8qxp: Remove imx7d-usdhc compatible fallback Adam Ford
2022-03-27 12:38 ` [PATCH 5/5] arm64: dts: imx8qm: Remove fsl,imx7d-usdhc " Adam Ford
2022-03-27 19:26 ` Krzysztof Kozlowski [this message]
2022-03-31 13:04 ` [PATCH 1/5] dt-bindings: mmc: imx-esdhc: Update compatible fallbacks Ulf Hansson
2022-03-31 16:00 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaed94ae-047d-b16c-3d9b-7e431a212b82@kernel.org \
--to=krzk@kernel.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).