linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* staging: rtl8712: dead code on flush_signals_thread call in r8712_cmd_thread()
@ 2021-07-02 13:04 Colin Ian King
  0 siblings, 0 replies; only message in thread
From: Colin Ian King @ 2021-07-02 13:04 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Larry Finger, Florian Schilhabel
  Cc: linux-staging, linux-kernel

Hi,

Static analysis by Coverity has detected a call to
flush_signals_thread() that is never executed.  If it is removed it
won't affect the current behavior, however I'm pretty sure the call was
intentionally placed in the code at the end of a while loop so I believe
there is something a little dubious with the current code.

The analysis by Coverity is as follows:

384                        goto _next;
385                }

Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: flush_signals_thread();.

386                flush_signals_thread();
387        }

Any ideas?

Colin

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-07-02 13:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 13:04 staging: rtl8712: dead code on flush_signals_thread call in r8712_cmd_thread() Colin Ian King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).