* [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes
@ 2020-12-29 3:47 Randy Dunlap
2020-12-29 23:47 ` Jens Axboe
2021-01-04 8:38 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-12-29 3:47 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Jens Axboe, Christoph Hellwig, linux-fsdevel,
Alexander Viro
Fix new kernel-doc warnings in fs/block_dev.c:
../fs/block_dev.c:1066: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'
../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not described in 'lookup_bdev'
Fixes: 4e7b5671c6a8 ("block: remove i_bdev")
Fixes: 37c3fc9abb25 ("block: simplify the block device claiming interface")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
---
fs/block_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-511-rc1.orig/fs/block_dev.c
+++ lnx-511-rc1/fs/block_dev.c
@@ -1055,7 +1055,6 @@ static void bd_finish_claiming(struct bl
/**
* bd_abort_claiming - abort claiming of a block device
* @bdev: block device of interest
- * @whole: whole block device
* @holder: holder that has claimed @bdev
*
* Abort claiming of a block device when the exclusive open failed. This can be
@@ -1828,6 +1827,7 @@ const struct file_operations def_blk_fop
/**
* lookup_bdev - lookup a struct block_device by name
* @pathname: special file representing the block device
+ * @dev: return value of the block device's dev_t
*
* Get a reference to the blockdevice at @pathname in the current
* namespace if possible and return it. Return ERR_PTR(error)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes
2020-12-29 3:47 [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes Randy Dunlap
@ 2020-12-29 23:47 ` Jens Axboe
2021-01-04 8:38 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2020-12-29 23:47 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Christoph Hellwig, linux-fsdevel, Alexander Viro
On 12/28/20 8:47 PM, Randy Dunlap wrote:
> Fix new kernel-doc warnings in fs/block_dev.c:
>
> ../fs/block_dev.c:1066: warning: Excess function parameter 'whole' description in 'bd_abort_claiming'
> ../fs/block_dev.c:1837: warning: Function parameter or member 'dev' not described in 'lookup_bdev'
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes
2020-12-29 3:47 [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes Randy Dunlap
2020-12-29 23:47 ` Jens Axboe
@ 2021-01-04 8:38 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-01-04 8:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, Jens Axboe, Christoph Hellwig, linux-fsdevel,
Alexander Viro
I sent two patches for that quite a while ago..
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-04 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-29 3:47 [PATCH] fs: block_dev.c: fix kernel-doc warnings from struct block_device changes Randy Dunlap
2020-12-29 23:47 ` Jens Axboe
2021-01-04 8:38 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).