From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Douglas Anderson <dianders@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b
Date: Wed, 05 Feb 2020 10:46:32 -0800 [thread overview]
Message-ID: <76267eda365d7c5c0adc7dd16681973c5378df8e.camel@perches.com> (raw)
In-Reply-To: <20200205152429.ejgx2on2z4hoycus@kili.mountain>
On Wed, 2020-02-05 at 18:24 +0300, Dan Carpenter wrote:
> The get_maintainer.pl script looks at git history to create the CC list,
> but unfortunately sometimes those email addresses are out of date. The
> script also looks at the MAINTAINERS file, of course, but if it already
> found an email address for a maintainer in the git history then the
> deduplicate_email() function will remove the second address.
>
> It should save the MAINTAINERS address first, before loading the commit
> signer addresses.
Yeah, thanks. This has been submitted already.
https://lore.kernel.org/patchwork/patch/1186249/
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> We will have to add a special case if the Dan Williamses ever decide
> to work on the same subsystem.
>
> scripts/get_maintainer.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 34085d146fa2..e5bdd3143a49 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -932,14 +932,14 @@ sub get_maintainers {
> }
> }
>
> - foreach my $fix (@fixes) {
> - vcs_add_commit_signers($fix, "blamed_fixes");
> - }
> -
> foreach my $email (@email_to, @list_to) {
> $email->[0] = deduplicate_email($email->[0]);
> }
>
> + foreach my $fix (@fixes) {
> + vcs_add_commit_signers($fix, "blamed_fixes");
> + }
> +
> foreach my $file (@files) {
> if ($email &&
> ($email_git || ($email_git_fallback &&
prev parent reply other threads:[~2020-02-05 18:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 15:24 [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b Dan Carpenter
2020-02-05 18:46 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76267eda365d7c5c0adc7dd16681973c5378df8e.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).