* [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b
@ 2020-02-05 15:24 Dan Carpenter
2020-02-05 18:46 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-02-05 15:24 UTC (permalink / raw)
To: Joe Perches, Greg Kroah-Hartman; +Cc: linux-kernel, kernel-janitors
The get_maintainer.pl script looks at git history to create the CC list,
but unfortunately sometimes those email addresses are out of date. The
script also looks at the MAINTAINERS file, of course, but if it already
found an email address for a maintainer in the git history then the
deduplicate_email() function will remove the second address.
It should save the MAINTAINERS address first, before loading the commit
signer addresses.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
We will have to add a special case if the Dan Williamses ever decide
to work on the same subsystem.
scripts/get_maintainer.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 34085d146fa2..e5bdd3143a49 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -932,14 +932,14 @@ sub get_maintainers {
}
}
- foreach my $fix (@fixes) {
- vcs_add_commit_signers($fix, "blamed_fixes");
- }
-
foreach my $email (@email_to, @list_to) {
$email->[0] = deduplicate_email($email->[0]);
}
+ foreach my $fix (@fixes) {
+ vcs_add_commit_signers($fix, "blamed_fixes");
+ }
+
foreach my $file (@files) {
if ($email &&
($email_git || ($email_git_fallback &&
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b
2020-02-05 15:24 [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b Dan Carpenter
@ 2020-02-05 18:46 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2020-02-05 18:46 UTC (permalink / raw)
To: Dan Carpenter, Greg Kroah-Hartman, Douglas Anderson, Andrew Morton
Cc: linux-kernel, kernel-janitors
On Wed, 2020-02-05 at 18:24 +0300, Dan Carpenter wrote:
> The get_maintainer.pl script looks at git history to create the CC list,
> but unfortunately sometimes those email addresses are out of date. The
> script also looks at the MAINTAINERS file, of course, but if it already
> found an email address for a maintainer in the git history then the
> deduplicate_email() function will remove the second address.
>
> It should save the MAINTAINERS address first, before loading the commit
> signer addresses.
Yeah, thanks. This has been submitted already.
https://lore.kernel.org/patchwork/patch/1186249/
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> We will have to add a special case if the Dan Williamses ever decide
> to work on the same subsystem.
>
> scripts/get_maintainer.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 34085d146fa2..e5bdd3143a49 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -932,14 +932,14 @@ sub get_maintainers {
> }
> }
>
> - foreach my $fix (@fixes) {
> - vcs_add_commit_signers($fix, "blamed_fixes");
> - }
> -
> foreach my $email (@email_to, @list_to) {
> $email->[0] = deduplicate_email($email->[0]);
> }
>
> + foreach my $fix (@fixes) {
> + vcs_add_commit_signers($fix, "blamed_fixes");
> + }
> +
> foreach my $file (@files) {
> if ($email &&
> ($email_git || ($email_git_fallback &&
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-05 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 15:24 [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b Dan Carpenter
2020-02-05 18:46 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).