* [PATCH] selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP
@ 2021-08-05 16:40 Jose Blanquicet
2021-08-05 17:05 ` Yonghong Song
2021-08-06 15:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Jose Blanquicet @ 2021-08-05 16:40 UTC (permalink / raw)
Cc: blanquicet, Jose Blanquicet, Shuah Khan, Alexei Starovoitov,
Daniel Borkmann, Andrii Nakryiko, Martin KaFai Lau, Song Liu,
Yonghong Song, John Fastabend, KP Singh, Florent Revest,
linux-kselftest, netdev, bpf, linux-kernel
Currently, this test is incorrectly printing the destination port
in place of the destination IP.
Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
---
tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c b/tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c
index 2e4775c35414..92267abb462f 100644
--- a/tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c
+++ b/tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c
@@ -121,7 +121,7 @@ static int dump_tcp_sock(struct seq_file *seq, struct tcp_sock *tp,
}
BPF_SEQ_PRINTF(seq, "%4d: %08X:%04X %08X:%04X ",
- seq_num, src, srcp, destp, destp);
+ seq_num, src, srcp, dest, destp);
BPF_SEQ_PRINTF(seq, "%02X %08X:%08X %02X:%08lX %08X %5u %8d %lu %d ",
state,
tp->write_seq - tp->snd_una, rx_queue,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP
2021-08-05 16:40 [PATCH] selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP Jose Blanquicet
@ 2021-08-05 17:05 ` Yonghong Song
2021-08-06 15:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2021-08-05 17:05 UTC (permalink / raw)
To: Jose Blanquicet
Cc: Jose Blanquicet, Shuah Khan, Alexei Starovoitov, Daniel Borkmann,
Andrii Nakryiko, Martin KaFai Lau, Song Liu, John Fastabend,
KP Singh, Florent Revest, linux-kselftest, netdev, bpf,
linux-kernel
On 8/5/21 9:40 AM, Jose Blanquicet wrote:
> Currently, this test is incorrectly printing the destination port
> in place of the destination IP.
>
> Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
Thanks for the fix! LGTM.
Acked-by: Yonghong Song <yhs@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP
2021-08-05 16:40 [PATCH] selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP Jose Blanquicet
2021-08-05 17:05 ` Yonghong Song
@ 2021-08-06 15:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-06 15:20 UTC (permalink / raw)
To: Jose Blanquicet
Cc: josebl, shuah, ast, daniel, andrii, kafai, songliubraving, yhs,
john.fastabend, kpsingh, revest, linux-kselftest, netdev, bpf,
linux-kernel
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Thu, 5 Aug 2021 18:40:36 +0200 you wrote:
> Currently, this test is incorrectly printing the destination port
> in place of the destination IP.
>
> Signed-off-by: Jose Blanquicet <josebl@microsoft.com>
> ---
> tools/testing/selftests/bpf/progs/bpf_iter_tcp4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP
https://git.kernel.org/bpf/bpf-next/c/277b13405703
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-06 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-05 16:40 [PATCH] selftests/bpf: Fix bpf-iter-tcp4 test to print correctly the dest IP Jose Blanquicet
2021-08-05 17:05 ` Yonghong Song
2021-08-06 15:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).