* [PATCH] irqchip/sifive-plic: Make struct irq_chip const
@ 2022-06-24 17:56 Lad Prabhakar
2022-08-11 16:53 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Lad Prabhakar @ 2022-06-24 17:56 UTC (permalink / raw)
To: Thomas Gleixner, Marc Zyngier, Palmer Dabbelt, Paul Walmsley,
linux-riscv
Cc: Geert Uytterhoeven, linux-renesas-soc, linux-kernel, Prabhakar,
Biju Das, Lad Prabhakar
These should be const, so make it so.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
drivers/irqchip/irq-sifive-plic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
index bb87e4c3b88e..173446cc9204 100644
--- a/drivers/irqchip/irq-sifive-plic.c
+++ b/drivers/irqchip/irq-sifive-plic.c
@@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
}
}
-static struct irq_chip plic_chip = {
+static const struct irq_chip plic_chip = {
.name = "SiFive PLIC",
.irq_mask = plic_irq_mask,
.irq_unmask = plic_irq_unmask,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/sifive-plic: Make struct irq_chip const
2022-06-24 17:56 [PATCH] irqchip/sifive-plic: Make struct irq_chip const Lad Prabhakar
@ 2022-08-11 16:53 ` Palmer Dabbelt
2022-08-11 17:19 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Palmer Dabbelt @ 2022-08-11 16:53 UTC (permalink / raw)
To: prabhakar.mahadev-lad.rj, Marc Zyngier
Cc: tglx, Paul Walmsley, linux-riscv, geert+renesas,
linux-renesas-soc, linux-kernel, prabhakar.csengg, biju.das.jz,
prabhakar.mahadev-lad.rj
On Fri, 24 Jun 2022 10:56:39 PDT (-0700), prabhakar.mahadev-lad.rj@bp.renesas.com wrote:
> These should be const, so make it so.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
> drivers/irqchip/irq-sifive-plic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c
> index bb87e4c3b88e..173446cc9204 100644
> --- a/drivers/irqchip/irq-sifive-plic.c
> +++ b/drivers/irqchip/irq-sifive-plic.c
> @@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
> }
> }
>
> -static struct irq_chip plic_chip = {
> +static const struct irq_chip plic_chip = {
> .name = "SiFive PLIC",
> .irq_mask = plic_irq_mask,
> .irq_unmask = plic_irq_unmask,
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
Not sure if this got picked up somewhere, but it looks fine to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/sifive-plic: Make struct irq_chip const
2022-08-11 16:53 ` Palmer Dabbelt
@ 2022-08-11 17:19 ` Marc Zyngier
0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2022-08-11 17:19 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: prabhakar.mahadev-lad.rj, tglx, Paul Walmsley, linux-riscv,
geert+renesas, linux-renesas-soc, linux-kernel, prabhakar.csengg,
biju.das.jz
On 2022-08-11 17:53, Palmer Dabbelt wrote:
> On Fri, 24 Jun 2022 10:56:39 PDT (-0700),
> prabhakar.mahadev-lad.rj@bp.renesas.com wrote:
>> These should be const, so make it so.
>>
>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>> ---
>> drivers/irqchip/irq-sifive-plic.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-sifive-plic.c
>> b/drivers/irqchip/irq-sifive-plic.c
>> index bb87e4c3b88e..173446cc9204 100644
>> --- a/drivers/irqchip/irq-sifive-plic.c
>> +++ b/drivers/irqchip/irq-sifive-plic.c
>> @@ -176,7 +176,7 @@ static void plic_irq_eoi(struct irq_data *d)
>> }
>> }
>>
>> -static struct irq_chip plic_chip = {
>> +static const struct irq_chip plic_chip = {
>> .name = "SiFive PLIC",
>> .irq_mask = plic_irq_mask,
>> .irq_unmask = plic_irq_unmask,
>
> Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com>
> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
>
> Not sure if this got picked up somewhere, but it looks fine to me.
It probably needs respinning (the PLIC code has evolved a bit since).
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-11 17:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-24 17:56 [PATCH] irqchip/sifive-plic: Make struct irq_chip const Lad Prabhakar
2022-08-11 16:53 ` Palmer Dabbelt
2022-08-11 17:19 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).