* [PATCH] pinctrl: da9062: Fix include path
@ 2020-03-17 4:54 Valdis Klētnieks
2020-03-17 21:10 ` Marco Felsch
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2020-03-17 4:54 UTC (permalink / raw)
To: Marco Felsch; +Cc: Support Opensource, Linus Walleij, linux-gpio, linux-kernel
Found during a allmodconfig build on ARM on an RPi4:
CC drivers/pinctrl/pinctrl-da9062.o
drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
#include <../gpio/gpiolib.h>
^~~~~~~~~~~~~~~~~~~
compilation terminated.
So... fix the errant include.
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Fixes: 56cc3af4e8c8e ("pinctrl: da9062: add driver support")
diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
index f704ee0b2fd9..cfbe529e66c3 100644
--- a/drivers/pinctrl/pinctrl-da9062.c
+++ b/drivers/pinctrl/pinctrl-da9062.c
@@ -25,7 +25,7 @@
* We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
* the gpio is active low without a vendor specific dt-binding.
*/
-#include <../gpio/gpiolib.h>
+#include <../drivers/gpio/gpiolib.h>
#define DA9062_TYPE(offset) (4 * (offset % 2))
#define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: da9062: Fix include path
2020-03-17 4:54 [PATCH] pinctrl: da9062: Fix include path Valdis Klētnieks
@ 2020-03-17 21:10 ` Marco Felsch
0 siblings, 0 replies; 2+ messages in thread
From: Marco Felsch @ 2020-03-17 21:10 UTC (permalink / raw)
To: Valdis Klētnieks
Cc: Support Opensource, Linus Walleij, linux-gpio, linux-kernel
Hi,
On 20-03-17 00:54, Valdis Klētnieks wrote:
> Found during a allmodconfig build on ARM on an RPi4:
>
> CC drivers/pinctrl/pinctrl-da9062.o
> drivers/pinctrl/pinctrl-da9062.c:28:10: fatal error: ../gpio/gpiolib.h: No such file or directory
> #include <../gpio/gpiolib.h>
> ^~~~~~~~~~~~~~~~~~~
> compilation terminated.
this should be fixed already:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/pinctrl/pinctrl-da9062.c?id=2353810dac9ab72d3f835e3fb015c6819a0ef6c2
Regards,
Marco
>
> So... fix the errant include.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
> Fixes: 56cc3af4e8c8e ("pinctrl: da9062: add driver support")
>
> diff --git a/drivers/pinctrl/pinctrl-da9062.c b/drivers/pinctrl/pinctrl-da9062.c
> index f704ee0b2fd9..cfbe529e66c3 100644
> --- a/drivers/pinctrl/pinctrl-da9062.c
> +++ b/drivers/pinctrl/pinctrl-da9062.c
> @@ -25,7 +25,7 @@
> * We need this get the gpio_desc from a <gpio_chip,offset> tuple to decide if
> * the gpio is active low without a vendor specific dt-binding.
> */
> -#include <../gpio/gpiolib.h>
> +#include <../drivers/gpio/gpiolib.h>
>
> #define DA9062_TYPE(offset) (4 * (offset % 2))
> #define DA9062_PIN_SHIFT(offset) (4 * (offset % 2))
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-17 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-17 4:54 [PATCH] pinctrl: da9062: Fix include path Valdis Klētnieks
2020-03-17 21:10 ` Marco Felsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).