* [PATCH] rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable
@ 2023-02-17 9:25 Jiapeng Chong
2023-02-20 9:17 ` Ping-Ke Shih
2023-02-22 12:30 ` wifi: " Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Jiapeng Chong @ 2023-02-17 9:25 UTC (permalink / raw)
To: pkshih
Cc: kvalo, davem, edumazet, kuba, pabeni, linux-wireless, netdev,
linux-kernel, Jiapeng Chong, Abaci Robot
Variable bcnfunc_enable is not effectively used, so delete it.
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:1050:5: warning: variable 'bcnfunc_enable' set but not used.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4110
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
index 2aecb2583f75..df1e36fbc348 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c
@@ -1047,7 +1047,6 @@ static int _rtl92de_set_media_status(struct ieee80211_hw *hw,
struct rtl_priv *rtlpriv = rtl_priv(hw);
u8 bt_msr = rtl_read_byte(rtlpriv, MSR);
enum led_ctl_mode ledaction = LED_CTL_NO_LINK;
- u8 bcnfunc_enable;
bt_msr &= 0xfc;
@@ -1064,31 +1063,26 @@ static int _rtl92de_set_media_status(struct ieee80211_hw *hw,
"Set HW_VAR_MEDIA_STATUS: No such media status(%x)\n",
type);
}
- bcnfunc_enable = rtl_read_byte(rtlpriv, REG_BCN_CTRL);
switch (type) {
case NL80211_IFTYPE_UNSPECIFIED:
bt_msr |= MSR_NOLINK;
ledaction = LED_CTL_LINK;
- bcnfunc_enable &= 0xF7;
rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
"Set Network type to NO LINK!\n");
break;
case NL80211_IFTYPE_ADHOC:
bt_msr |= MSR_ADHOC;
- bcnfunc_enable |= 0x08;
rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
"Set Network type to Ad Hoc!\n");
break;
case NL80211_IFTYPE_STATION:
bt_msr |= MSR_INFRA;
ledaction = LED_CTL_LINK;
- bcnfunc_enable &= 0xF7;
rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
"Set Network type to STA!\n");
break;
case NL80211_IFTYPE_AP:
bt_msr |= MSR_AP;
- bcnfunc_enable |= 0x08;
rtl_dbg(rtlpriv, COMP_INIT, DBG_TRACE,
"Set Network type to AP!\n");
break;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable
2023-02-17 9:25 [PATCH] rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable Jiapeng Chong
@ 2023-02-20 9:17 ` Ping-Ke Shih
2023-02-22 12:30 ` wifi: " Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Ping-Ke Shih @ 2023-02-20 9:17 UTC (permalink / raw)
To: Jiapeng Chong
Cc: kvalo, davem, edumazet, kuba, pabeni, linux-wireless, netdev,
linux-kernel, Abaci Robot
> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Friday, February 17, 2023 5:25 PM
> To: Ping-Ke Shih <pkshih@realtek.com>
> Cc: kvalo@kernel.org; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jiapeng Chong
> <jiapeng.chong@linux.alibaba.com>; Abaci Robot <abaci@linux.alibaba.com>
> Subject: [PATCH] rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable
>
> Variable bcnfunc_enable is not effectively used, so delete it.
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:1050:5: warning: variable 'bcnfunc_enable' set but
> not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4110
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
[...]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable
2023-02-17 9:25 [PATCH] rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable Jiapeng Chong
2023-02-20 9:17 ` Ping-Ke Shih
@ 2023-02-22 12:30 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-02-22 12:30 UTC (permalink / raw)
To: Jiapeng Chong
Cc: pkshih, davem, edumazet, kuba, pabeni, linux-wireless, netdev,
linux-kernel, Jiapeng Chong, Abaci Robot
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Variable bcnfunc_enable is not effectively used, so delete it.
>
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/hw.c:1050:5: warning: variable 'bcnfunc_enable' set but not used.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4110
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Patch applied to wireless-next.git, thanks.
db5e4b364553 wifi: rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230217092529.105899-1-jiapeng.chong@linux.alibaba.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-22 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-17 9:25 [PATCH] rtlwifi: rtl8192de: Remove the unused variable bcnfunc_enable Jiapeng Chong
2023-02-20 9:17 ` Ping-Ke Shih
2023-02-22 12:30 ` wifi: " Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).