linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] DT Fixes for OMAP5 boards
@ 2016-10-25 16:48 H. Nikolaus Schaller
  2016-10-25 16:48 ` [PATCH v2 1/2] dts: omap5: baord-common: add phandle to reference Palmas gpadc H. Nikolaus Schaller
  2016-10-25 16:48 ` [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection H. Nikolaus Schaller
  0 siblings, 2 replies; 7+ messages in thread
From: H. Nikolaus Schaller @ 2016-10-25 16:48 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Russell King
  Cc: ldewangan, linux-omap, devicetree, linux-kernel, marek, kernel,
	letux-kernel, H. Nikolaus Schaller

This patch series adds DT nodes for:
* twl6040 enable jack_detection (e.g. OMAP5EVM)
* twl6037 gpadc for omap5 based boards (e.g. OMAP5EVM)


H. Nikolaus Schaller (2):
  dts: omap5: baord-common: add phandle to reference Palmas gpadc
  dts: omap5: baord-common: enable twl6040 headset jack detection

 arch/arm/boot/dts/omap5-board-common.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.3

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2 1/2] dts: omap5: baord-common: add phandle to reference Palmas gpadc
  2016-10-25 16:48 [PATCH v2 0/2] DT Fixes for OMAP5 boards H. Nikolaus Schaller
@ 2016-10-25 16:48 ` H. Nikolaus Schaller
  2016-10-25 16:48 ` [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection H. Nikolaus Schaller
  1 sibling, 0 replies; 7+ messages in thread
From: H. Nikolaus Schaller @ 2016-10-25 16:48 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Russell King
  Cc: ldewangan, linux-omap, devicetree, linux-kernel, marek, kernel,
	letux-kernel, H. Nikolaus Schaller

Will be needed for iio based drivers.

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap5-board-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index 7500283..b04adee 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -415,7 +415,7 @@
 			ti,backup-battery-charge-high-current;
 		};
 
-		gpadc {
+		gpadc: gpadc {
 			compatible = "ti,palmas-gpadc";
 			interrupts = <18 0
 				      16 0
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection
  2016-10-25 16:48 [PATCH v2 0/2] DT Fixes for OMAP5 boards H. Nikolaus Schaller
  2016-10-25 16:48 ` [PATCH v2 1/2] dts: omap5: baord-common: add phandle to reference Palmas gpadc H. Nikolaus Schaller
@ 2016-10-25 16:48 ` H. Nikolaus Schaller
  2016-10-25 16:51   ` Peter Ujfalusi
  1 sibling, 1 reply; 7+ messages in thread
From: H. Nikolaus Schaller @ 2016-10-25 16:48 UTC (permalink / raw)
  To: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Russell King
  Cc: ldewangan, linux-omap, devicetree, linux-kernel, marek, kernel,
	letux-kernel, H. Nikolaus Schaller

Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
---
 arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
index b04adee..91456b4 100644
--- a/arch/arm/boot/dts/omap5-board-common.dtsi
+++ b/arch/arm/boot/dts/omap5-board-common.dtsi
@@ -124,6 +124,7 @@
 		compatible = "ti,abe-twl6040";
 		ti,model = "omap5-uevm";
 
+		ti,jack_detection;
 		ti,mclk-freq = <19200000>;
 
 		ti,mcpdm = <&mcpdm>;
-- 
2.7.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection
  2016-10-25 16:48 ` [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection H. Nikolaus Schaller
@ 2016-10-25 16:51   ` Peter Ujfalusi
  2016-10-25 17:10     ` Tony Lindgren
  2016-10-25 17:18     ` H. Nikolaus Schaller
  0 siblings, 2 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2016-10-25 16:51 UTC (permalink / raw)
  To: H. Nikolaus Schaller, Benoît Cousson, Tony Lindgren,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Russell King
  Cc: devicetree, letux-kernel, linux-kernel, ldewangan, kernel, marek,
	linux-omap

On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> ---
>  arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> index b04adee..91456b4 100644
> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> @@ -124,6 +124,7 @@
>  		compatible = "ti,abe-twl6040";
>  		ti,model = "omap5-uevm";
>  
> +		ti,jack_detection;

ti,jack-detection

>  		ti,mclk-freq = <19200000>;
>  
>  		ti,mcpdm = <&mcpdm>;
> 


-- 
Péter

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection
  2016-10-25 16:51   ` Peter Ujfalusi
@ 2016-10-25 17:10     ` Tony Lindgren
  2016-10-25 17:18     ` H. Nikolaus Schaller
  1 sibling, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2016-10-25 17:10 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: H. Nikolaus Schaller, Benoît Cousson, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Russell King, devicetree, letux-kernel, linux-kernel, ldewangan,
	kernel, marek, linux-omap

* Peter Ujfalusi <peter.ujfalusi@ti.com> [161025 09:54]:
> On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
> > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> > ---
> >  arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> > index b04adee..91456b4 100644
> > --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> > +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> > @@ -124,6 +124,7 @@
> >  		compatible = "ti,abe-twl6040";
> >  		ti,model = "omap5-uevm";
> >  
> > +		ti,jack_detection;
> 
> ti,jack-detection

Also subject has baord-common for both :)

Tony

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection
  2016-10-25 16:51   ` Peter Ujfalusi
  2016-10-25 17:10     ` Tony Lindgren
@ 2016-10-25 17:18     ` H. Nikolaus Schaller
  2016-10-25 17:34       ` Tony Lindgren
  1 sibling, 1 reply; 7+ messages in thread
From: H. Nikolaus Schaller @ 2016-10-25 17:18 UTC (permalink / raw)
  To: Peter Ujfalusi
  Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Russell King, devicetree, letux-kernel, linux-kernel, ldewangan,
	kernel, marek, linux-omap


> Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@ti.com>:
> 
> On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
>> index b04adee..91456b4 100644
>> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
>> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
>> @@ -124,6 +124,7 @@
>> 		compatible = "ti,abe-twl6040";
>> 		ti,model = "omap5-uevm";
>> 
>> +		ti,jack_detection;
> 
> ti,jack-detection

Hm. Looks as if we have found another bug:
which one is correct?

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289

Should I add another patch?

> 
>> 		ti,mclk-freq = <19200000>;
>> 
>> 		ti,mcpdm = <&mcpdm>;
>> 
> 
> 
> -- 
> Péter

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection
  2016-10-25 17:18     ` H. Nikolaus Schaller
@ 2016-10-25 17:34       ` Tony Lindgren
  0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2016-10-25 17:34 UTC (permalink / raw)
  To: H. Nikolaus Schaller
  Cc: Peter Ujfalusi, Benoît Cousson, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	Russell King, devicetree, letux-kernel, linux-kernel, ldewangan,
	kernel, marek, linux-omap

* H. Nikolaus Schaller <hns@goldelico.com> [161025 10:20]:
> 
> > Am 25.10.2016 um 18:51 schrieb Peter Ujfalusi <peter.ujfalusi@ti.com>:
> > 
> > On 10/25/2016 07:48 PM, H. Nikolaus Schaller wrote:
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/omap5-board-common.dtsi | 1 +
> >> 1 file changed, 1 insertion(+)
> >> 
> >> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> index b04adee..91456b4 100644
> >> --- a/arch/arm/boot/dts/omap5-board-common.dtsi
> >> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi
> >> @@ -124,6 +124,7 @@
> >> 		compatible = "ti,abe-twl6040";
> >> 		ti,model = "omap5-uevm";
> >> 
> >> +		ti,jack_detection;
> > 
> > ti,jack-detection
> 
> Hm. Looks as if we have found another bug:
> which one is correct?
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/omap-abe-twl6040.txt#n15
> 
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/sound/soc/omap/omap-abe-twl6040.c#n289
> 
> Should I add another patch?

We have parts of omap-abe-twl6040.txt, the driver and omap4-sdp.dts all
using ti,jack-detection. So omap-abe-twl6040.txt is wrong for the use
of ti,jack_detection.

Regards,

Tony

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-25 17:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-25 16:48 [PATCH v2 0/2] DT Fixes for OMAP5 boards H. Nikolaus Schaller
2016-10-25 16:48 ` [PATCH v2 1/2] dts: omap5: baord-common: add phandle to reference Palmas gpadc H. Nikolaus Schaller
2016-10-25 16:48 ` [PATCH v2 2/2] dts: omap5: baord-common: enable twl6040 headset jack detection H. Nikolaus Schaller
2016-10-25 16:51   ` Peter Ujfalusi
2016-10-25 17:10     ` Tony Lindgren
2016-10-25 17:18     ` H. Nikolaus Schaller
2016-10-25 17:34       ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).