* drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
@ 2020-08-08 11:39 kernel test robot
2020-08-08 12:44 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2020-08-08 11:39 UTC (permalink / raw)
To: David Hildenbrand
Cc: kbuild-all, linux-kernel, Michael S. Tsirkin, Pankaj Gupta
[-- Attachment #1: Type: text/plain, Size: 2756 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 449dc8c97089a6e09fb2dac4d92b1b7ac0eb7c1e
commit: 5f1f79bbc9e26fa9412fa9522f957bb8f030c442 virtio-mem: Paravirtualized memory hotplug
date: 9 weeks ago
config: x86_64-randconfig-m001-20200808 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:1607 calculate_bandwidth() warn: Function too hairy. No more merges.
Old smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3387 bw_calcs() warn: inconsistent indenting
vim +/rc +1031 drivers/virtio/virtio_mem.c
978
979 /*
980 * Try to plug the desired number of subblocks of a memory block that
981 * is already added to Linux.
982 *
983 * Will modify the state of the memory block.
984 *
985 * Note: Can fail after some subblocks were successfully plugged.
986 */
987 static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id,
988 uint64_t *nb_sb, bool online)
989 {
990 unsigned long pfn, nr_pages;
991 int sb_id, count;
992 int rc;
993
994 if (WARN_ON_ONCE(!*nb_sb))
995 return -EINVAL;
996
997 while (*nb_sb) {
998 sb_id = virtio_mem_mb_first_unplugged_sb(vm, mb_id);
999 if (sb_id >= vm->nb_sb_per_mb)
1000 break;
1001 count = 1;
1002 while (count < *nb_sb &&
1003 sb_id + count < vm->nb_sb_per_mb &&
1004 !virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id + count,
1005 1))
1006 count++;
1007
1008 rc = virtio_mem_mb_plug_sb(vm, mb_id, sb_id, count);
1009 if (rc)
1010 return rc;
1011 *nb_sb -= count;
1012 if (!online)
1013 continue;
1014
1015 /* fake-online the pages if the memory block is online */
1016 pfn = PFN_DOWN(virtio_mem_mb_id_to_phys(mb_id) +
1017 sb_id * vm->subblock_size);
1018 nr_pages = PFN_DOWN(count * vm->subblock_size);
1019 virtio_mem_fake_online(pfn, nr_pages);
1020 }
1021
1022 if (virtio_mem_mb_test_sb_plugged(vm, mb_id, 0, vm->nb_sb_per_mb)) {
1023 if (online)
1024 virtio_mem_mb_set_state(vm, mb_id,
1025 VIRTIO_MEM_MB_STATE_ONLINE);
1026 else
1027 virtio_mem_mb_set_state(vm, mb_id,
1028 VIRTIO_MEM_MB_STATE_OFFLINE);
1029 }
1030
> 1031 return rc;
1032 }
1033
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49578 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
2020-08-08 11:39 drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc' kernel test robot
@ 2020-08-08 12:44 ` David Hildenbrand
2020-08-10 2:24 ` [kbuild-all] " Rong Chen
0 siblings, 1 reply; 4+ messages in thread
From: David Hildenbrand @ 2020-08-08 12:44 UTC (permalink / raw)
To: kernel test robot
Cc: David Hildenbrand, kbuild-all, linux-kernel, Michael S. Tsirkin,
Pankaj Gupta
> Am 08.08.2020 um 13:39 schrieb kernel test robot <lkp@intel.com>:
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 449dc8c97089a6e09fb2dac4d92b1b7ac0eb7c1e
> commit: 5f1f79bbc9e26fa9412fa9522f957bb8f030c442 virtio-mem: Paravirtualized memory hotplug
> date: 9 weeks ago
> config: x86_64-randconfig-m001-20200808 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
Was there a delay in sending these out? The fix by Dan is long upstream: 1c3d69ab5348
> New smatch warnings:
> drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:1607 calculate_bandwidth() warn: Function too hairy. No more merges.
>
> Old smatch warnings:
> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3387 bw_calcs() warn: inconsistent indenting
>
> vim +/rc +1031 drivers/virtio/virtio_mem.c
>
> 978
> 979 /*
> 980 * Try to plug the desired number of subblocks of a memory block that
> 981 * is already added to Linux.
> 982 *
> 983 * Will modify the state of the memory block.
> 984 *
> 985 * Note: Can fail after some subblocks were successfully plugged.
> 986 */
> 987 static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id,
> 988 uint64_t *nb_sb, bool online)
> 989 {
> 990 unsigned long pfn, nr_pages;
> 991 int sb_id, count;
> 992 int rc;
> 993
> 994 if (WARN_ON_ONCE(!*nb_sb))
> 995 return -EINVAL;
> 996
> 997 while (*nb_sb) {
> 998 sb_id = virtio_mem_mb_first_unplugged_sb(vm, mb_id);
> 999 if (sb_id >= vm->nb_sb_per_mb)
> 1000 break;
> 1001 count = 1;
> 1002 while (count < *nb_sb &&
> 1003 sb_id + count < vm->nb_sb_per_mb &&
> 1004 !virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id + count,
> 1005 1))
> 1006 count++;
> 1007
> 1008 rc = virtio_mem_mb_plug_sb(vm, mb_id, sb_id, count);
> 1009 if (rc)
> 1010 return rc;
> 1011 *nb_sb -= count;
> 1012 if (!online)
> 1013 continue;
> 1014
> 1015 /* fake-online the pages if the memory block is online */
> 1016 pfn = PFN_DOWN(virtio_mem_mb_id_to_phys(mb_id) +
> 1017 sb_id * vm->subblock_size);
> 1018 nr_pages = PFN_DOWN(count * vm->subblock_size);
> 1019 virtio_mem_fake_online(pfn, nr_pages);
> 1020 }
> 1021
> 1022 if (virtio_mem_mb_test_sb_plugged(vm, mb_id, 0, vm->nb_sb_per_mb)) {
> 1023 if (online)
> 1024 virtio_mem_mb_set_state(vm, mb_id,
> 1025 VIRTIO_MEM_MB_STATE_ONLINE);
> 1026 else
> 1027 virtio_mem_mb_set_state(vm, mb_id,
> 1028 VIRTIO_MEM_MB_STATE_OFFLINE);
> 1029 }
> 1030
>> 1031 return rc;
> 1032 }
> 1033
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> <.config.gz>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kbuild-all] Re: drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
2020-08-08 12:44 ` David Hildenbrand
@ 2020-08-10 2:24 ` Rong Chen
2020-08-10 7:55 ` David Hildenbrand
0 siblings, 1 reply; 4+ messages in thread
From: Rong Chen @ 2020-08-10 2:24 UTC (permalink / raw)
To: David Hildenbrand, kernel test robot
Cc: David Hildenbrand, kbuild-all, linux-kernel, Michael S. Tsirkin,
Pankaj Gupta
On 8/8/20 8:44 PM, David Hildenbrand wrote:
>
>> Am 08.08.2020 um 13:39 schrieb kernel test robot <lkp@intel.com>:
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 449dc8c97089a6e09fb2dac4d92b1b7ac0eb7c1e
>> commit: 5f1f79bbc9e26fa9412fa9522f957bb8f030c442 virtio-mem: Paravirtualized memory hotplug
>> date: 9 weeks ago
>> config: x86_64-randconfig-m001-20200808 (attached as .config)
>> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
> Was there a delay in sending these out? The fix by Dan is long upstream: 1c3d69ab5348
Hi David,
Sorry for the inconvenience, the bot will check head commit before
reporting usually, we'll take a look.
Best Regards,
Rong Chen
>
>> New smatch warnings:
>> drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
>> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:1607 calculate_bandwidth() warn: Function too hairy. No more merges.
>>
>> Old smatch warnings:
>> drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3387 bw_calcs() warn: inconsistent indenting
>>
>> vim +/rc +1031 drivers/virtio/virtio_mem.c
>>
>> 978
>> 979 /*
>> 980 * Try to plug the desired number of subblocks of a memory block that
>> 981 * is already added to Linux.
>> 982 *
>> 983 * Will modify the state of the memory block.
>> 984 *
>> 985 * Note: Can fail after some subblocks were successfully plugged.
>> 986 */
>> 987 static int virtio_mem_mb_plug_any_sb(struct virtio_mem *vm, unsigned long mb_id,
>> 988 uint64_t *nb_sb, bool online)
>> 989 {
>> 990 unsigned long pfn, nr_pages;
>> 991 int sb_id, count;
>> 992 int rc;
>> 993
>> 994 if (WARN_ON_ONCE(!*nb_sb))
>> 995 return -EINVAL;
>> 996
>> 997 while (*nb_sb) {
>> 998 sb_id = virtio_mem_mb_first_unplugged_sb(vm, mb_id);
>> 999 if (sb_id >= vm->nb_sb_per_mb)
>> 1000 break;
>> 1001 count = 1;
>> 1002 while (count < *nb_sb &&
>> 1003 sb_id + count < vm->nb_sb_per_mb &&
>> 1004 !virtio_mem_mb_test_sb_plugged(vm, mb_id, sb_id + count,
>> 1005 1))
>> 1006 count++;
>> 1007
>> 1008 rc = virtio_mem_mb_plug_sb(vm, mb_id, sb_id, count);
>> 1009 if (rc)
>> 1010 return rc;
>> 1011 *nb_sb -= count;
>> 1012 if (!online)
>> 1013 continue;
>> 1014
>> 1015 /* fake-online the pages if the memory block is online */
>> 1016 pfn = PFN_DOWN(virtio_mem_mb_id_to_phys(mb_id) +
>> 1017 sb_id * vm->subblock_size);
>> 1018 nr_pages = PFN_DOWN(count * vm->subblock_size);
>> 1019 virtio_mem_fake_online(pfn, nr_pages);
>> 1020 }
>> 1021
>> 1022 if (virtio_mem_mb_test_sb_plugged(vm, mb_id, 0, vm->nb_sb_per_mb)) {
>> 1023 if (online)
>> 1024 virtio_mem_mb_set_state(vm, mb_id,
>> 1025 VIRTIO_MEM_MB_STATE_ONLINE);
>> 1026 else
>> 1027 virtio_mem_mb_set_state(vm, mb_id,
>> 1028 VIRTIO_MEM_MB_STATE_OFFLINE);
>> 1029 }
>> 1030
>>> 1031 return rc;
>> 1032 }
>> 1033
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>> <.config.gz>
> _______________________________________________
> kbuild-all mailing list -- kbuild-all@lists.01.org
> To unsubscribe send an email to kbuild-all-leave@lists.01.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kbuild-all] Re: drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc'.
2020-08-10 2:24 ` [kbuild-all] " Rong Chen
@ 2020-08-10 7:55 ` David Hildenbrand
0 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-08-10 7:55 UTC (permalink / raw)
To: Rong Chen, David Hildenbrand, kernel test robot
Cc: kbuild-all, linux-kernel, Michael S. Tsirkin, Pankaj Gupta
On 10.08.20 04:24, Rong Chen wrote:
>
>
> On 8/8/20 8:44 PM, David Hildenbrand wrote:
>>
>>> Am 08.08.2020 um 13:39 schrieb kernel test robot <lkp@intel.com>:
>>>
>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>> head: 449dc8c97089a6e09fb2dac4d92b1b7ac0eb7c1e
>>> commit: 5f1f79bbc9e26fa9412fa9522f957bb8f030c442 virtio-mem: Paravirtualized memory hotplug
>>> date: 9 weeks ago
>>> config: x86_64-randconfig-m001-20200808 (attached as .config)
>>> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
>>>
>>> If you fix the issue, kindly add following tag as appropriate
>>> Reported-by: kernel test robot <lkp@intel.com>
>>>
>> Was there a delay in sending these out? The fix by Dan is long upstream: 1c3d69ab5348
> Hi David,
Hi Rong,
it also says "date: 9 weeks ago", which sounded kind of late for
"0-DAY CI" long after a kernel release, that's why I was wondering :)
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-10 7:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-08 11:39 drivers/virtio/virtio_mem.c:1031 virtio_mem_mb_plug_any_sb() error: uninitialized symbol 'rc' kernel test robot
2020-08-08 12:44 ` David Hildenbrand
2020-08-10 2:24 ` [kbuild-all] " Rong Chen
2020-08-10 7:55 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).